From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63E12C32792 for ; Thu, 3 Oct 2019 16:18:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D85120865 for ; Thu, 3 Oct 2019 16:18:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570119499; bh=n46A0WxBsaP3OlEwVOYLlKlMlSHCyjYYFsBf+0xaCu4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=HLRkkT8rsNZKQe5J9smpgvBecJUNH9bliumJV4e0UP41HyE9oTNNbdTLez4ZUeefC TdaqjH3E7wzINnUh7Il5tqrJFlu1PHGmFNYkIhFO4aZXrDUEITLHR0iIAaUV1qZlpo 90eQI00tr5oGGDa6SgtJvTnVKAesV9yvYcsi3ojk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732152AbfJCQSS (ORCPT ); Thu, 3 Oct 2019 12:18:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:44580 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733160AbfJCQSI (ORCPT ); Thu, 3 Oct 2019 12:18:08 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CF076222BE; Thu, 3 Oct 2019 16:18:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570119488; bh=n46A0WxBsaP3OlEwVOYLlKlMlSHCyjYYFsBf+0xaCu4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ceCVFHzjtiyIm1ymkgxUu3F0sy2FIGaNZC/BuwqfCrIuh03k07FlzLcLU/XMa2K+I Bj2gjuXrULlb95p4tRX+vS3UsmsvxZQNsDU4NHNMUKyIOOqCxtMeZ1tQBvlIRRU8yA dGMnNCmJk+iDBaLOwxoRUqg0sqaq0yfSprRVQiHY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , syzbot+79d18aac4bf1770dd050@syzkaller.appspotmail.com Subject: [PATCH 4.19 084/211] media: hdpvr: add terminating 0 at end of string Date: Thu, 3 Oct 2019 17:52:30 +0200 Message-Id: <20191003154506.337068277@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191003154447.010950442@linuxfoundation.org> References: <20191003154447.010950442@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hans Verkuil [ Upstream commit 8b8900b729e4f31f12ac1127bde137c775c327e6 ] dev->usbc_buf was passed as argument for %s, but it was not safeguarded by a terminating 0. This caused this syzbot issue: https://syzkaller.appspot.com/bug?extid=79d18aac4bf1770dd050 Reported-and-tested-by: syzbot+79d18aac4bf1770dd050@syzkaller.appspotmail.com Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/usb/hdpvr/hdpvr-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/usb/hdpvr/hdpvr-core.c b/drivers/media/usb/hdpvr/hdpvr-core.c index 46adee95f89d5..3316a17c141be 100644 --- a/drivers/media/usb/hdpvr/hdpvr-core.c +++ b/drivers/media/usb/hdpvr/hdpvr-core.c @@ -141,6 +141,7 @@ static int device_authorization(struct hdpvr_device *dev) dev->fw_ver = dev->usbc_buf[1]; + dev->usbc_buf[46] = '\0'; v4l2_info(&dev->v4l2_dev, "firmware version 0x%x dated %s\n", dev->fw_ver, &dev->usbc_buf[2]); -- 2.20.1