From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 888A5C10F14 for ; Thu, 3 Oct 2019 16:14:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 56BC120700 for ; Thu, 3 Oct 2019 16:14:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570119283; bh=4E/RbBcjTjItH7hUyD/o4g7uGpVk3R/qr6uWCh8bDxE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=2jLli65qzw1xGhnljPmfVydK6zBFcXhthRNmVyIekU0mhwKGiod9DQHnzx6Q8uz5D +H5wEy3MelXmz/IrFX7kYFKOjIBXCf2zdf5CPGg2TJjYtotrRo/Q9XJJJ2TnP7L8sq s+1rrADQngssTP4EpWP8+4M/7Brx0O9ukR6t56wE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388685AbfJCQOm (ORCPT ); Thu, 3 Oct 2019 12:14:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:38138 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727451AbfJCQOk (ORCPT ); Thu, 3 Oct 2019 12:14:40 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E03C0215EA; Thu, 3 Oct 2019 16:14:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570119279; bh=4E/RbBcjTjItH7hUyD/o4g7uGpVk3R/qr6uWCh8bDxE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T8TT2oH5xaj743x6kaF1HCSiyqFT0f5X0WGYPOf8pGdeoLtOyrdGd9Z+HhELyWYtB 0bhBGH1PI2g55j6LjXCm2ITodVMUGL7mG7af2jq6+hOwPlU19zYud2Y3U8/zqx6Zdd SpUtRgm+mLSyAl5Z2N4cGiO5dPwM+IjOrEBnMG4g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Denis Kenzior , Johannes Berg Subject: [PATCH 4.14 173/185] cfg80211: Purge frame registrations on iftype change Date: Thu, 3 Oct 2019 17:54:11 +0200 Message-Id: <20191003154519.830899272@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191003154437.541662648@linuxfoundation.org> References: <20191003154437.541662648@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Denis Kenzior commit c1d3ad84eae35414b6b334790048406bd6301b12 upstream. Currently frame registrations are not purged, even when changing the interface type. This can lead to potentially weird situations where frames possibly not allowed on a given interface type remain registered due to the type switching happening after registration. The kernel currently relies on userspace apps to actually purge the registrations themselves, this is not something that the kernel should rely on. Add a call to cfg80211_mlme_purge_registrations() to forcefully remove any registrations left over prior to switching the iftype. Cc: stable@vger.kernel.org Signed-off-by: Denis Kenzior Link: https://lore.kernel.org/r/20190828211110.15005-1-denkenz@gmail.com Signed-off-by: Johannes Berg Signed-off-by: Greg Kroah-Hartman --- net/wireless/util.c | 1 + 1 file changed, 1 insertion(+) --- a/net/wireless/util.c +++ b/net/wireless/util.c @@ -1042,6 +1042,7 @@ int cfg80211_change_iface(struct cfg8021 } cfg80211_process_rdev_events(rdev); + cfg80211_mlme_purge_registrations(dev->ieee80211_ptr); } err = rdev_change_virtual_intf(rdev, dev, ntype, params);