From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20E8EC4CED1 for ; Thu, 3 Oct 2019 17:17:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DDDFA20865 for ; Thu, 3 Oct 2019 17:17:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570123078; bh=OgZwk1+fomveGMksFmW77iGKMMg1GbLiIdE44M4+TrQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=YbzEaiD167OzGr+ZJOGtc413sUcvp3Fsn5sFyL9Att5+jPMRIKd0wmAQWn1u/laIg VbBHidh7r6Z7s5XzoIO08qrQ4eP5DX/tl5N5mX+12e0qt3R9lKryBh6IhRVCNsZAsd JVV1Cob7CZ123rEPsnL7zkakGraEzN1bMPjJHgJo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389571AbfJCRR5 (ORCPT ); Thu, 3 Oct 2019 13:17:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:50020 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389337AbfJCQVl (ORCPT ); Thu, 3 Oct 2019 12:21:41 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7B2F321A4C; Thu, 3 Oct 2019 16:21:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570119701; bh=OgZwk1+fomveGMksFmW77iGKMMg1GbLiIdE44M4+TrQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kKUKlmaTLQxkzw5n3NRg821krwgGw2wIGYftYUXc7CZ/vXeUwNW8IEegze30dEYQE 3XZKnHJJtg6lGnh1olXqEXFXEy8kIHkLX/wlNis3x00yOxT6VY52fPaiEMF0DpQS14 3o8BZsoM7s6qs5GjZzHYI8f2fk1hluSs73xn/gdA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Danit Goldberg , Jason Gunthorpe Subject: [PATCH 4.19 154/211] IB/mlx5: Free mpi in mp_slave mode Date: Thu, 3 Oct 2019 17:53:40 +0200 Message-Id: <20191003154523.179692859@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191003154447.010950442@linuxfoundation.org> References: <20191003154447.010950442@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Danit Goldberg commit 5d44adebbb7e785939df3db36ac360f5e8b73e44 upstream. ib_add_slave_port() allocates a multiport struct but never frees it. Don't leak memory, free the allocated mpi struct during driver unload. Cc: Fixes: 32f69e4be269 ("{net, IB}/mlx5: Manage port association for multiport RoCE") Link: https://lore.kernel.org/r/20190916064818.19823-3-leon@kernel.org Signed-off-by: Danit Goldberg Reviewed-by: Jason Gunthorpe Signed-off-by: Jason Gunthorpe Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/hw/mlx5/main.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/infiniband/hw/mlx5/main.c +++ b/drivers/infiniband/hw/mlx5/main.c @@ -6370,6 +6370,7 @@ static void mlx5_ib_remove(struct mlx5_c mlx5_ib_unbind_slave_port(mpi->ibdev, mpi); list_del(&mpi->list); mutex_unlock(&mlx5_ib_multiport_mutex); + kfree(mpi); return; }