From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 710CEC10F14 for ; Thu, 3 Oct 2019 16:25:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3CCE321783 for ; Thu, 3 Oct 2019 16:25:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570119902; bh=zXEalkm8rJRBxulIy0Cx5EepPxkMB05/CthgptWVr4E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=xSI46bP8pEhwxw1DChwFy3Py+K0uYBwAhZpBYySjBoA7jUiw4bUX80/uLJqSIreBr ofYFmcPuCshJ6HoyZmAY7GlIxbT+Cc+xAy+sRe1BOjBp2xW7Be8B3Ev9H3Z69uP2cb xUkt/YXc2MvwErUHDVa5CSFwkIloL6kfTKlu4Ryo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390444AbfJCQXC (ORCPT ); Thu, 3 Oct 2019 12:23:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:51842 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389500AbfJCQW6 (ORCPT ); Thu, 3 Oct 2019 12:22:58 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5660F21783; Thu, 3 Oct 2019 16:22:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570119777; bh=zXEalkm8rJRBxulIy0Cx5EepPxkMB05/CthgptWVr4E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=v0mTswhY3eXmeQ4FEFazeIYvsv5FddkepuLN/tAEZM41nou9tv03pH7i7EQnJTb8b DkTlCGJrrO4jJcsrxTFXeT84RndGbXIUQidfsZ+g9IHtcNEZyFtz/mopPWwEvybMW9 pHGf3ZcUygoUE1L4Bb8gv6h6SslN41yNTyfCFdck= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ding Xiang , Miklos Szeredi Subject: [PATCH 4.19 188/211] ovl: Fix dereferencing possible ERR_PTR() Date: Thu, 3 Oct 2019 17:54:14 +0200 Message-Id: <20191003154528.237113726@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191003154447.010950442@linuxfoundation.org> References: <20191003154447.010950442@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ding Xiang commit 97f024b9171e74c4443bbe8a8dce31b917f97ac5 upstream. if ovl_encode_real_fh() fails, no memory was allocated and the error in the error-valued pointer should be returned. Fixes: 9b6faee07470 ("ovl: check ERR_PTR() return value from ovl_encode_fh()") Signed-off-by: Ding Xiang Cc: # v4.16+ Signed-off-by: Miklos Szeredi Signed-off-by: Greg Kroah-Hartman --- fs/overlayfs/export.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/fs/overlayfs/export.c +++ b/fs/overlayfs/export.c @@ -230,9 +230,8 @@ static int ovl_d_to_fh(struct dentry *de /* Encode an upper or lower file handle */ fh = ovl_encode_real_fh(enc_lower ? ovl_dentry_lower(dentry) : ovl_dentry_upper(dentry), !enc_lower); - err = PTR_ERR(fh); if (IS_ERR(fh)) - goto fail; + return PTR_ERR(fh); err = -EOVERFLOW; if (fh->len > buflen)