From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D547C32792 for ; Thu, 3 Oct 2019 17:07:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 591C620673 for ; Thu, 3 Oct 2019 17:07:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570122437; bh=VaJEsh5UkLakPlc6ctisliyWBlDu3TrANxzQLBFR4vY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Gn7iaA6Dptq6DQcnwYrH/saIAmBfHB3aaFANduqeL4pOy1UKuOXKTr+ysRoWvXbMc pKs4F4IPAYwrDjNCunznrIsmApOEh0/CjuTtYt6MasQ96OJV1QDaf2kX4/LKXE03jA MXSrWVjgfDpdAXfm3rVHhL9z41hkzPeOpVEVwSm4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392640AbfJCRHQ (ORCPT ); Thu, 3 Oct 2019 13:07:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:46180 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404489AbfJCQgx (ORCPT ); Thu, 3 Oct 2019 12:36:53 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E0F662070B; Thu, 3 Oct 2019 16:36:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570120613; bh=VaJEsh5UkLakPlc6ctisliyWBlDu3TrANxzQLBFR4vY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=My9ykIW2xcrintFEYHXd76kAVeK9q0/qPCKA/VM1eIok5Jn5nPsPJsQdgaF6vAvTF LVAaE65HSvHVnC6o5l0CwCz4+SlLhjDEr3fePKRnDBLCHpYf4zEx4o4IudN9rwYVrF syXIh8V0zoKE30O7Devg1zOQQCl5aE8N0W0qD8sY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vladimir Oltean , Mark Brown Subject: [PATCH 5.2 249/313] spi: spi-fsl-dspi: Exit the ISR with IRQ_NONE when its not ours Date: Thu, 3 Oct 2019 17:53:47 +0200 Message-Id: <20191003154557.580679284@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191003154533.590915454@linuxfoundation.org> References: <20191003154533.590915454@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vladimir Oltean commit d41f36a6464a85c06ad920703d878e4491d2c023 upstream. The DSPI interrupt can be shared between two controllers at least on the LX2160A. In that case, the driver for one controller might misbehave and consume the other's interrupt. Fix this by actually checking if any of the bits in the status register have been asserted. Fixes: 13aed2392741 ("spi: spi-fsl-dspi: use IRQF_SHARED mode to request IRQ") Signed-off-by: Vladimir Oltean Link: https://lore.kernel.org/r/20190822212450.21420-2-olteanv@gmail.com Signed-off-by: Mark Brown Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/spi/spi-fsl-dspi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/spi/spi-fsl-dspi.c +++ b/drivers/spi/spi-fsl-dspi.c @@ -886,9 +886,11 @@ static irqreturn_t dspi_interrupt(int ir trans_mode); } } + + return IRQ_HANDLED; } - return IRQ_HANDLED; + return IRQ_NONE; } static const struct of_device_id fsl_dspi_dt_ids[] = {