From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 469BBC10F14 for ; Thu, 3 Oct 2019 16:49:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1DF59215EA for ; Thu, 3 Oct 2019 16:49:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570121364; bh=Hjp88NY3REpZW3H/VUC90t+cZ1UN3x+Ulcpaz+PzxuY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=MeZi66tEbPh0v2100lcPggOkC6DX5C6pezZHwC253aJd/r9pu0Pl5u+BX7aTSUN3W ifuPwVaDU8RDxrJV/Bae/IC3srdtxq13Pg3elnutn93TyjMDrID3m4ehmsj3kWTqzZ jE5upJI1a9cuwgsBA1MYFLtdnUUg6BoVV/AjRvhk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393071AbfJCQtX (ORCPT ); Thu, 3 Oct 2019 12:49:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:35748 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388508AbfJCQtT (ORCPT ); Thu, 3 Oct 2019 12:49:19 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DF3502070B; Thu, 3 Oct 2019 16:49:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570121359; bh=Hjp88NY3REpZW3H/VUC90t+cZ1UN3x+Ulcpaz+PzxuY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=x/OKlToBF/p0GpzU2VLYsLUwcnRmp4j1NfzeLMl7lClWwcQ+dPTFrFvbd3OUIRfDX XBvJF+zAqSf17Nze/bUTq2596K0xh5Em3RYEr5D+7cKJvZLdnp1l0D25OiQKvL2GxG L05Hoyjb7X7N54DenQ68jdmctxld//rfBpmX74hI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Peter Zijlstra (Intel)" , "Paul E. McKenney" , Juri Lelli , Sasha Levin Subject: [PATCH 5.3 249/344] rcu/tree: Fix SCHED_FIFO params Date: Thu, 3 Oct 2019 17:53:34 +0200 Message-Id: <20191003154605.026537823@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191003154540.062170222@linuxfoundation.org> References: <20191003154540.062170222@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Zijlstra [ Upstream commit 130d9c331bc59a8733b47c58ef197a2b1fa3ed43 ] A rather embarrasing mistake had us call sched_setscheduler() before initializing the parameters passed to it. Fixes: 1a763fd7c633 ("rcu/tree: Call setschedule() gp ktread to SCHED_FIFO outside of atomic region") Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Paul E. McKenney Cc: Juri Lelli Signed-off-by: Sasha Levin --- kernel/rcu/tree.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index eb764c24bc4d4..5efdce756fdf0 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -3234,13 +3234,13 @@ static int __init rcu_spawn_gp_kthread(void) t = kthread_create(rcu_gp_kthread, NULL, "%s", rcu_state.name); if (WARN_ONCE(IS_ERR(t), "%s: Could not start grace-period kthread, OOM is now expected behavior\n", __func__)) return 0; - if (kthread_prio) + if (kthread_prio) { + sp.sched_priority = kthread_prio; sched_setscheduler_nocheck(t, SCHED_FIFO, &sp); + } rnp = rcu_get_root(); raw_spin_lock_irqsave_rcu_node(rnp, flags); rcu_state.gp_kthread = t; - if (kthread_prio) - sp.sched_priority = kthread_prio; raw_spin_unlock_irqrestore_rcu_node(rnp, flags); wake_up_process(t); rcu_spawn_nocb_kthreads(); -- 2.20.1