From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 0/3] btrfs: tree-checker: False alerts fixes for log trees
Date: Fri, 4 Oct 2019 17:31:30 +0800 [thread overview]
Message-ID: <20191004093133.83582-1-wqu@suse.com> (raw)
There is a false alerts of tree-checker when running fstests/btrfs/063
in a loop.
The bug is caused by commit 59b0d030fb30 ("btrfs: tree-checker: Try to detect
missing INODE_ITEM").
For the full error analyse, please check the first patch.
The first patch will give it a quick fix, so that it can be addressed in
v5.4 release cycle.
The 2nd patch is a more proper patch, with refactor to reduce duplicated
code and add the check to INODE_REF item.
But it's pretty large (+72, -41), not sure if it's suitbale for late
-rc.
Also current write-time tree checker error message is too silent, can't
be caught by fstests nor a quick glance of dmesg. And it doesn't contain
enough info to debug.
So to enhance the error message, and make it more noisy, the 3rd patch
will enhance the error message.
Qu Wenruo (3):
btrfs: tree-checker: Fix false alerts on log trees
btrfs: tree-checker: Refactor prev_key check for ino into a function
btrfs: Enhance the error outputting for write time tree checker
fs/btrfs/disk-io.c | 2 +
fs/btrfs/tree-checker.c | 111 ++++++++++++++++++++++++++--------------
2 files changed, 74 insertions(+), 39 deletions(-)
--
2.23.0
next reply other threads:[~2019-10-04 9:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 9:31 Qu Wenruo [this message]
2019-10-04 9:31 ` [PATCH 1/3] btrfs: tree-checker: Fix false alerts on log trees Qu Wenruo
2019-10-04 13:52 ` Nikolay Borisov
2019-10-04 14:13 ` Filipe Manana
2019-10-04 14:19 ` Nikolay Borisov
2019-10-04 14:15 ` Filipe Manana
2019-10-07 15:31 ` David Sterba
2019-10-04 9:31 ` [PATCH 2/3] btrfs: tree-checker: Refactor prev_key check for ino into a function Qu Wenruo
2019-10-04 9:31 ` [PATCH 3/3] btrfs: Enhance the error outputting for write time tree checker Qu Wenruo
2019-10-07 16:46 ` [PATCH 0/3] btrfs: tree-checker: False alerts fixes for log trees David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004093133.83582-1-wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.