From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Daniel Bristot de Oliveira <bristot@redhat.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
Nadav Amit <nadav.amit@gmail.com>,
Andy Lutomirski <luto@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Song Liu <songliubraving@fb.com>,
Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [PATCH 3/3] x86/ftrace: Use text_poke()
Date: Fri, 4 Oct 2019 09:42:28 -0400 [thread overview]
Message-ID: <20191004094228.5a5774fe@gandalf.local.home> (raw)
In-Reply-To: <20191004112237.GA19463@hirez.programming.kicks-ass.net>
On Fri, 4 Oct 2019 13:22:37 +0200
Peter Zijlstra <peterz@infradead.org> wrote:
> On Thu, Oct 03, 2019 at 06:10:45PM -0400, Steven Rostedt wrote:
> > But still, we are going from 120 to 660 IPIs for every CPU. Not saying
> > it's a problem, but something that we should note. Someone (those that
> > don't like kernel interference) may complain.
>
> It is machine wide function tracing, interference is going to happen..
> :-)
>
> Anyway, we can grow the batch size if sufficient benefit can be shown to
> exist.
Yeah, I was thinking that we just go with these patches and then fix
the IPI issue when someone starts complaining ;-)
Anyway, is this series ready to go? I can pull them in (I guess I
should get an ack from Thomas or Ingo as they are x86 specific). I'm
currently working on code that affects the same code paths as this
patch, and would like to build my changes on top of this, instead of
monkeying around with major conflicts.
-- Steve
next prev parent reply other threads:[~2019-10-04 13:42 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 18:06 [PATCH 0/3] Rewrite x86/ftrace to use text_poke() Peter Zijlstra
2019-08-27 18:06 ` [PATCH 1/3] x86/alternatives: Teach text_poke_bp() to emulate instructions Peter Zijlstra
2019-10-03 5:00 ` Masami Hiramatsu
2019-10-03 8:27 ` Peter Zijlstra
2019-10-03 11:01 ` Peter Zijlstra
2019-10-03 12:32 ` Peter Zijlstra
2019-10-04 13:45 ` Masami Hiramatsu
2019-10-07 8:05 ` Peter Zijlstra
2019-10-09 13:07 ` x86/kprobes bug? (was: [PATCH 1/3] x86/alternatives: Teach text_poke_bp() to emulate instructions) Peter Zijlstra
2019-10-09 13:26 ` Peter Zijlstra
2019-10-09 13:28 ` Peter Zijlstra
2019-10-09 14:26 ` Mathieu Desnoyers
2019-10-17 19:59 ` Peter Zijlstra
2019-10-03 13:05 ` [PATCH 1/3] x86/alternatives: Teach text_poke_bp() to emulate instructions Peter Zijlstra
2019-08-27 18:06 ` [PATCH 2/3] x86/alternatives,jump_label: Provide better text_poke() batching interface Peter Zijlstra
2019-10-02 16:34 ` Daniel Bristot de Oliveira
2019-10-03 5:50 ` Masami Hiramatsu
2019-08-27 18:06 ` [PATCH 3/3] x86/ftrace: Use text_poke() Peter Zijlstra
2019-10-02 16:35 ` Daniel Bristot de Oliveira
2019-10-02 18:21 ` Peter Zijlstra
2019-10-03 22:10 ` Steven Rostedt
2019-10-04 8:10 ` Daniel Bristot de Oliveira
2019-10-04 13:40 ` Steven Rostedt
2019-10-04 14:44 ` Daniel Bristot de Oliveira
2019-10-04 15:13 ` Steven Rostedt
2019-10-07 8:08 ` Peter Zijlstra
2019-10-11 7:01 ` Peter Zijlstra
2019-10-11 7:37 ` Daniel Bristot de Oliveira
2019-10-11 10:57 ` Peter Zijlstra
2019-10-11 13:11 ` Steven Rostedt
2019-10-04 11:22 ` Peter Zijlstra
2019-10-04 13:42 ` Steven Rostedt [this message]
2019-10-22 0:36 ` Alexei Starovoitov
2019-10-22 0:43 ` Steven Rostedt
2019-10-22 3:10 ` Alexei Starovoitov
2019-10-22 3:16 ` Steven Rostedt
2019-10-22 3:19 ` Steven Rostedt
2019-10-22 4:05 ` Alexei Starovoitov
2019-10-22 11:19 ` Steven Rostedt
2019-10-22 13:44 ` Steven Rostedt
2019-10-22 17:50 ` Alexei Starovoitov
2019-10-22 18:10 ` Steven Rostedt
2019-10-22 20:46 ` Alexei Starovoitov
2019-10-22 21:04 ` Steven Rostedt
2019-10-22 21:58 ` Alexei Starovoitov
2019-10-22 22:17 ` Steven Rostedt
2019-10-23 2:02 ` Steven Rostedt
2019-10-22 22:45 ` Andy Lutomirski
2019-10-22 23:21 ` Steven Rostedt
2019-10-22 23:49 ` Alexei Starovoitov
2019-10-23 4:20 ` Andy Lutomirski
2019-10-23 9:02 ` Peter Zijlstra
2019-10-23 16:23 ` Steven Rostedt
2019-10-23 17:42 ` Steven Rostedt
2019-10-23 19:34 ` Alexei Starovoitov
2019-10-23 20:08 ` Steven Rostedt
2019-10-23 22:36 ` Alexei Starovoitov
2019-10-22 3:55 ` Alexei Starovoitov
2019-10-03 5:52 ` Masami Hiramatsu
2019-08-28 7:22 ` [PATCH 0/3] Rewrite x86/ftrace to use text_poke() Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004094228.5a5774fe@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bristot@redhat.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mhiramat@kernel.org \
--cc=nadav.amit@gmail.com \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.