All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: aliasgar.surti500@gmail.com
Cc: b-liu@ti.com, linux-usb@vger.kernel.org
Subject: Re: [PATCH] drivers: musb: removed unused status variable
Date: Fri, 4 Oct 2019 14:11:12 +0200	[thread overview]
Message-ID: <20191004121112.GA382033@kroah.com> (raw)
In-Reply-To: <20191002173913.12847-1-aliasgar.surti500@gmail.com>

On Wed, Oct 02, 2019 at 11:09:13PM +0530, aliasgar.surti500@gmail.com wrote:
> From: Aliasgar Surti <aliasgar.surti500@gmail.com>
> 
> Status variable is initialized and returned without updating it's value.
> Removed status variable and returned value directly.
> 
> Signed-off-by: Aliasgar Surti <aliasgar.surti500@gmail.com>
> ---
>  drivers/usb/musb/musb_gadget.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c
> index ffe462a657b1..2cb31fc0cd60 100644
> --- a/drivers/usb/musb/musb_gadget.c
> +++ b/drivers/usb/musb/musb_gadget.c
> @@ -1085,7 +1085,6 @@ static int musb_gadget_disable(struct usb_ep *ep)
>  	u8		epnum;
>  	struct musb_ep	*musb_ep;
>  	void __iomem	*epio;
> -	int		status = 0;
>  
>  	musb_ep = to_musb_ep(ep);
>  	musb = musb_ep->musb;
> @@ -1118,7 +1117,7 @@ static int musb_gadget_disable(struct usb_ep *ep)
>  
>  	musb_dbg(musb, "%s", musb_ep->end_point.name);
>  
> -	return status;
> +	return 0;
>  }
>  
>  /*
> -- 
> 2.17.1
> 

Someone else sent this same patch 2 hours before you did, sorry :(

      reply	other threads:[~2019-10-04 12:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-02 17:39 [PATCH] drivers: musb: removed unused status variable aliasgar.surti500
2019-10-04 12:11 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191004121112.GA382033@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=aliasgar.surti500@gmail.com \
    --cc=b-liu@ti.com \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.