From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 05/24] drm/i915: Use intel_plane_state in
 prepare and cleanup plane_fb
Date: Fri, 4 Oct 2019 16:23:14 +0300
Message-ID: <20191004132314.GB1208@intel.com>
References: <20191004113514.17064-1-maarten.lankhorst@linux.intel.com>
 <20191004113514.17064-6-maarten.lankhorst@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 81F9A6EB7C
 for <intel-gfx@lists.freedesktop.org>; Fri,  4 Oct 2019 13:23:18 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20191004113514.17064-6-maarten.lankhorst@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBPY3QgMDQsIDIwMTkgYXQgMDE6MzQ6NTVQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y
c3Qgd3JvdGU6Cj4gV2UgbmVlZCB0byBsb29rIGF0IHRoZSBodyBmYiBpbiB0aGUgcGxhbmUgc3Bs
aXQsIHNvIHJlcGxhY2UgYWxsIHRoZSBwbGFjZXMKPiB0aGF0IHVzZSBkcm1fcGxhbmVfc3RhdGUg
d2l0aCBpbnRlbF9wbGFuZV9zdGF0ZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmto
b3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IFZp
bGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cgo+IC0tLQo+ICBk
cml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rpc3BsYXkuYyB8IDI4ICsrKysrKysr
KysrLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAxMiBkZWxl
dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9p
bnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rpc3Bs
YXkuYwo+IGluZGV4IDllMzRiZTQ4Yzc3MC4uYjVlZDA5N2Q2YTU5IDEwMDY0NAo+IC0tLSBhL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAtMTQzODAsMTIgKzE0
MzgwLDE0IEBAIHN0YXRpYyB2b2lkIGZiX29ial9idW1wX3JlbmRlcl9wcmlvcml0eShzdHJ1Y3Qg
ZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqKQo+ICAgKi8KPiAgaW50Cj4gIGludGVsX3ByZXBhcmVf
cGxhbmVfZmIoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gLQkJICAgICAgIHN0cnVjdCBkcm1f
cGxhbmVfc3RhdGUgKm5ld19zdGF0ZSkKPiArCQkgICAgICAgc3RydWN0IGRybV9wbGFuZV9zdGF0
ZSAqX25ld19wbGFuZV9zdGF0ZSkKPiAgewo+ICsJc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpu
ZXdfcGxhbmVfc3RhdGUgPQo+ICsJCXRvX2ludGVsX3BsYW5lX3N0YXRlKF9uZXdfcGxhbmVfc3Rh
dGUpOwo+ICAJc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqaW50ZWxfc3RhdGUgPQo+IC0JCXRv
X2ludGVsX2F0b21pY19zdGF0ZShuZXdfc3RhdGUtPnN0YXRlKTsKPiArCQl0b19pbnRlbF9hdG9t
aWNfc3RhdGUobmV3X3BsYW5lX3N0YXRlLT5iYXNlLnN0YXRlKTsKPiAgCXN0cnVjdCBkcm1faTkx
NV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUocGxhbmUtPmRldik7Cj4gLQlzdHJ1Y3QgZHJt
X2ZyYW1lYnVmZmVyICpmYiA9IG5ld19zdGF0ZS0+ZmI7Cj4gKwlzdHJ1Y3QgZHJtX2ZyYW1lYnVm
ZmVyICpmYiA9IG5ld19wbGFuZV9zdGF0ZS0+YmFzZS5mYjsKPiAgCXN0cnVjdCBkcm1faTkxNV9n
ZW1fb2JqZWN0ICpvYmogPSBpbnRlbF9mYl9vYmooZmIpOwo+ICAJc3RydWN0IGRybV9pOTE1X2dl
bV9vYmplY3QgKm9sZF9vYmogPSBpbnRlbF9mYl9vYmoocGxhbmUtPnN0YXRlLT5mYik7Cj4gIAlp
bnQgcmV0Owo+IEBAIC0xNDQxNiw5ICsxNDQxOCw5IEBAIGludGVsX3ByZXBhcmVfcGxhbmVfZmIo
c3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gIAkJfQo+ICAJfQo+ICAKPiAtCWlmIChuZXdfc3Rh
dGUtPmZlbmNlKSB7IC8qIGV4cGxpY2l0IGZlbmNpbmcgKi8KPiArCWlmIChuZXdfcGxhbmVfc3Rh
dGUtPmJhc2UuZmVuY2UpIHsgLyogZXhwbGljaXQgZmVuY2luZyAqLwo+ICAJCXJldCA9IGk5MTVf
c3dfZmVuY2VfYXdhaXRfZG1hX2ZlbmNlKCZpbnRlbF9zdGF0ZS0+Y29tbWl0X3JlYWR5LAo+IC0J
CQkJCQkgICAgbmV3X3N0YXRlLT5mZW5jZSwKPiArCQkJCQkJICAgIG5ld19wbGFuZV9zdGF0ZS0+
YmFzZS5mZW5jZSwKPiAgCQkJCQkJICAgIEk5MTVfRkVOQ0VfVElNRU9VVCwKPiAgCQkJCQkJICAg
IEdGUF9LRVJORUwpOwo+ICAJCWlmIChyZXQgPCAwKQo+IEBAIC0xNDQzOCw3ICsxNDQ0MCw3IEBA
IGludGVsX3ByZXBhcmVfcGxhbmVfZmIoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gIAkJcmV0
dXJuIHJldDsKPiAgCX0KPiAgCj4gLQlyZXQgPSBpbnRlbF9wbGFuZV9waW5fZmIodG9faW50ZWxf
cGxhbmVfc3RhdGUobmV3X3N0YXRlKSk7Cj4gKwlyZXQgPSBpbnRlbF9wbGFuZV9waW5fZmIobmV3
X3BsYW5lX3N0YXRlKTsKPiAgCj4gIAltdXRleF91bmxvY2soJmRldl9wcml2LT5kcm0uc3RydWN0
X211dGV4KTsKPiAgCWk5MTVfZ2VtX29iamVjdF91bnBpbl9wYWdlcyhvYmopOwo+IEBAIC0xNDQ0
OCw3ICsxNDQ1MCw3IEBAIGludGVsX3ByZXBhcmVfcGxhbmVfZmIoc3RydWN0IGRybV9wbGFuZSAq
cGxhbmUsCj4gIAlmYl9vYmpfYnVtcF9yZW5kZXJfcHJpb3JpdHkob2JqKTsKPiAgCWludGVsX2Zy
b250YnVmZmVyX2ZsdXNoKG9iai0+ZnJvbnRidWZmZXIsIE9SSUdJTl9ESVJUWUZCKTsKPiAgCj4g
LQlpZiAoIW5ld19zdGF0ZS0+ZmVuY2UpIHsgLyogaW1wbGljaXQgZmVuY2luZyAqLwo+ICsJaWYg
KCFuZXdfcGxhbmVfc3RhdGUtPmJhc2UuZmVuY2UpIHsgLyogaW1wbGljaXQgZmVuY2luZyAqLwo+
ICAJCXN0cnVjdCBkbWFfZmVuY2UgKmZlbmNlOwo+ICAKPiAgCQlyZXQgPSBpOTE1X3N3X2ZlbmNl
X2F3YWl0X3Jlc2VydmF0aW9uKCZpbnRlbF9zdGF0ZS0+Y29tbWl0X3JlYWR5LAo+IEBAIC0xNDQ2
MCwxMSArMTQ0NjIsMTEgQEAgaW50ZWxfcHJlcGFyZV9wbGFuZV9mYihzdHJ1Y3QgZHJtX3BsYW5l
ICpwbGFuZSwKPiAgCj4gIAkJZmVuY2UgPSBkbWFfcmVzdl9nZXRfZXhjbF9yY3Uob2JqLT5iYXNl
LnJlc3YpOwo+ICAJCWlmIChmZW5jZSkgewo+IC0JCQlhZGRfcnBzX2Jvb3N0X2FmdGVyX3ZibGFu
ayhuZXdfc3RhdGUtPmNydGMsIGZlbmNlKTsKPiArCQkJYWRkX3Jwc19ib29zdF9hZnRlcl92Ymxh
bmsobmV3X3BsYW5lX3N0YXRlLT5iYXNlLmNydGMsIGZlbmNlKTsKPiAgCQkJZG1hX2ZlbmNlX3B1
dChmZW5jZSk7Cj4gIAkJfQo+ICAJfSBlbHNlIHsKPiAtCQlhZGRfcnBzX2Jvb3N0X2FmdGVyX3Zi
bGFuayhuZXdfc3RhdGUtPmNydGMsIG5ld19zdGF0ZS0+ZmVuY2UpOwo+ICsJCWFkZF9ycHNfYm9v
c3RfYWZ0ZXJfdmJsYW5rKG5ld19wbGFuZV9zdGF0ZS0+YmFzZS5jcnRjLCBuZXdfcGxhbmVfc3Rh
dGUtPmJhc2UuZmVuY2UpOwo+ICAJfQo+ICAKPiAgCS8qCj4gQEAgLTE0NDk0LDEwICsxNDQ5Niwx
MiBAQCBpbnRlbF9wcmVwYXJlX3BsYW5lX2ZiKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ICAg
Ki8KPiAgdm9pZAo+ICBpbnRlbF9jbGVhbnVwX3BsYW5lX2ZiKHN0cnVjdCBkcm1fcGxhbmUgKnBs
YW5lLAo+IC0JCSAgICAgICBzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpvbGRfc3RhdGUpCj4gKwkJ
ICAgICAgIHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKl9vbGRfcGxhbmVfc3RhdGUpCj4gIHsKPiAr
CXN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqb2xkX3BsYW5lX3N0YXRlID0KPiArCQl0b19pbnRl
bF9wbGFuZV9zdGF0ZShfb2xkX3BsYW5lX3N0YXRlKTsKPiAgCXN0cnVjdCBpbnRlbF9hdG9taWNf
c3RhdGUgKmludGVsX3N0YXRlID0KPiAtCQl0b19pbnRlbF9hdG9taWNfc3RhdGUob2xkX3N0YXRl
LT5zdGF0ZSk7Cj4gKwkJdG9faW50ZWxfYXRvbWljX3N0YXRlKG9sZF9wbGFuZV9zdGF0ZS0+YmFz
ZS5zdGF0ZSk7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1
KHBsYW5lLT5kZXYpOwo+ICAKPiAgCWlmIChpbnRlbF9zdGF0ZS0+cnBzX2ludGVyYWN0aXZlKSB7
Cj4gQEAgLTE0NTA3LDcgKzE0NTExLDcgQEAgaW50ZWxfY2xlYW51cF9wbGFuZV9mYihzdHJ1Y3Qg
ZHJtX3BsYW5lICpwbGFuZSwKPiAgCj4gIAkvKiBTaG91bGQgb25seSBiZSBjYWxsZWQgYWZ0ZXIg
YSBzdWNjZXNzZnVsIGludGVsX3ByZXBhcmVfcGxhbmVfZmIoKSEgKi8KPiAgCW11dGV4X2xvY2so
JmRldl9wcml2LT5kcm0uc3RydWN0X211dGV4KTsKPiAtCWludGVsX3BsYW5lX3VucGluX2ZiKHRv
X2ludGVsX3BsYW5lX3N0YXRlKG9sZF9zdGF0ZSkpOwo+ICsJaW50ZWxfcGxhbmVfdW5waW5fZmIo
b2xkX3BsYW5lX3N0YXRlKTsKPiAgCW11dGV4X3VubG9jaygmZGV2X3ByaXYtPmRybS5zdHJ1Y3Rf
bXV0ZXgpOwo+ICB9Cj4gIAo+IC0tIAo+IDIuMjMuMAo+IAo+IF9fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IElu
dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w
Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRl
bApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n
ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s
aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=