All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, andrew@lunn.ch,
	mlxsw@mellanox.com
Subject: Re: [patch net-next] net: devlink: don't ignore errors during dumpit
Date: Fri, 4 Oct 2019 14:28:08 -0700	[thread overview]
Message-ID: <20191004142808.3ce385dc@cakuba.hsd1.ca.comcast.net> (raw)
In-Reply-To: <20191004095012.1287-1-jiri@resnulli.us>

On Fri,  4 Oct 2019 11:50:12 +0200, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@mellanox.com>
> 
> Currently, some dumpit function may end-up with error which is not
> -EMSGSIZE and this error is silently ignored. Use does not have clue
> that something wrong happened. Instead of silent ignore, propagate
> the error to user.
> 
> Suggested-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>

I'd personally err on the side of caution and add this non-EMSGSIZE
handling to all the *_dumpit() helpers, even those which can only get 
a size error today, but I guess it's not super likely the errors will
change for the more static objects..

Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>

  parent reply	other threads:[~2019-10-04 21:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-04  9:50 [patch net-next] net: devlink: don't ignore errors during dumpit Jiri Pirko
2019-10-04 13:21 ` Andrew Lunn
2019-10-04 21:28 ` Jakub Kicinski [this message]
2019-10-04 22:15 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191004142808.3ce385dc@cakuba.hsd1.ca.comcast.net \
    --to=jakub.kicinski@netronome.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=jiri@resnulli.us \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.