From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH v3 00/13] ext4: add fast commit support
Date: Fri, 4 Oct 2019 15:12:47 -0400 [thread overview]
Message-ID: <20191004191247.GA12012@mit.edu> (raw)
In-Reply-To: <20191001074101.256523-1-harshadshirwadkar@gmail.com>
On Tue, Oct 01, 2019 at 12:40:49AM -0700, Harshad Shirwadkar wrote:
>
> Testing
> -------
>
> e2fsprogs was updated to set fast commit feature flag and to ignore
> fast commit blocks during e2fsck.
>
> https://github.com/harshadjs/e2fsprogs.git
>
> After applying all the patches in this series, following runs of
> xfstests were performed:
>
> - kvm-xfstest.sh -g log -c 4k
> - kvm-xfstests.sh smoke
>
> All the log tests were successful and smoke tests didn't introduce any
> additional failures.
You should probably also try running the shutdown tests, and
eventually, run all of the auto group. I've added a fast_commit group
to {kvm,gce}-xfstests, although to use it a modified e2fsprogs which
understands the fast_commit feature. I can make kvm-xfstests and
gce-xfstests image using an e2fsprogs package from debian/experimental
which has fast_commit enabled.
When I tried running all of the auto group tests, the following
failure was found in generic/047 (which is a shutdown group test).
- Ted
BEGIN TEST fast_commit (1 test): Ext4 4k block w/fast_commit Fri Oct 4 13:44:45 EDT 2019
DEVICE: /dev/vdd
EXT_MKFS_OPTIONS: -I 256 -O fast_commit,64bit
EXT_MOUNT_OPTIONS: -o block_validity
FSTYP -- ext4
PLATFORM -- Linux/x86_64 kvm-xfstests 5.3.0-rc4-xfstests-00012-gedca88337ca9 #1202 SMP Thu Oct 3 17:27:50 EDT 2019
MKFS_OPTIONS -- -q -I 256 -O fast_commit,64bit /dev/vdc
MOUNT_OPTIONS -- -o acl,user_xattr -o block_validity /dev/vdc /vdc
generic/047 [13:44:46][ 24.671344] run fstests generic/047 at 2019-10-04 13:44:46
[ 24.951140] EXT4-fs (vdc): shut down requested (1)
[ 24.952280] Aborting journal on device vdc-8.
[ 28.012724] EXT4-fs (vdc): shut down requested (2)
[ 28.013639] Aborting journal on device vdc-8.
[ 28.014486]
[ 28.014845] ============================================
[ 28.015996] WARNING: possible recursive locking detected
[ 28.017072] 5.3.0-rc4-xfstests-00012-gedca88337ca9 #1202 Not tainted
[ 28.018374] --------------------------------------------
[ 28.019693] jbd2/vdc-8/1476 is trying to acquire lock:
[ 28.020635] 000000005ce13aef (&(&sbi->s_fc_lock)->rlock){+.+.}, at: ext4_journal_fc_cleanup_cb+0x2f/0xa0
[ 28.022387]
[ 28.022387] but task is already holding lock:
[ 28.023414] 000000005ce13aef (&(&sbi->s_fc_lock)->rlock){+.+.}, at: ext4_journal_fc_commit_cb+0x83/0xa90
[ 28.025237]
[ 28.025237] other info that might help us debug this:
[ 28.026350] Possible unsafe locking scenario:
[ 28.026350]
[ 28.027336] CPU0
[ 28.027758] ----
[ 28.028240] lock(&(&sbi->s_fc_lock)->rlock);
[ 28.029105] lock(&(&sbi->s_fc_lock)->rlock);
[ 28.029937]
[ 28.029937] *** DEADLOCK ***
[ 28.029937]
[ 28.031154] May be due to missing lock nesting notation
[ 28.031154]
[ 28.032780] 1 lock held by jbd2/vdc-8/1476:
[ 28.033760] #0: 000000005ce13aef (&(&sbi->s_fc_lock)->rlock){+.+.}, at: ext4_journal_fc_commit_cb+0x83/0xa90
[ 28.035436]
[ 28.035436] stack backtrace:
[ 28.036197] CPU: 1 PID: 1476 Comm: jbd2/vdc-8 Not tainted 5.3.0-rc4-xfstests-00012-gedca88337ca9 #1202
[ 28.037868] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
[ 28.039289] Call Trace:
[ 28.039772] dump_stack+0x67/0x90
[ 28.040427] validate_chain.cold+0x1be/0x21b
[ 28.041305] __lock_acquire+0x447/0x7c0
[ 28.042069] lock_acquire+0x9a/0x180
[ 28.042738] ? ext4_journal_fc_cleanup_cb+0x2f/0xa0
[ 28.043663] _raw_spin_lock+0x31/0x80
[ 28.044346] ? ext4_journal_fc_cleanup_cb+0x2f/0xa0
[ 28.045264] ext4_journal_fc_cleanup_cb+0x2f/0xa0
[ 28.046154] jbd2_journal_commit_transaction+0x243/0x24bb
[ 28.047156] ? sched_clock_cpu+0xc/0xc0
[ 28.048099] ? lock_timer_base+0x10/0x80
[ 28.048935] ? kvm_sched_clock_read+0x14/0x30
[ 28.050022] ? sched_clock+0x5/0x10
[ 28.050853] ? sched_clock_cpu+0xc/0xc0
[ 28.051793] ? kjournald2+0x143/0x3f0
[ 28.052606] kjournald2+0x143/0x3f0
[ 28.053311] ? __wake_up_common_lock+0xc0/0xc0
[ 28.054935] kthread+0x108/0x140
[ 28.055975] ? __jbd2_debug+0x50/0x50
[ 28.057105] ? __kthread_create_on_node+0x1a0/0x1a0
[ 28.058346] ret_from_fork+0x3a/0x50
next prev parent reply other threads:[~2019-10-04 19:12 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 7:40 [PATCH v3 00/13] ext4: add fast commit support Harshad Shirwadkar
2019-10-01 7:40 ` [PATCH v3 01/13] ext4: add handling for extended mount options Harshad Shirwadkar
2019-10-16 2:14 ` Theodore Y. Ts'o
2019-10-21 20:41 ` harshad shirwadkar
2019-10-01 7:40 ` [PATCH v3 02/13] jbd2: fast commit setup and enable Harshad Shirwadkar
2019-10-16 13:03 ` Theodore Y. Ts'o
2019-10-01 7:40 ` [PATCH v3 03/13] jbd2: fast-commit commit path changes Harshad Shirwadkar
2019-10-16 16:38 ` Theodore Y. Ts'o
2019-10-01 7:40 ` [PATCH v3 04/13] jbd2: fast-commit commit path new APIs Harshad Shirwadkar
2019-10-16 17:20 ` Theodore Y. Ts'o
2019-10-01 7:40 ` [PATCH v3 05/13] jbd2: fast-commit recovery path changes Harshad Shirwadkar
2019-10-16 17:30 ` Theodore Y. Ts'o
2019-10-22 0:51 ` harshad shirwadkar
2019-10-01 7:40 ` [PATCH v3 06/13] ext4: add fields that are needed to track changed files Harshad Shirwadkar
2019-10-16 18:26 ` Theodore Y. Ts'o
2019-10-01 7:40 ` [PATCH v3 07/13] ext4: track changed files for fast commit Harshad Shirwadkar
2019-10-16 20:26 ` Theodore Y. Ts'o
2019-10-01 7:40 ` [PATCH v3 08/13] ext4: fast-commit commit range tracking Harshad Shirwadkar
2019-10-16 21:36 ` Theodore Y. Ts'o
2019-10-30 5:12 ` harshad shirwadkar
2019-10-01 7:40 ` [PATCH v3 09/13] ext4: fast-commit commit path changes Harshad Shirwadkar
2019-10-16 22:45 ` Theodore Y. Ts'o
[not found] ` <CAAJeciXQiE022GqcsTr35jSqjA6eH+zBS2KNvDPj5PovButdYA@mail.gmail.com>
2019-10-23 12:44 ` Theodore Y. Ts'o
2019-10-01 7:40 ` [PATCH v3 10/13] ext4: fast-commit recovery " Harshad Shirwadkar
2019-10-18 2:07 ` Theodore Y. Ts'o
2019-10-01 7:41 ` [PATCH v3 11/13] ext4: add support for asynchronous fast commits Harshad Shirwadkar
2019-10-25 6:28 ` Xiaoguang Wang
2019-10-01 7:41 ` [PATCH v3 12/13] docs: Add fast commit documentation Harshad Shirwadkar
2019-10-18 1:56 ` Theodore Y. Ts'o
2019-10-18 4:51 ` Andreas Dilger
2019-10-18 13:28 ` Theodore Y. Ts'o
2019-10-31 18:53 ` Andreas Dilger
2019-10-31 5:34 ` harshad shirwadkar
2019-10-31 6:41 ` harshad shirwadkar
2019-10-04 19:12 ` Theodore Y. Ts'o [this message]
2019-10-04 20:11 ` [PATCH v3 00/13] ext4: add fast commit support harshad shirwadkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004191247.GA12012@mit.edu \
--to=tytso@mit.edu \
--cc=harshadshirwadkar@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.