Re: [PATCH v7 4/8] firmware: Add new platform fallback mechanism and firmware_request_platform()

From: kbuild test robot <lkp@intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: kbuild-all@01.org, Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Darren Hart <dvhart@infradead.org>,
	Andy Shevchenko <andy@infradead.org>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	"H . Peter Anvin" <hpa@zytor.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Peter Jones <pjones@redhat.com>, Dave Olsthoorn <dave@bewaar.me>,
	x86@kernel.org, platform-driver-x86@vger.kernel.org,
	linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v7 4/8] firmware: Add new platform fallback mechanism and firmware_request_platform()
Date: Sat, 5 Oct 2019 04:45:20 +0800	[thread overview]
Message-ID: <201910050403.4uYM2RUW%lkp@intel.com> (raw)
In-Reply-To: <20191004145056.43267-5-hdegoede@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 2075 bytes --]

Hi Hans,

I love your patch! Yet something to improve:

[auto build test ERROR on efi/next]
[cannot apply to v5.4-rc1 next-20191004]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Hans-de-Goede/efi-firmware-platform-x86-Add-EFI-embedded-fw-support/20191005-021239
base:   https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git next
config: powerpc-defconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/base/firmware_loader/fallback_platform.o:(.opd+0x0): multiple definition of `fw_grow_paged_buf'
   drivers/base/firmware_loader/main.o:(.opd+0x1e0): first defined here
   drivers/base/firmware_loader/fallback_platform.o: In function `.fw_grow_paged_buf':
   fallback_platform.c:(.text+0x0): multiple definition of `.fw_grow_paged_buf'
   drivers/base/firmware_loader/main.o:main.c:(.text+0x10e0): first defined here
>> drivers/base/firmware_loader/fallback_platform.o:(.opd+0x18): multiple definition of `fw_map_paged_buf'
   drivers/base/firmware_loader/main.o:(.opd+0x1f8): first defined here
   drivers/base/firmware_loader/fallback_platform.o: In function `.fw_map_paged_buf':
   fallback_platform.c:(.text+0x30): multiple definition of `.fw_map_paged_buf'
   drivers/base/firmware_loader/main.o:main.c:(.text+0x1110): first defined here

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 25332 bytes --]