All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerzy Grzegorek <jerzy.m.grzegorek@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 01/13] utils/checkpackagelib: CommentsMenusPackagesOrder: remove '-comment' state before the '-menu' one
Date: Sat,  5 Oct 2019 14:22:15 +0200	[thread overview]
Message-ID: <20191005122227.7297-2-jerzy.m.grzegorek@gmail.com> (raw)
In-Reply-To: <20191005122227.7297-1-jerzy.m.grzegorek@gmail.com>

The comment may contain packages or if-endif block(s) but not menu(s)
of packages, so lets remove the '-comment' state before the '-menu' one.

Signed-off-by: Jerzy Grzegorek <jerzy.m.grzegorek@gmail.com>
Cc: Ricardo Martincoski <ricardo.martincoski@gmail.com>
Reviewed-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 utils/checkpackagelib/lib_config.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/utils/checkpackagelib/lib_config.py b/utils/checkpackagelib/lib_config.py
index fc0df3dd17..499660feb7 100644
--- a/utils/checkpackagelib/lib_config.py
+++ b/utils/checkpackagelib/lib_config.py
@@ -107,6 +107,9 @@ class CommentsMenusPackagesOrder(_CheckFunction):
                     self.state += "-if"
 
                 elif text.startswith("menu"):
+                    if self.state.endswith("-comment"):
+                        self.state = self.state[:-8]
+
                     self.state += "-menu"
 
             self.initialize_level_elements(text)
-- 
2.17.1

  reply	other threads:[~2019-10-05 12:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-05 12:22 [Buildroot] [PATCH v2 00/13] Improve alphabetical order checking of Config.in files Jerzy Grzegorek
2019-10-05 12:22 ` Jerzy Grzegorek [this message]
2019-10-05 12:22 ` [Buildroot] [PATCH v2 02/13] utils/checkpackagelib: CommentsMenusPackagesOrder: separate the lines support Jerzy Grzegorek
2019-10-05 12:22 ` [Buildroot] [PATCH v2 03/13] utils/checkpackagelib: CommentsMenusPackagesOrder: use '-' to describe state Jerzy Grzegorek
2019-10-05 12:22 ` [Buildroot] [PATCH v2 04/13] utils/checkpackagelib: CommentsMenusPackagesOrder: use package arrays initialize in before() Jerzy Grzegorek
2019-10-06 23:52   ` Ricardo Martincoski
2019-10-05 12:22 ` [Buildroot] [PATCH v2 05/13] utils/checkpackagelib: CommentsMenusPackagesOrder: initialize 'menu_of_packages' array Jerzy Grzegorek
2019-10-05 12:22 ` [Buildroot] [PATCH v2 06/13] utils/checkpackagelib: CommentsMenusPackagesOrder: add more Config.in files to check Jerzy Grzegorek
2019-10-05 12:22 ` [Buildroot] [PATCH v2 07/13] utils/checkpackagelib: CommentsMenusPackagesOrder: check package ordering just before 'if ' statement Jerzy Grzegorek
2019-10-05 12:22 ` [Buildroot] [PATCH v2 08/13] package/Config.in: fix packages ordering Jerzy Grzegorek
2019-10-05 13:30   ` Arnout Vandecappelle
2019-10-05 15:23     ` Jerzy Grzegorek
2019-10-07 21:03       ` Arnout Vandecappelle
2019-10-05 12:22 ` [Buildroot] [PATCH v2 09/13] utils/checkpackagelib: CommentsMenusPackagesOrder: check the order of comments menu Jerzy Grzegorek
2019-10-05 13:35   ` Arnout Vandecappelle
2019-10-05 12:22 ` [Buildroot] [PATCH v2 10/13] utils/checkpackagelib: CommentsMenusPackagesOrder: check the order of menu of menus Jerzy Grzegorek
2019-10-05 12:22 ` [Buildroot] [PATCH v2 11/13] package/Config.in: fix menus ordering Jerzy Grzegorek
2019-10-05 12:22 ` [Buildroot] [PATCH v2 12/13] package/kodi/Config.in: " Jerzy Grzegorek
2019-10-05 12:22 ` [Buildroot] [PATCH v2 13/13] " Jerzy Grzegorek
2019-10-07 21:59 ` [Buildroot] [PATCH v2 00/13] Improve alphabetical order checking of Config.in files Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191005122227.7297-2-jerzy.m.grzegorek@gmail.com \
    --to=jerzy.m.grzegorek@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.