From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D470C47404 for ; Sat, 5 Oct 2019 17:30:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EBC57222C0 for ; Sat, 5 Oct 2019 17:30:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C4StFwvN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729081AbfJERa1 (ORCPT ); Sat, 5 Oct 2019 13:30:27 -0400 Received: from mail-yb1-f194.google.com ([209.85.219.194]:37157 "EHLO mail-yb1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725826AbfJERa1 (ORCPT ); Sat, 5 Oct 2019 13:30:27 -0400 Received: by mail-yb1-f194.google.com with SMTP id z125so3235338ybc.4; Sat, 05 Oct 2019 10:30:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=SFxd5AapzSICM/6Xgqhe/u9Vw5QC679Bx+c0QdN9hnI=; b=C4StFwvN+lCG1jC5GtRTymuZCkTXZueajmp5oKh8q2nS/QR4Y2Oo9mBbom6a6lMX/v f60G7QcnH8JR/KGokgFN2ry3x3ceJqyt0nyeTAkLqQ7SsSWqzosmkiLWW2dB85RQWaUZ 84ubNkcrNehQ4E0ryRIKFRdhvYl+I1a/sJrA/gvfYI/XHD28QUBdpd3oOhyXrN43bQK5 q5eNY46ePlOob7dDWUIctgZzkEKPabn+3FopVzptgyXTYfM8jYbTjnBHttfjXTT6iDQk zucn3Ajq0P4wByuR6wWzOPHXuIzhE1ag6cVKPVQBA1dLhD2+UnXqTF4K7mG2A79O+zOM ziPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SFxd5AapzSICM/6Xgqhe/u9Vw5QC679Bx+c0QdN9hnI=; b=J7BlL7nMIjw+3RN71fvDqaEh4cU1FkNodsC/HTY8ifcmh8fZPkiySvaCE6vdaVe0v4 e/H+m1C8dxCL14QCMk/WdrLdNLXN7kvBuSUHsPUFkM4M+jp4EWezaOzMzMvpIbDq4vty fVG2Ks/rNdRnsPUTDXrg2f1QuPZot7LEByrThkgKlZogf0uRLtGm8F1b0ps5n2GFfkoQ bTXw1AJKFkgvM9nZgi2vJTaH5nQcvgzvbVnIMO6SYlM/Y0ZLzMRfdoYRp1cnd/mnGY0S oGDMqq1kgjAthy6UYcp+fzYUQS2gzVcVCYbQMM3eZi38GEg95jopHpBjYKvE1lOItA3h VrUw== X-Gm-Message-State: APjAAAU1ZK0BVN82X3o+jD1ZCP082pCoyZgqTk9eiRN8YJ7T2TJcUU8S 6T9zzyHnT17vjndq4voANOY= X-Google-Smtp-Source: APXvYqzmQLtqtYywZioGiUcaIwSMLMNOrMMcyq48VNb2gTooHR+RghLWiW32nmaFQGBN3NvDc+DJ6Q== X-Received: by 2002:a25:7701:: with SMTP id s1mr6210156ybc.286.1570296625972; Sat, 05 Oct 2019 10:30:25 -0700 (PDT) Received: from icarus (072-189-084-142.res.spectrum.com. [72.189.84.142]) by smtp.gmail.com with ESMTPSA id 12sm2546780ywu.59.2019.10.05.10.30.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Oct 2019 10:30:25 -0700 (PDT) Date: Sat, 5 Oct 2019 13:30:04 -0400 From: William Breathitt Gray To: Colin King , Jonathan Cameron , Fabrice Gasnier Cc: Maxime Coquelin , Alexandre Torgue , linux-iio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] counter: stm32: clean up indentation issue Message-ID: <20191005173004.GA7431@icarus> References: <20190925095126.20219-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190925095126.20219-1-colin.king@canonical.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 25, 2019 at 10:51:26AM +0100, Colin King wrote: > From: Colin Ian King > > There is an if statement that is indented one level too deeply, > remove the extraneous tabs. > > Signed-off-by: Colin Ian King > --- > drivers/counter/stm32-timer-cnt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/counter/stm32-timer-cnt.c b/drivers/counter/stm32-timer-cnt.c > index 644ba18a72ad..613dcccf79e1 100644 > --- a/drivers/counter/stm32-timer-cnt.c > +++ b/drivers/counter/stm32-timer-cnt.c > @@ -219,8 +219,8 @@ static ssize_t stm32_count_enable_write(struct counter_device *counter, > > if (enable) { > regmap_read(priv->regmap, TIM_CR1, &cr1); > - if (!(cr1 & TIM_CR1_CEN)) > - clk_enable(priv->clk); > + if (!(cr1 & TIM_CR1_CEN)) > + clk_enable(priv->clk); > > regmap_update_bits(priv->regmap, TIM_CR1, TIM_CR1_CEN, > TIM_CR1_CEN); > -- > 2.20.1 Acked-by: William Breathitt Gray Fabrice, I noticed the TIM_CR1_CEN check is happening before the regmap_update_bits call for the enable path, while the disable path does the check after. Is this logic is correct. William Breathitt Gray From mboxrd@z Thu Jan 1 00:00:00 1970 From: William Breathitt Gray Date: Sat, 05 Oct 2019 17:30:04 +0000 Subject: Re: [PATCH] counter: stm32: clean up indentation issue Message-Id: <20191005173004.GA7431@icarus> List-Id: References: <20190925095126.20219-1-colin.king@canonical.com> In-Reply-To: <20190925095126.20219-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King , Jonathan Cameron , Fabrice Gasnier Cc: Alexandre Torgue , linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Maxime Coquelin , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org On Wed, Sep 25, 2019 at 10:51:26AM +0100, Colin King wrote: > From: Colin Ian King > > There is an if statement that is indented one level too deeply, > remove the extraneous tabs. > > Signed-off-by: Colin Ian King > --- > drivers/counter/stm32-timer-cnt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/counter/stm32-timer-cnt.c b/drivers/counter/stm32-timer-cnt.c > index 644ba18a72ad..613dcccf79e1 100644 > --- a/drivers/counter/stm32-timer-cnt.c > +++ b/drivers/counter/stm32-timer-cnt.c > @@ -219,8 +219,8 @@ static ssize_t stm32_count_enable_write(struct counter_device *counter, > > if (enable) { > regmap_read(priv->regmap, TIM_CR1, &cr1); > - if (!(cr1 & TIM_CR1_CEN)) > - clk_enable(priv->clk); > + if (!(cr1 & TIM_CR1_CEN)) > + clk_enable(priv->clk); > > regmap_update_bits(priv->regmap, TIM_CR1, TIM_CR1_CEN, > TIM_CR1_CEN); > -- > 2.20.1 Acked-by: William Breathitt Gray Fabrice, I noticed the TIM_CR1_CEN check is happening before the regmap_update_bits call for the enable path, while the disable path does the check after. Is this logic is correct. William Breathitt Gray From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C856C47404 for ; Sat, 5 Oct 2019 17:30:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E61C2222C0 for ; Sat, 5 Oct 2019 17:30:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jBGrZqJc"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C4StFwvN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E61C2222C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JdJoVIpvZE+tc2lphtDdLm4mwmGqkIKJXefrLe5Pu7k=; b=jBGrZqJcef5s0K EY/oRReVwUiJaJ1/mqAYRLYgjNlZ928oj1qcjzXqVH6cdbak0wWFtR8nyVK0687BOX/ZQ3Luu2JtD Feu8XpPsdhX+8lh0EhJ9eV0puLA6fLqHNnLChHJWanG16qk07JteMXkqUZB35f3oj6oOYP57t7B9i 9IxlEZqTrkosmbzMFFp71WQbkqareFqLEGH3JXN16MIpi9nXhVASBqpjfn8QgC/h1xFkErVfJIFjZ 34CDt4t6rtlJkWB8LLlz+A2HxoUQFK/2OSj3i+mh1y61qwX8WwT6+qA/1fU+NjjZzsXmrMmeawzvX G2vj0zbJZZ9D5RVt13fA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iGnt2-0008Ec-1B; Sat, 05 Oct 2019 17:30:32 +0000 Received: from mail-yb1-xb44.google.com ([2607:f8b0:4864:20::b44]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iGnsx-0008Dx-S4 for linux-arm-kernel@lists.infradead.org; Sat, 05 Oct 2019 17:30:30 +0000 Received: by mail-yb1-xb44.google.com with SMTP id v37so3226479ybi.6 for ; Sat, 05 Oct 2019 10:30:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=SFxd5AapzSICM/6Xgqhe/u9Vw5QC679Bx+c0QdN9hnI=; b=C4StFwvN+lCG1jC5GtRTymuZCkTXZueajmp5oKh8q2nS/QR4Y2Oo9mBbom6a6lMX/v f60G7QcnH8JR/KGokgFN2ry3x3ceJqyt0nyeTAkLqQ7SsSWqzosmkiLWW2dB85RQWaUZ 84ubNkcrNehQ4E0ryRIKFRdhvYl+I1a/sJrA/gvfYI/XHD28QUBdpd3oOhyXrN43bQK5 q5eNY46ePlOob7dDWUIctgZzkEKPabn+3FopVzptgyXTYfM8jYbTjnBHttfjXTT6iDQk zucn3Ajq0P4wByuR6wWzOPHXuIzhE1ag6cVKPVQBA1dLhD2+UnXqTF4K7mG2A79O+zOM ziPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SFxd5AapzSICM/6Xgqhe/u9Vw5QC679Bx+c0QdN9hnI=; b=OT1g1JfUsXd7tnoM64nMgPkxS9ZTrc5bSV50TjA2mjdhhihYaLKqrTjHbTtenjnO+J UP32xQaVOeWy+H7VWQua0WmZPOhw2+hgcAUBxmk6sP6c60lJviEfN1dxJIgLQ+mER/m9 2fch3pvmfb6s9L9VQX8yaeJWRL15jTDmOZLk+kNCZTTBAf2JjvmMu1Az1Cqz3gWhK+XJ CXFAskzTTPnFOsb2Q4cIdmURa9YlVZOTkue6xbCGG979seDY1XLV1TX/pHQAIxe/PXdN SAd4zi0Szn+PR/z1lu76Ftr/3AsEm8FG0vxetV10omdNfcuEXAxeTe3KIsQfvntyiSlO 0isw== X-Gm-Message-State: APjAAAVO4EJPHKKTajggxjc38V8ffISJ114fUtjMmgTn+dooL3nY2o+a bqBFpdjHXdabZ3T+kHqVosE= X-Google-Smtp-Source: APXvYqzmQLtqtYywZioGiUcaIwSMLMNOrMMcyq48VNb2gTooHR+RghLWiW32nmaFQGBN3NvDc+DJ6Q== X-Received: by 2002:a25:7701:: with SMTP id s1mr6210156ybc.286.1570296625972; Sat, 05 Oct 2019 10:30:25 -0700 (PDT) Received: from icarus (072-189-084-142.res.spectrum.com. [72.189.84.142]) by smtp.gmail.com with ESMTPSA id 12sm2546780ywu.59.2019.10.05.10.30.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Oct 2019 10:30:25 -0700 (PDT) Date: Sat, 5 Oct 2019 13:30:04 -0400 From: William Breathitt Gray To: Colin King , Jonathan Cameron , Fabrice Gasnier Subject: Re: [PATCH] counter: stm32: clean up indentation issue Message-ID: <20191005173004.GA7431@icarus> References: <20190925095126.20219-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190925095126.20219-1-colin.king@canonical.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191005_103027_932000_F54F09C6 X-CRM114-Status: GOOD ( 14.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Torgue , linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Maxime Coquelin , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 25, 2019 at 10:51:26AM +0100, Colin King wrote: > From: Colin Ian King > > There is an if statement that is indented one level too deeply, > remove the extraneous tabs. > > Signed-off-by: Colin Ian King > --- > drivers/counter/stm32-timer-cnt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/counter/stm32-timer-cnt.c b/drivers/counter/stm32-timer-cnt.c > index 644ba18a72ad..613dcccf79e1 100644 > --- a/drivers/counter/stm32-timer-cnt.c > +++ b/drivers/counter/stm32-timer-cnt.c > @@ -219,8 +219,8 @@ static ssize_t stm32_count_enable_write(struct counter_device *counter, > > if (enable) { > regmap_read(priv->regmap, TIM_CR1, &cr1); > - if (!(cr1 & TIM_CR1_CEN)) > - clk_enable(priv->clk); > + if (!(cr1 & TIM_CR1_CEN)) > + clk_enable(priv->clk); > > regmap_update_bits(priv->regmap, TIM_CR1, TIM_CR1_CEN, > TIM_CR1_CEN); > -- > 2.20.1 Acked-by: William Breathitt Gray Fabrice, I noticed the TIM_CR1_CEN check is happening before the regmap_update_bits call for the enable path, while the disable path does the check after. Is this logic is correct. William Breathitt Gray _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel