* [Buildroot] [PATCH v1] package/collectd: needs host-bison
@ 2019-10-03 15:29 Peter Seiderer
2019-10-05 21:21 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Peter Seiderer @ 2019-10-03 15:29 UTC (permalink / raw)
To: buildroot
Since 5.9.1 the file src/liboconfig/parser.c is missing from the
tar download file, triggering the need for host-bison.
Fixes [1]:
configure: error: bison is missing and you do not have ./src/liboconfig/parser.c. Please install bison
[1] http://autobuild.buildroot.net/results/4e6f3e5fd0e64f166ae4f7db4832b37ae1fa99e0
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
package/collectd/collectd.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/collectd/collectd.mk b/package/collectd/collectd.mk
index c409a391c3..4c65ae2832 100644
--- a/package/collectd/collectd.mk
+++ b/package/collectd/collectd.mk
@@ -143,7 +143,10 @@ COLLECTD_CONF_OPTS += \
$(if $(BR2_PACKAGE_COLLECTD_WRITETSDB),--enable-write_tsdb,--disable-write_tsdb) \
$(if $(BR2_PACKAGE_COLLECTD_ZOOKEEPER),--enable-zookeeper,--disable-zookeeper)
+# since 5.9.1 the file src/liboconfig/parser.c is missing from the tar
+# download file, triggering the need for host-bison
COLLECTD_DEPENDENCIES = \
+ host-bison \
host-pkgconf \
$(if $(BR2_PACKAGE_COLLECTD_AMQP),rabbitmq-c) \
$(if $(BR2_PACKAGE_COLLECTD_APACHE),libcurl) \
--
2.23.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v1] package/collectd: needs host-bison
2019-10-03 15:29 [Buildroot] [PATCH v1] package/collectd: needs host-bison Peter Seiderer
@ 2019-10-05 21:21 ` Thomas Petazzoni
[not found] ` <20191006151851.739c4baf@gmx.net>
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2019-10-05 21:21 UTC (permalink / raw)
To: buildroot
On Thu, 3 Oct 2019 17:29:22 +0200
Peter Seiderer <ps.report@gmx.net> wrote:
> Since 5.9.1 the file src/liboconfig/parser.c is missing from the
> tar download file, triggering the need for host-bison.
>
> Fixes [1]:
>
> configure: error: bison is missing and you do not have ./src/liboconfig/parser.c. Please install bison
>
> [1] http://autobuild.buildroot.net/results/4e6f3e5fd0e64f166ae4f7db4832b37ae1fa99e0
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> package/collectd/collectd.mk | 3 +++
> 1 file changed, 3 insertions(+)
Applied to master, thanks. Could you report this issue to upstream, and
see if they consider this as a bug of their tarball, or if they want
users to install bison to build collectd?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v1] package/collectd: needs host-bison
[not found] ` <20191006151851.739c4baf@gmx.net>
@ 2019-10-06 13:29 ` Peter Seiderer
2019-10-07 20:55 ` Arnout Vandecappelle
0 siblings, 1 reply; 6+ messages in thread
From: Peter Seiderer @ 2019-10-06 13:29 UTC (permalink / raw)
To: buildroot
Re-add: CC: buildroot at buildroot.org
Regards,
Peter
On Sun, 6 Oct 2019 15:18:51 +0200, Peter Seiderer <ps.report@gmx.net> wrote:
> Hello Thomas,
>
> On Sat, 5 Oct 2019 23:21:44 +0200, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
>
> > On Thu, 3 Oct 2019 17:29:22 +0200
> > Peter Seiderer <ps.report@gmx.net> wrote:
> >
> > > Since 5.9.1 the file src/liboconfig/parser.c is missing from the
> > > tar download file, triggering the need for host-bison.
> > >
> > > Fixes [1]:
> > >
> > > configure: error: bison is missing and you do not have ./src/liboconfig/parser.c. Please install bison
> > >
> > > [1] http://autobuild.buildroot.net/results/4e6f3e5fd0e64f166ae4f7db4832b37ae1fa99e0
> > >
> > > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > > ---
> > > package/collectd/collectd.mk | 3 +++
> > > 1 file changed, 3 insertions(+)
> >
> > Applied to master, thanks. Could you report this issue to upstream, and
> > see if they consider this as a bug of their tarball, or if they want
> > users to install bison to build collectd?
>
> The seems to be more problems with the tarball generation (xz archive in
> tar.bz file, misnamed version string, etc., see [1]), added another
> comment about the missing file ([2])...
>
> Regards,
> Peter
>
> [1] https://github.com/collectd/collectd/issues/3293
> [2] https://github.com/collectd/collectd/issues/3293#issuecomment-538746116
>
> >
> > Thanks!
> >
> > Thomas
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v1] package/collectd: needs host-bison
2019-10-06 13:29 ` Peter Seiderer
@ 2019-10-07 20:55 ` Arnout Vandecappelle
2019-10-07 20:58 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle @ 2019-10-07 20:55 UTC (permalink / raw)
To: buildroot
On 06/10/2019 15:29, Peter Seiderer wrote:
> Re-add: CC: buildroot at buildroot.org
>
> Regards,
> Peter
>
> On Sun, 6 Oct 2019 15:18:51 +0200, Peter Seiderer <ps.report@gmx.net> wrote:
>
>> Hello Thomas,
>>
>> On Sat, 5 Oct 2019 23:21:44 +0200, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
>>
>>> On Thu, 3 Oct 2019 17:29:22 +0200
>>> Peter Seiderer <ps.report@gmx.net> wrote:
>>>
>>>> Since 5.9.1 the file src/liboconfig/parser.c is missing from the
>>>> tar download file, triggering the need for host-bison.
>>>>
>>>> Fixes [1]:
>>>>
>>>> configure: error: bison is missing and you do not have ./src/liboconfig/parser.c. Please install bison
>>>>
>>>> [1] http://autobuild.buildroot.net/results/4e6f3e5fd0e64f166ae4f7db4832b37ae1fa99e0
>>>>
>>>> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>>>> ---
>>>> package/collectd/collectd.mk | 3 +++
>>>> 1 file changed, 3 insertions(+)
>>>
>>> Applied to master, thanks. Could you report this issue to upstream, and
>>> see if they consider this as a bug of their tarball, or if they want
>>> users to install bison to build collectd?
>>
>> The seems to be more problems with the tarball generation (xz archive in
>> tar.bz file, misnamed version string, etc., see [1]), added another
>> comment about the missing file ([2])...
Given the following comment [3] I think it might be better to revert collectd
to 5.9.0:
"All these issues are bugs, because release process done by another person than
before. All that is done w/o explicit permission from project "owner", so
results are expected."
Or, of course, we can wait a bit to see if a proper 5.9.3 gets released...
Regards,
Arnout
[3] https://github.com/collectd/collectd/issues/3293#issuecomment-538746431
>>
>> Regards,
>> Peter
>>
>> [1] https://github.com/collectd/collectd/issues/3293
>> [2] https://github.com/collectd/collectd/issues/3293#issuecomment-538746116
>>
>>>
>>> Thanks!
>>>
>>> Thomas
>>
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v1] package/collectd: needs host-bison
2019-10-07 20:55 ` Arnout Vandecappelle
@ 2019-10-07 20:58 ` Thomas Petazzoni
2019-10-08 20:09 ` Peter Seiderer
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2019-10-07 20:58 UTC (permalink / raw)
To: buildroot
On Mon, 7 Oct 2019 22:55:11 +0200
Arnout Vandecappelle <arnout@mind.be> wrote:
> Given the following comment [3] I think it might be better to revert collectd
> to 5.9.0:
>
> "All these issues are bugs, because release process done by another person than
> before. All that is done w/o explicit permission from project "owner", so
> results are expected."
>
> Or, of course, we can wait a bit to see if a proper 5.9.3 gets released...
Let's do a revert for now ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v1] package/collectd: needs host-bison
2019-10-07 20:58 ` Thomas Petazzoni
@ 2019-10-08 20:09 ` Peter Seiderer
0 siblings, 0 replies; 6+ messages in thread
From: Peter Seiderer @ 2019-10-08 20:09 UTC (permalink / raw)
To: buildroot
Hello Thomas,
On Mon, 7 Oct 2019 22:58:46 +0200, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> On Mon, 7 Oct 2019 22:55:11 +0200
> Arnout Vandecappelle <arnout@mind.be> wrote:
>
> > Given the following comment [3] I think it might be better to revert collectd
> > to 5.9.0:
> >
> > "All these issues are bugs, because release process done by another person than
> > before. All that is done w/o explicit permission from project "owner", so
> > results are expected."
> >
> > Or, of course, we can wait a bit to see if a proper 5.9.3 gets released...
>
> Let's do a revert for now ?
>
> Thomas
According to [4] 'So, I've updated the tarball on the release page here on github.' but
I believe only the collectd-5.9.2.tar.bz2 one (and not the collectd-5.9.2.tar.gz one
used by buildroot), but the bz2 one contains now the missing parser.c file...
Regards,
Peter
[4] https://github.com/collectd/collectd/issues/3293#issuecomment-539468049
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-08 20:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-03 15:29 [Buildroot] [PATCH v1] package/collectd: needs host-bison Peter Seiderer
2019-10-05 21:21 ` Thomas Petazzoni
[not found] ` <20191006151851.739c4baf@gmx.net>
2019-10-06 13:29 ` Peter Seiderer
2019-10-07 20:55 ` Arnout Vandecappelle
2019-10-07 20:58 ` Thomas Petazzoni
2019-10-08 20:09 ` Peter Seiderer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.