From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 714BBC4740A for ; Sun, 6 Oct 2019 01:01:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 40602222CC for ; Sun, 6 Oct 2019 01:01:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570323697; bh=u9QvhR9lqJ6StmNv8NAJZHc+hhhHyZb4CxaNHiDBHbU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=scdBLVlJEZx9giPVXtnKCxf1mHBqdQkxwumiCBBYBM/JBCoEF/EVb90UwVEl9HQoL xf8OgbJE0skbpfqOQxxYgKGG+tuxyN2TxbS2G4UDEFAHRd39eymqWXD8u4y8W5bmQJ fynG0FEN9Cajk0kNsQXVnPzcwPoofvgc3n7lTLRc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727075AbfJFBBg (ORCPT ); Sat, 5 Oct 2019 21:01:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:50034 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726976AbfJFBBg (ORCPT ); Sat, 5 Oct 2019 21:01:36 -0400 Received: from dragon (li937-157.members.linode.com [45.56.119.157]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 41778222C5; Sun, 6 Oct 2019 01:01:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570323695; bh=u9QvhR9lqJ6StmNv8NAJZHc+hhhHyZb4CxaNHiDBHbU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WTlXc+UR6+Nug1PPV4pT6l8dVEOguUDilWaamNP4vKos9Hm1wt/z8pvA1g2xjY8Ru b0evmTcy66sQg1h8ni8+cntfTbYTg6cluAVCQiXBX5l6HrKbSc2ee2MjpDuHZcmk3W KHyhcAn43L3AaJSR4iIVgIIwmwvJWbqsWvipz2JU= Date: Sun, 6 Oct 2019 09:01:24 +0800 From: Shawn Guo To: Biwen Li Cc: leoyang.li@nxp.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: arm64: ls1028a-qds: correct bus of rtc Message-ID: <20191006010123.GF7150@dragon> References: <20190904085104.44709-1-biwen.li@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190904085104.44709-1-biwen.li@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 04, 2019 at 04:51:04PM +0800, Biwen Li wrote: > The rtc is on i2c2 bus(hardware), not on i2c1 channel 3, > so correct it > > Signed-off-by: Biwen Li This looks a like a fix. Do we need a Fixes tag for it? > --- > arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > index de6ef39f3118..6c0540ad9c59 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > @@ -133,11 +133,6 @@ > vcc-supply = <&sb_3v3>; > }; > > - rtc@51 { > - compatible = "nxp,pcf2129"; > - reg = <0x51>; > - }; > - > eeprom@56 { > compatible = "atmel,24c512"; > reg = <0x56>; > @@ -166,6 +161,14 @@ > }; > }; > > +&i2c1 { > + status = "okay"; Please have a newline between properties and child node. Shawn > + rtc@51 { > + compatible = "nxp,pcf2129"; > + reg = <0x51>; > + }; > +}; > + > &sai1 { > status = "okay"; > }; > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: arm64: ls1028a-qds: correct bus of rtc Date: Sun, 6 Oct 2019 09:01:24 +0800 Message-ID: <20191006010123.GF7150@dragon> References: <20190904085104.44709-1-biwen.li@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20190904085104.44709-1-biwen.li@nxp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Biwen Li Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, leoyang.li@nxp.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Wed, Sep 04, 2019 at 04:51:04PM +0800, Biwen Li wrote: > The rtc is on i2c2 bus(hardware), not on i2c1 channel 3, > so correct it > > Signed-off-by: Biwen Li This looks a like a fix. Do we need a Fixes tag for it? > --- > arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > index de6ef39f3118..6c0540ad9c59 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > @@ -133,11 +133,6 @@ > vcc-supply = <&sb_3v3>; > }; > > - rtc@51 { > - compatible = "nxp,pcf2129"; > - reg = <0x51>; > - }; > - > eeprom@56 { > compatible = "atmel,24c512"; > reg = <0x56>; > @@ -166,6 +161,14 @@ > }; > }; > > +&i2c1 { > + status = "okay"; Please have a newline between properties and child node. Shawn > + rtc@51 { > + compatible = "nxp,pcf2129"; > + reg = <0x51>; > + }; > +}; > + > &sai1 { > status = "okay"; > }; > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AD13C47404 for ; Sun, 6 Oct 2019 01:01:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EEB16222C5 for ; Sun, 6 Oct 2019 01:01:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UEcsc7V2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="WTlXc+UR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EEB16222C5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BOa1VdamG3HH6g0oAjeLVl7gVC0JwhU3Zv+KndTKrW0=; b=UEcsc7V2q2rYw/ DZTDnobCxgUhdTkSGOBZmnAoM1hU3SEcFK2H65LP2qberwoXUugI1jGQ0SRlmSZUykhTh7Qu1L25L hqOJlnLO4E5Oi4wqNB+i4BUJhnbVkO0Bk0XfaMEambbhBT1d9+5gQM8aepIkcQHUzL/ABjXCOjcB1 QCH1V7JkFC912tDC5rwIKaO1w/8Aw4T1I/vkzMOpYYttVy0sJKdib2nqX97coqE2UL3pPAQ2DFnC5 b33oAdT2HV5rIOL1PBPLYua+kgXNlH+dlaXszN96hjQRLC5op97MvH/lzvCzkCsUJR2W3iLJ7yC1N yK7zj9yi7OmoNn/qMD6g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iGuvb-0001Qq-OD; Sun, 06 Oct 2019 01:01:39 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iGuvY-0001Pu-G3 for linux-arm-kernel@lists.infradead.org; Sun, 06 Oct 2019 01:01:37 +0000 Received: from dragon (li937-157.members.linode.com [45.56.119.157]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 41778222C5; Sun, 6 Oct 2019 01:01:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570323695; bh=u9QvhR9lqJ6StmNv8NAJZHc+hhhHyZb4CxaNHiDBHbU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WTlXc+UR6+Nug1PPV4pT6l8dVEOguUDilWaamNP4vKos9Hm1wt/z8pvA1g2xjY8Ru b0evmTcy66sQg1h8ni8+cntfTbYTg6cluAVCQiXBX5l6HrKbSc2ee2MjpDuHZcmk3W KHyhcAn43L3AaJSR4iIVgIIwmwvJWbqsWvipz2JU= Date: Sun, 6 Oct 2019 09:01:24 +0800 From: Shawn Guo To: Biwen Li Subject: Re: arm64: ls1028a-qds: correct bus of rtc Message-ID: <20191006010123.GF7150@dragon> References: <20190904085104.44709-1-biwen.li@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190904085104.44709-1-biwen.li@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191005_180136_556610_2F736BD2 X-CRM114-Status: GOOD ( 14.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, leoyang.li@nxp.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 04, 2019 at 04:51:04PM +0800, Biwen Li wrote: > The rtc is on i2c2 bus(hardware), not on i2c1 channel 3, > so correct it > > Signed-off-by: Biwen Li This looks a like a fix. Do we need a Fixes tag for it? > --- > arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > index de6ef39f3118..6c0540ad9c59 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > @@ -133,11 +133,6 @@ > vcc-supply = <&sb_3v3>; > }; > > - rtc@51 { > - compatible = "nxp,pcf2129"; > - reg = <0x51>; > - }; > - > eeprom@56 { > compatible = "atmel,24c512"; > reg = <0x56>; > @@ -166,6 +161,14 @@ > }; > }; > > +&i2c1 { > + status = "okay"; Please have a newline between properties and child node. Shawn > + rtc@51 { > + compatible = "nxp,pcf2129"; > + reg = <0x51>; > + }; > +}; > + > &sai1 { > status = "okay"; > }; > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel