* arm64: ls1028a-qds: correct bus of rtc
@ 2019-09-04 8:51 ` Biwen Li
0 siblings, 0 replies; 5+ messages in thread
From: Biwen Li @ 2019-09-04 8:51 UTC (permalink / raw)
To: shawnguo, leoyang.li, robh+dt, mark.rutland
Cc: linux-arm-kernel, devicetree, linux-kernel, Biwen Li
The rtc is on i2c2 bus(hardware), not on i2c1 channel 3,
so correct it
Signed-off-by: Biwen Li <biwen.li@nxp.com>
---
arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
index de6ef39f3118..6c0540ad9c59 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
@@ -133,11 +133,6 @@
vcc-supply = <&sb_3v3>;
};
- rtc@51 {
- compatible = "nxp,pcf2129";
- reg = <0x51>;
- };
-
eeprom@56 {
compatible = "atmel,24c512";
reg = <0x56>;
@@ -166,6 +161,14 @@
};
};
+&i2c1 {
+ status = "okay";
+ rtc@51 {
+ compatible = "nxp,pcf2129";
+ reg = <0x51>;
+ };
+};
+
&sai1 {
status = "okay";
};
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* arm64: ls1028a-qds: correct bus of rtc
@ 2019-09-04 8:51 ` Biwen Li
0 siblings, 0 replies; 5+ messages in thread
From: Biwen Li @ 2019-09-04 8:51 UTC (permalink / raw)
To: shawnguo, leoyang.li, robh+dt, mark.rutland
Cc: devicetree, linux-kernel, linux-arm-kernel, Biwen Li
The rtc is on i2c2 bus(hardware), not on i2c1 channel 3,
so correct it
Signed-off-by: Biwen Li <biwen.li@nxp.com>
---
arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
index de6ef39f3118..6c0540ad9c59 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
@@ -133,11 +133,6 @@
vcc-supply = <&sb_3v3>;
};
- rtc@51 {
- compatible = "nxp,pcf2129";
- reg = <0x51>;
- };
-
eeprom@56 {
compatible = "atmel,24c512";
reg = <0x56>;
@@ -166,6 +161,14 @@
};
};
+&i2c1 {
+ status = "okay";
+ rtc@51 {
+ compatible = "nxp,pcf2129";
+ reg = <0x51>;
+ };
+};
+
&sai1 {
status = "okay";
};
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: arm64: ls1028a-qds: correct bus of rtc
2019-09-04 8:51 ` Biwen Li
(?)
@ 2019-10-06 1:01 ` Shawn Guo
-1 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2019-10-06 1:01 UTC (permalink / raw)
To: Biwen Li
Cc: leoyang.li, robh+dt, mark.rutland, linux-arm-kernel, devicetree,
linux-kernel
On Wed, Sep 04, 2019 at 04:51:04PM +0800, Biwen Li wrote:
> The rtc is on i2c2 bus(hardware), not on i2c1 channel 3,
> so correct it
>
> Signed-off-by: Biwen Li <biwen.li@nxp.com>
This looks a like a fix. Do we need a Fixes tag for it?
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> index de6ef39f3118..6c0540ad9c59 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> @@ -133,11 +133,6 @@
> vcc-supply = <&sb_3v3>;
> };
>
> - rtc@51 {
> - compatible = "nxp,pcf2129";
> - reg = <0x51>;
> - };
> -
> eeprom@56 {
> compatible = "atmel,24c512";
> reg = <0x56>;
> @@ -166,6 +161,14 @@
> };
> };
>
> +&i2c1 {
> + status = "okay";
Please have a newline between properties and child node.
Shawn
> + rtc@51 {
> + compatible = "nxp,pcf2129";
> + reg = <0x51>;
> + };
> +};
> +
> &sai1 {
> status = "okay";
> };
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: arm64: ls1028a-qds: correct bus of rtc
@ 2019-10-06 1:01 ` Shawn Guo
0 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2019-10-06 1:01 UTC (permalink / raw)
To: Biwen Li
Cc: mark.rutland, devicetree, linux-kernel, leoyang.li, robh+dt,
linux-arm-kernel
On Wed, Sep 04, 2019 at 04:51:04PM +0800, Biwen Li wrote:
> The rtc is on i2c2 bus(hardware), not on i2c1 channel 3,
> so correct it
>
> Signed-off-by: Biwen Li <biwen.li@nxp.com>
This looks a like a fix. Do we need a Fixes tag for it?
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> index de6ef39f3118..6c0540ad9c59 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> @@ -133,11 +133,6 @@
> vcc-supply = <&sb_3v3>;
> };
>
> - rtc@51 {
> - compatible = "nxp,pcf2129";
> - reg = <0x51>;
> - };
> -
> eeprom@56 {
> compatible = "atmel,24c512";
> reg = <0x56>;
> @@ -166,6 +161,14 @@
> };
> };
>
> +&i2c1 {
> + status = "okay";
Please have a newline between properties and child node.
Shawn
> + rtc@51 {
> + compatible = "nxp,pcf2129";
> + reg = <0x51>;
> + };
> +};
> +
> &sai1 {
> status = "okay";
> };
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: arm64: ls1028a-qds: correct bus of rtc
@ 2019-10-06 1:01 ` Shawn Guo
0 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2019-10-06 1:01 UTC (permalink / raw)
To: Biwen Li
Cc: mark.rutland, devicetree, linux-kernel, leoyang.li, robh+dt,
linux-arm-kernel
On Wed, Sep 04, 2019 at 04:51:04PM +0800, Biwen Li wrote:
> The rtc is on i2c2 bus(hardware), not on i2c1 channel 3,
> so correct it
>
> Signed-off-by: Biwen Li <biwen.li@nxp.com>
This looks a like a fix. Do we need a Fixes tag for it?
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> index de6ef39f3118..6c0540ad9c59 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> @@ -133,11 +133,6 @@
> vcc-supply = <&sb_3v3>;
> };
>
> - rtc@51 {
> - compatible = "nxp,pcf2129";
> - reg = <0x51>;
> - };
> -
> eeprom@56 {
> compatible = "atmel,24c512";
> reg = <0x56>;
> @@ -166,6 +161,14 @@
> };
> };
>
> +&i2c1 {
> + status = "okay";
Please have a newline between properties and child node.
Shawn
> + rtc@51 {
> + compatible = "nxp,pcf2129";
> + reg = <0x51>;
> + };
> +};
> +
> &sai1 {
> status = "okay";
> };
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-10-06 1:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-04 8:51 arm64: ls1028a-qds: correct bus of rtc Biwen Li
2019-09-04 8:51 ` Biwen Li
2019-10-06 1:01 ` Shawn Guo
2019-10-06 1:01 ` Shawn Guo
2019-10-06 1:01 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.