From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2732C10F14 for ; Sun, 6 Oct 2019 17:35:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 795102133F for ; Sun, 6 Oct 2019 17:35:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570383302; bh=imc0Q0pspsvYgj/52o+N72nnGePu1STZj1a8QPV/zXc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=sgS8eAOZM9/Oc4EYPh5NaHAN4GJjMC5zpQojm7gxRWI1mmLPsCjaJdDUJf0Xlr6wt CvxtQ/K7hQAKlwSlPng/MfFKP+IekCMFcAUOKC1zU1NJvRuV6JX9ec08GqMOAhF7h6 nHvScApv2kitWDqDTikmWSvJ+TN3TXzXoCMImWEo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730121AbfJFRfB (ORCPT ); Sun, 6 Oct 2019 13:35:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:33506 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728137AbfJFRez (ORCPT ); Sun, 6 Oct 2019 13:34:55 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8FE5E2087E; Sun, 6 Oct 2019 17:34:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570383295; bh=imc0Q0pspsvYgj/52o+N72nnGePu1STZj1a8QPV/zXc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wgHD/h6dX1US1tDNp4zHsz5gjhq6cu2j8RtB8GV9JoTJ9md9KMufjCkxhy0nKfGVX jqS0HSPjZtdunXlFNGj3QW5XSG3TnbAJXMt+MR11+piXMcgq4eqT8fVFg7amBcwgFJ SPFA3cDitT5aIvVvLpk+TdZCfo0Km5QKV+zxOKAM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chunyan Zhang , Baolin Wang , Stephen Boyd , Sasha Levin Subject: [PATCH 5.2 052/137] clk: sprd: Dont reference clk_init_data after registration Date: Sun, 6 Oct 2019 19:20:36 +0200 Message-Id: <20191006171213.089437093@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191006171209.403038733@linuxfoundation.org> References: <20191006171209.403038733@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stephen Boyd [ Upstream commit f6c90df8e7e33c3dc33d4d7471bc42c232b0510e ] A future patch is going to change semantics of clk_register() so that clk_hw::init is guaranteed to be NULL after a clk is registered. Avoid referencing this member here so that we don't run into NULL pointer exceptions. Cc: Chunyan Zhang Cc: Baolin Wang Signed-off-by: Stephen Boyd Link: https://lkml.kernel.org/r/20190731193517.237136-8-sboyd@kernel.org Acked-by: Baolin Wang Acked-by: Chunyan Zhang Signed-off-by: Sasha Levin --- drivers/clk/sprd/common.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/clk/sprd/common.c b/drivers/clk/sprd/common.c index e038b04472061..8bdab1c3013b8 100644 --- a/drivers/clk/sprd/common.c +++ b/drivers/clk/sprd/common.c @@ -71,16 +71,17 @@ int sprd_clk_probe(struct device *dev, struct clk_hw_onecell_data *clkhw) struct clk_hw *hw; for (i = 0; i < clkhw->num; i++) { + const char *name; hw = clkhw->hws[i]; - if (!hw) continue; + name = hw->init->name; ret = devm_clk_hw_register(dev, hw); if (ret) { dev_err(dev, "Couldn't register clock %d - %s\n", - i, hw->init->name); + i, name); return ret; } } -- 2.20.1