From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BB42C47404 for ; Mon, 7 Oct 2019 11:24:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5AB4421835 for ; Mon, 7 Oct 2019 11:24:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570447498; bh=hjXcVcJK0NpbQJa+f7TFWSRlvZy1ZIrFfr/Rfc4aJi8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=KJL7TLTXip0A7s9xNqajU7m3cu6LdKAvtv6WW8ECoqkO/f4Cl3NK2lFxosigyyqja a6nqnrEo6pFSEsZaVV5P+QTMLXAbeSBkqWuOTxu9rqn6R2zvQpzun6mTwc0gU0ANwD bD3SASv6nRIWP75+uwO9flqqDuK79HVhxhSxSi9U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728144AbfJGLY5 (ORCPT ); Mon, 7 Oct 2019 07:24:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:50396 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727442AbfJGLYz (ORCPT ); Mon, 7 Oct 2019 07:24:55 -0400 Received: from dragon (li937-157.members.linode.com [45.56.119.157]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3A61D21655; Mon, 7 Oct 2019 11:24:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570447495; bh=hjXcVcJK0NpbQJa+f7TFWSRlvZy1ZIrFfr/Rfc4aJi8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KIMmA4Vnd/pzFe9G3L79Di5PxkxuNkTcFK3yqVQ0wttpfkZqZsqcg8VSnUBVD7xCt EcYK5jbHsg+pTfwnyNFSkjjbTAWlMgzD0CEmTngraSU8Rj0mn0nMBscnOp+VrFEei2 53Xf7WGQ2exUbFIaylOjOrVcmCWjpoC5nzEjxYeM= Date: Mon, 7 Oct 2019 19:24:32 +0800 From: Shawn Guo To: Gilles DOFFE Cc: devicetree@vger.kernel.org, rennes@savoirfairelinux.com, jerome.oufella@savoirfairelinux.com, Rob Herring , Mark Rutland , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] ARM: dts: imx6qdl-rex: add gpio expander pca9535 Message-ID: <20191007112430.GD7150@dragon> References: <20190916104353.7278-1-gilles.doffe@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190916104353.7278-1-gilles.doffe@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 16, 2019 at 12:43:53PM +0200, Gilles DOFFE wrote: > The pca9535 gpio expander is present on the Rex baseboard, but missing > from the dtsi. > The pca9535 is on i2c2 bus which is common to the three SOM > variants (Basic/Pro/Ultra), thus it is activated by default. > > Add also the new gpio controller and the associated interrupt line > MX6QDL_PAD_NANDF_CS3__GPIO6_IO16. > > Signed-off-by: Gilles DOFFE > --- > arch/arm/boot/dts/imx6qdl-rex.dtsi | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6qdl-rex.dtsi b/arch/arm/boot/dts/imx6qdl-rex.dtsi > index 97f1659144ea..8a748ca1b108 100644 > --- a/arch/arm/boot/dts/imx6qdl-rex.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-rex.dtsi > @@ -132,6 +132,19 @@ > pinctrl-0 = <&pinctrl_i2c2>; > status = "okay"; > > + pca9535: gpio8@27 { gpio-expander might be a better node name? Shawn > + compatible = "nxp,pca9535"; > + reg = <0x27>; > + gpio-controller; > + #gpio-cells = <2>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pca9535>; > + interrupt-parent = <&gpio6>; > + interrupts = <16 IRQ_TYPE_LEVEL_LOW>; > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > eeprom@57 { > compatible = "atmel,24c02"; > reg = <0x57>; > @@ -237,6 +250,12 @@ > >; > }; > > + pinctrl_pca9535: pca9535 { > + fsl,pins = < > + MX6QDL_PAD_NANDF_CS3__GPIO6_IO16 0x17059 > + >; > + }; > + > pinctrl_uart1: uart1grp { > fsl,pins = < > MX6QDL_PAD_CSI0_DAT10__UART1_TX_DATA 0x1b0b1 > -- > 2.20.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEA6AECE58C for ; Mon, 7 Oct 2019 11:24:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77CDE2173B for ; Mon, 7 Oct 2019 11:24:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PX9o9ORY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="KIMmA4Vn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77CDE2173B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oMegUkoLd3wqLYhP2fmii4axnIvMktT0FxLCIhQB2gQ=; b=PX9o9ORYalzqfU P4AjT+khsnVvHbm6uR2zRUo8boeGcMFohrbSrcvKGsq5joJlOCPauNYVonE0e8jJ3tp8no/Wv/dsJ x3hIETrUdXh+e5waN5aiNyHIdNxmicjcrsjQY68tnkIHwjQwdSr+FPEQGB4aV69Ce5FBvuhdrUki1 BhPSV9D5UUEOyuwDGLDWQl12+AFMA0kHV3tt5GXjQEdL0MgGrREr94V8E+B+2skhSaCQqzYPbk5up ibfywD/TN6ZsOza0YYUYuHNnUe3ZnskKBdEICyvdDRKK9GuFau+RA54S9vCc6rOZgmfxVTbtUCVFg ZAQivSabFQg9xEiPPwSQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHR8M-0003dM-P3; Mon, 07 Oct 2019 11:24:58 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHR8J-0003Yv-ME for linux-arm-kernel@lists.infradead.org; Mon, 07 Oct 2019 11:24:57 +0000 Received: from dragon (li937-157.members.linode.com [45.56.119.157]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3A61D21655; Mon, 7 Oct 2019 11:24:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570447495; bh=hjXcVcJK0NpbQJa+f7TFWSRlvZy1ZIrFfr/Rfc4aJi8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KIMmA4Vnd/pzFe9G3L79Di5PxkxuNkTcFK3yqVQ0wttpfkZqZsqcg8VSnUBVD7xCt EcYK5jbHsg+pTfwnyNFSkjjbTAWlMgzD0CEmTngraSU8Rj0mn0nMBscnOp+VrFEei2 53Xf7WGQ2exUbFIaylOjOrVcmCWjpoC5nzEjxYeM= Date: Mon, 7 Oct 2019 19:24:32 +0800 From: Shawn Guo To: Gilles DOFFE Subject: Re: [PATCH v3] ARM: dts: imx6qdl-rex: add gpio expander pca9535 Message-ID: <20191007112430.GD7150@dragon> References: <20190916104353.7278-1-gilles.doffe@savoirfairelinux.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190916104353.7278-1-gilles.doffe@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191007_042455_753410_7B54BDE7 X-CRM114-Status: GOOD ( 17.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Sascha Hauer , rennes@savoirfairelinux.com, linux-kernel@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , jerome.oufella@savoirfairelinux.com, Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 16, 2019 at 12:43:53PM +0200, Gilles DOFFE wrote: > The pca9535 gpio expander is present on the Rex baseboard, but missing > from the dtsi. > The pca9535 is on i2c2 bus which is common to the three SOM > variants (Basic/Pro/Ultra), thus it is activated by default. > > Add also the new gpio controller and the associated interrupt line > MX6QDL_PAD_NANDF_CS3__GPIO6_IO16. > > Signed-off-by: Gilles DOFFE > --- > arch/arm/boot/dts/imx6qdl-rex.dtsi | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6qdl-rex.dtsi b/arch/arm/boot/dts/imx6qdl-rex.dtsi > index 97f1659144ea..8a748ca1b108 100644 > --- a/arch/arm/boot/dts/imx6qdl-rex.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-rex.dtsi > @@ -132,6 +132,19 @@ > pinctrl-0 = <&pinctrl_i2c2>; > status = "okay"; > > + pca9535: gpio8@27 { gpio-expander might be a better node name? Shawn > + compatible = "nxp,pca9535"; > + reg = <0x27>; > + gpio-controller; > + #gpio-cells = <2>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pca9535>; > + interrupt-parent = <&gpio6>; > + interrupts = <16 IRQ_TYPE_LEVEL_LOW>; > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > eeprom@57 { > compatible = "atmel,24c02"; > reg = <0x57>; > @@ -237,6 +250,12 @@ > >; > }; > > + pinctrl_pca9535: pca9535 { > + fsl,pins = < > + MX6QDL_PAD_NANDF_CS3__GPIO6_IO16 0x17059 > + >; > + }; > + > pinctrl_uart1: uart1grp { > fsl,pins = < > MX6QDL_PAD_CSI0_DAT10__UART1_TX_DATA 0x1b0b1 > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel