From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kirill A. Shutemov" Date: Mon, 07 Oct 2019 13:26:07 +0000 Subject: Re: [PATCH V4 2/2] mm/pgtable/debug: Add test validating architecture page table helpers Message-Id: <20191007132607.4q537nauwfn5thol@box> List-Id: References: <1570427124-21887-1-git-send-email-anshuman.khandual@arm.com> <1570427124-21887-3-git-send-email-anshuman.khandual@arm.com> <20191007130617.GB56546@gmail.com> In-Reply-To: <20191007130617.GB56546@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ingo Molnar Cc: Mark Rutland , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , James Hogan , Tetsuo Handa , Heiko Carstens , Michal Hocko , linux-mm@kvack.org, Paul Mackerras , sparclinux@vger.kernel.org, Thomas Gleixner , linux-s390@vger.kernel.org, Michael Ellerman , x86@kernel.org, Russell King - ARM Linux , Matthew Wilcox , Steven Price , Jason Gunthorpe , Gerald Schaefer , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Kees Cook , Anshuman Khandual , Masahiro Yamada , Mark Brown , Dan Williams , Vlastimil Babka , Christophe Leroy , Sri Krishna chowdary , Ard Biesheuvel , Greg Kroah-Hartman , Dave Hansen , linux-mips@vger.kernel.org, Ralf Baechle , linux-kernel@vger.kernel.org, Paul Burton , Mike Rapoport , Vineet Gupta , Martin Schwidefsky , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" On Mon, Oct 07, 2019 at 03:06:17PM +0200, Ingo Molnar wrote: > > * Anshuman Khandual wrote: > > > This adds a test module which will validate architecture page table helpers > > and accessors regarding compliance with generic MM semantics expectations. > > This will help various architectures in validating changes to the existing > > page table helpers or addition of new ones. > > > > Test page table and memory pages creating it's entries at various level are > > all allocated from system memory with required alignments. If memory pages > > with required size and alignment could not be allocated, then all depending > > individual tests are skipped. > > > diff --git a/arch/x86/include/asm/pgtable_64_types.h b/arch/x86/include/asm/pgtable_64_types.h > > index 52e5f5f2240d..b882792a3999 100644 > > --- a/arch/x86/include/asm/pgtable_64_types.h > > +++ b/arch/x86/include/asm/pgtable_64_types.h > > @@ -40,6 +40,8 @@ static inline bool pgtable_l5_enabled(void) > > #define pgtable_l5_enabled() 0 > > #endif /* CONFIG_X86_5LEVEL */ > > > > +#define mm_p4d_folded(mm) (!pgtable_l5_enabled()) > > + > > extern unsigned int pgdir_shift; > > extern unsigned int ptrs_per_p4d; > > Any deep reason this has to be a macro instead of proper C? It's a way to override the generic mm_p4d_folded(). It can be rewritten as inline function + define. Something like: #define mm_p4d_folded mm_p4d_folded static inline bool mm_p4d_folded(struct mm_struct *mm) { return !pgtable_l5_enabled(); } But I don't see much reason to be more verbose here than needed. -- Kirill A. Shutemov From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EFE5ECE58D for ; Mon, 7 Oct 2019 13:26:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EF7A821871 for ; Mon, 7 Oct 2019 13:26:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="LuKZCLEk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728336AbfJGN0L (ORCPT ); Mon, 7 Oct 2019 09:26:11 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:36192 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727923AbfJGN0L (ORCPT ); Mon, 7 Oct 2019 09:26:11 -0400 Received: by mail-ed1-f67.google.com with SMTP id h2so12435645edn.3 for ; Mon, 07 Oct 2019 06:26:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=gzC3+Ai/BcUPGOo2+frzMx33cRF/lu4IW7bk4buzvfY=; b=LuKZCLEks+pxri1fZImZ8aWZNoPyA0k53cdFVsuHb5MDqAN5knWAMDy0wPUsgUxBCF gQcbOYCIkTqaNbsMxo5RKNjpP0d8lQMy7pguGPtgJSh9DP3B9YIN2mS8bmQvpx9hwj+h f1Slcuf8Kzh1JBnKhidomUrXDTUHxpZKdm+qSnztmiyYersQcoVvJ/ohhpzjG+T7kfj/ les5EAK/LmmoySH+aJWZ1XdWfqQwdMTB2W4ogQ6nBwrh8QCxg6VIpsZnYghJaIlVBMwA tZPwZXA0ICwRWfFHd+u/u3DYHya4aQ5yYd1iqfinaPiyxKvPuAJePigymhWXfsmqSyff W1oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=gzC3+Ai/BcUPGOo2+frzMx33cRF/lu4IW7bk4buzvfY=; b=cXPOqTtL4ukQRim84I8qMjaYbumDwS6uf8int8pGfACzwV8keb+xwKbrkpbdB3PTnk uXeJhGT0OZyibWUduHtp58VDrQe2Q5AQU4+c9M20A2slSFstwFcac5sHmJKGqvv+h54F AJD6gGOouqkpwj8lcAdULwVQTBvMQfRRG0dgilHpB28dvCTBl5qR3/QSQSj7C+vnQpn+ zQYefq9D9hPGHh+gpnLiFELNO4bgZ52SHWw61x+HfcZN1Yay/evzlvVKN9Rx5k4Gm/SH Bj4W+94rh3WQ0ox+VISz8SeNNWFlxh9yg0NgKAAOOmM8SbwV8yTdWfaMzP6wEy+Run1c FUgA== X-Gm-Message-State: APjAAAXiUOVnJCNuIQBj/zDNGWHH66u9D3QHXTYcA6KioGKLhR4rplOY SZjFLKrU5/gd703o9FR8JEbi4Q== X-Google-Smtp-Source: APXvYqzElnCPZjbODoQl3J/SFOw2KfpCAczFpMms9cACkFS6giHuVTdY1dFFe29OUP7N4OGq9tG9dw== X-Received: by 2002:a05:6402:7c1:: with SMTP id u1mr29121094edy.198.1570454769090; Mon, 07 Oct 2019 06:26:09 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id t30sm3414834edt.91.2019.10.07.06.26.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Oct 2019 06:26:08 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 4DF0F10027F; Mon, 7 Oct 2019 16:26:07 +0300 (+03) Date: Mon, 7 Oct 2019 16:26:07 +0300 From: "Kirill A. Shutemov" To: Ingo Molnar Cc: Anshuman Khandual , linux-mm@kvack.org, Andrew Morton , Vlastimil Babka , Greg Kroah-Hartman , Thomas Gleixner , Mike Rapoport , Jason Gunthorpe , Dan Williams , Peter Zijlstra , Michal Hocko , Mark Rutland , Mark Brown , Steven Price , Ard Biesheuvel , Masahiro Yamada , Kees Cook , Tetsuo Handa , Matthew Wilcox , Sri Krishna chowdary , Dave Hansen , Russell King - ARM Linux , Michael Ellerman , Paul Mackerras , Martin Schwidefsky , Heiko Carstens , "David S. Miller" , Vineet Gupta , James Hogan , Paul Burton , Ralf Baechle , Gerald Schaefer , Christophe Leroy , linux-snps-arc@lists.infradead.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V4 2/2] mm/pgtable/debug: Add test validating architecture page table helpers Message-ID: <20191007132607.4q537nauwfn5thol@box> References: <1570427124-21887-1-git-send-email-anshuman.khandual@arm.com> <1570427124-21887-3-git-send-email-anshuman.khandual@arm.com> <20191007130617.GB56546@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191007130617.GB56546@gmail.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 07, 2019 at 03:06:17PM +0200, Ingo Molnar wrote: > > * Anshuman Khandual wrote: > > > This adds a test module which will validate architecture page table helpers > > and accessors regarding compliance with generic MM semantics expectations. > > This will help various architectures in validating changes to the existing > > page table helpers or addition of new ones. > > > > Test page table and memory pages creating it's entries at various level are > > all allocated from system memory with required alignments. If memory pages > > with required size and alignment could not be allocated, then all depending > > individual tests are skipped. > > > diff --git a/arch/x86/include/asm/pgtable_64_types.h b/arch/x86/include/asm/pgtable_64_types.h > > index 52e5f5f2240d..b882792a3999 100644 > > --- a/arch/x86/include/asm/pgtable_64_types.h > > +++ b/arch/x86/include/asm/pgtable_64_types.h > > @@ -40,6 +40,8 @@ static inline bool pgtable_l5_enabled(void) > > #define pgtable_l5_enabled() 0 > > #endif /* CONFIG_X86_5LEVEL */ > > > > +#define mm_p4d_folded(mm) (!pgtable_l5_enabled()) > > + > > extern unsigned int pgdir_shift; > > extern unsigned int ptrs_per_p4d; > > Any deep reason this has to be a macro instead of proper C? It's a way to override the generic mm_p4d_folded(). It can be rewritten as inline function + define. Something like: #define mm_p4d_folded mm_p4d_folded static inline bool mm_p4d_folded(struct mm_struct *mm) { return !pgtable_l5_enabled(); } But I don't see much reason to be more verbose here than needed. -- Kirill A. Shutemov From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8211AECE58C for ; Mon, 7 Oct 2019 13:29:08 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED7A621835 for ; Mon, 7 Oct 2019 13:29:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="LuKZCLEk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED7A621835 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46n1Xc69P4zDqH2 for ; Tue, 8 Oct 2019 00:29:04 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=shutemov.name (client-ip=2a00:1450:4864:20::542; helo=mail-ed1-x542.google.com; envelope-from=kirill@shutemov.name; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="LuKZCLEk"; dkim-atps=neutral Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46n1TJ550szDqL2 for ; Tue, 8 Oct 2019 00:26:12 +1100 (AEDT) Received: by mail-ed1-x542.google.com with SMTP id y91so12390659ede.9 for ; Mon, 07 Oct 2019 06:26:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=gzC3+Ai/BcUPGOo2+frzMx33cRF/lu4IW7bk4buzvfY=; b=LuKZCLEks+pxri1fZImZ8aWZNoPyA0k53cdFVsuHb5MDqAN5knWAMDy0wPUsgUxBCF gQcbOYCIkTqaNbsMxo5RKNjpP0d8lQMy7pguGPtgJSh9DP3B9YIN2mS8bmQvpx9hwj+h f1Slcuf8Kzh1JBnKhidomUrXDTUHxpZKdm+qSnztmiyYersQcoVvJ/ohhpzjG+T7kfj/ les5EAK/LmmoySH+aJWZ1XdWfqQwdMTB2W4ogQ6nBwrh8QCxg6VIpsZnYghJaIlVBMwA tZPwZXA0ICwRWfFHd+u/u3DYHya4aQ5yYd1iqfinaPiyxKvPuAJePigymhWXfsmqSyff W1oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=gzC3+Ai/BcUPGOo2+frzMx33cRF/lu4IW7bk4buzvfY=; b=HwC7hpOHaLMfWF+cU0r9gRNhX1BKRicXPEjlP5LLKglpcnm+Re+zgZv4j3LerxVk9e sO0N+qZwFX8pZ0cur6tGWRF3wO4cxutAj90uDUkEAaw1JPNbep0TzTQK+G1XKFHa07eT PYSNyFNk8a7fR7Hm1CakyXsbuZk51umGUm+OEDGtjYipUGbQb285l8Y1uKlSfSr5Izev yDd7+2NZa8GOdFuaMPhUN8EUuFdSgnUqgASg5wZoAc8hWhmf8tDSQ/2fkFzQgCWaWM2l oobM43V2+81ziX/fXU0W/QYAE1ZciNxrU1onsYnaJrHz2SCVFfMdbFPEJo/3vbp1XCUG biJA== X-Gm-Message-State: APjAAAXTBk6MYyYAF/+H25kcbVkv0BTkKh3ZHUCofnoxg2ZBryBHXV0S gOv83XYuxI15bmOMhUf6S6wJfA== X-Google-Smtp-Source: APXvYqzElnCPZjbODoQl3J/SFOw2KfpCAczFpMms9cACkFS6giHuVTdY1dFFe29OUP7N4OGq9tG9dw== X-Received: by 2002:a05:6402:7c1:: with SMTP id u1mr29121094edy.198.1570454769090; Mon, 07 Oct 2019 06:26:09 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id t30sm3414834edt.91.2019.10.07.06.26.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Oct 2019 06:26:08 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 4DF0F10027F; Mon, 7 Oct 2019 16:26:07 +0300 (+03) Date: Mon, 7 Oct 2019 16:26:07 +0300 From: "Kirill A. Shutemov" To: Ingo Molnar Subject: Re: [PATCH V4 2/2] mm/pgtable/debug: Add test validating architecture page table helpers Message-ID: <20191007132607.4q537nauwfn5thol@box> References: <1570427124-21887-1-git-send-email-anshuman.khandual@arm.com> <1570427124-21887-3-git-send-email-anshuman.khandual@arm.com> <20191007130617.GB56546@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191007130617.GB56546@gmail.com> User-Agent: NeoMutt/20180716 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , James Hogan , Tetsuo Handa , Heiko Carstens , Michal Hocko , linux-mm@kvack.org, Paul Mackerras , sparclinux@vger.kernel.org, Thomas Gleixner , linux-s390@vger.kernel.org, x86@kernel.org, Russell King - ARM Linux , Matthew Wilcox , Steven Price , Jason Gunthorpe , Gerald Schaefer , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Kees Cook , Anshuman Khandual , Masahiro Yamada , Mark Brown , Dan Williams , Vlastimil Babka , Sri Krishna chowdary , Ard Biesheuvel , Greg Kroah-Hartman , Dave Hansen , linux-mips@vger.kernel.org, Ralf Baechle , linux-kernel@vger.kernel.org, Paul Burton , Mike Rapoport , Vineet Gupta , Martin Schwidefsky , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Oct 07, 2019 at 03:06:17PM +0200, Ingo Molnar wrote: > > * Anshuman Khandual wrote: > > > This adds a test module which will validate architecture page table helpers > > and accessors regarding compliance with generic MM semantics expectations. > > This will help various architectures in validating changes to the existing > > page table helpers or addition of new ones. > > > > Test page table and memory pages creating it's entries at various level are > > all allocated from system memory with required alignments. If memory pages > > with required size and alignment could not be allocated, then all depending > > individual tests are skipped. > > > diff --git a/arch/x86/include/asm/pgtable_64_types.h b/arch/x86/include/asm/pgtable_64_types.h > > index 52e5f5f2240d..b882792a3999 100644 > > --- a/arch/x86/include/asm/pgtable_64_types.h > > +++ b/arch/x86/include/asm/pgtable_64_types.h > > @@ -40,6 +40,8 @@ static inline bool pgtable_l5_enabled(void) > > #define pgtable_l5_enabled() 0 > > #endif /* CONFIG_X86_5LEVEL */ > > > > +#define mm_p4d_folded(mm) (!pgtable_l5_enabled()) > > + > > extern unsigned int pgdir_shift; > > extern unsigned int ptrs_per_p4d; > > Any deep reason this has to be a macro instead of proper C? It's a way to override the generic mm_p4d_folded(). It can be rewritten as inline function + define. Something like: #define mm_p4d_folded mm_p4d_folded static inline bool mm_p4d_folded(struct mm_struct *mm) { return !pgtable_l5_enabled(); } But I don't see much reason to be more verbose here than needed. -- Kirill A. Shutemov From mboxrd@z Thu Jan 1 00:00:00 1970 From: kirill@shutemov.name (Kirill A. Shutemov) Date: Mon, 7 Oct 2019 16:26:07 +0300 Subject: [PATCH V4 2/2] mm/pgtable/debug: Add test validating architecture page table helpers In-Reply-To: <20191007130617.GB56546@gmail.com> References: <1570427124-21887-1-git-send-email-anshuman.khandual@arm.com> <1570427124-21887-3-git-send-email-anshuman.khandual@arm.com> <20191007130617.GB56546@gmail.com> List-ID: Message-ID: <20191007132607.4q537nauwfn5thol@box> To: linux-snps-arc@lists.infradead.org On Mon, Oct 07, 2019@03:06:17PM +0200, Ingo Molnar wrote: > > * Anshuman Khandual wrote: > > > This adds a test module which will validate architecture page table helpers > > and accessors regarding compliance with generic MM semantics expectations. > > This will help various architectures in validating changes to the existing > > page table helpers or addition of new ones. > > > > Test page table and memory pages creating it's entries at various level are > > all allocated from system memory with required alignments. If memory pages > > with required size and alignment could not be allocated, then all depending > > individual tests are skipped. > > > diff --git a/arch/x86/include/asm/pgtable_64_types.h b/arch/x86/include/asm/pgtable_64_types.h > > index 52e5f5f2240d..b882792a3999 100644 > > --- a/arch/x86/include/asm/pgtable_64_types.h > > +++ b/arch/x86/include/asm/pgtable_64_types.h > > @@ -40,6 +40,8 @@ static inline bool pgtable_l5_enabled(void) > > #define pgtable_l5_enabled() 0 > > #endif /* CONFIG_X86_5LEVEL */ > > > > +#define mm_p4d_folded(mm) (!pgtable_l5_enabled()) > > + > > extern unsigned int pgdir_shift; > > extern unsigned int ptrs_per_p4d; > > Any deep reason this has to be a macro instead of proper C? It's a way to override the generic mm_p4d_folded(). It can be rewritten as inline function + define. Something like: #define mm_p4d_folded mm_p4d_folded static inline bool mm_p4d_folded(struct mm_struct *mm) { return !pgtable_l5_enabled(); } But I don't see much reason to be more verbose here than needed. -- Kirill A. Shutemov From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD025ECE596 for ; Mon, 7 Oct 2019 13:26:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 936122173B for ; Mon, 7 Oct 2019 13:26:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="T8pRIir/"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="LuKZCLEk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 936122173B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MtfkUW9QoqDDR4UMjkEGIT6K8i0/3TNijxkxknp8xMw=; b=T8pRIir/ryIkBN Z/Baxh1+plHFxZlBkoCKK2FeAuM59WLMOl1+2HSBVy018TX9SaQahzmqXIUcltb38cD4/366l80HW Cnuu7S8fnlEqz3amErHfDPMktQZ86ZNPV9yNLclc/nLN+lUzhkF7FewtDnWU/PkRia0m6TV1J0drW kG1FoJrHk711Cnm6O+s7wZ8c2vF2UURbX7DWfyyP+jt9tB7aPsDZ4U7rbZM+c7fMkwelZlOui5YKw E4pevOEI5JGf6bbkh/5QyUoAKF0BM9uqfj+oiRLkoTUXSnkyD6ByoYNSp/4epnshxKAeV3W2/6Mmo Nt5sYMHpTkiqqq6LfOgg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHT1h-000071-PJ; Mon, 07 Oct 2019 13:26:13 +0000 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHT1f-00005z-Kk for linux-arm-kernel@lists.infradead.org; Mon, 07 Oct 2019 13:26:12 +0000 Received: by mail-ed1-x544.google.com with SMTP id r16so12369043edq.11 for ; Mon, 07 Oct 2019 06:26:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=gzC3+Ai/BcUPGOo2+frzMx33cRF/lu4IW7bk4buzvfY=; b=LuKZCLEks+pxri1fZImZ8aWZNoPyA0k53cdFVsuHb5MDqAN5knWAMDy0wPUsgUxBCF gQcbOYCIkTqaNbsMxo5RKNjpP0d8lQMy7pguGPtgJSh9DP3B9YIN2mS8bmQvpx9hwj+h f1Slcuf8Kzh1JBnKhidomUrXDTUHxpZKdm+qSnztmiyYersQcoVvJ/ohhpzjG+T7kfj/ les5EAK/LmmoySH+aJWZ1XdWfqQwdMTB2W4ogQ6nBwrh8QCxg6VIpsZnYghJaIlVBMwA tZPwZXA0ICwRWfFHd+u/u3DYHya4aQ5yYd1iqfinaPiyxKvPuAJePigymhWXfsmqSyff W1oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=gzC3+Ai/BcUPGOo2+frzMx33cRF/lu4IW7bk4buzvfY=; b=I8z6pTaVFr1wzi8685CTlj/H7bhScEzcrm2UamYnRzZAv/HsPdHpyBsaZ15FGaciUP wIz3GqfsKRicNBVEotCc4eygVwA04wmEGsNYYK1P2SmwuMovpmk2EmsL6esjGeHwB0yO YmggHjGfic8TCwCU3SLdotDKSYQoccWZ8xVoU6pnruYV868fDXz46Mhf5nBLX1H56nMW jFmDfbGgJuLua43NicAkCEvckZqyGZIlGAYuc2Fq0ZAR9arGhthKg5f53qPfC3s5YpQ3 9uUab4d19Koo06zbGyGIIkYnjJVo5vL0yqqXESPaJg+oHP4Tma9WlsRjz7DN5BXO+Yd8 /AGQ== X-Gm-Message-State: APjAAAUoERwp2yQxN418pmXW4yI9GSDVrsyBUHJuctmjqsziqAiCThem P+6tYirnGhn5ovD0QIF7kWx5rQfbZjrq3Q== X-Google-Smtp-Source: APXvYqzElnCPZjbODoQl3J/SFOw2KfpCAczFpMms9cACkFS6giHuVTdY1dFFe29OUP7N4OGq9tG9dw== X-Received: by 2002:a05:6402:7c1:: with SMTP id u1mr29121094edy.198.1570454769090; Mon, 07 Oct 2019 06:26:09 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id t30sm3414834edt.91.2019.10.07.06.26.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Oct 2019 06:26:08 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 4DF0F10027F; Mon, 7 Oct 2019 16:26:07 +0300 (+03) Date: Mon, 7 Oct 2019 16:26:07 +0300 From: "Kirill A. Shutemov" To: Ingo Molnar Subject: Re: [PATCH V4 2/2] mm/pgtable/debug: Add test validating architecture page table helpers Message-ID: <20191007132607.4q537nauwfn5thol@box> References: <1570427124-21887-1-git-send-email-anshuman.khandual@arm.com> <1570427124-21887-3-git-send-email-anshuman.khandual@arm.com> <20191007130617.GB56546@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191007130617.GB56546@gmail.com> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191007_062611_733332_B648E213 X-CRM114-Status: GOOD ( 19.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , James Hogan , Tetsuo Handa , Heiko Carstens , Michal Hocko , linux-mm@kvack.org, Paul Mackerras , sparclinux@vger.kernel.org, Thomas Gleixner , linux-s390@vger.kernel.org, Michael Ellerman , x86@kernel.org, Russell King - ARM Linux , Matthew Wilcox , Steven Price , Jason Gunthorpe , Gerald Schaefer , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Kees Cook , Anshuman Khandual , Masahiro Yamada , Mark Brown , Dan Williams , Vlastimil Babka , Christophe Leroy , Sri Krishna chowdary , Ard Biesheuvel , Greg Kroah-Hartman , Dave Hansen , linux-mips@vger.kernel.org, Ralf Baechle , linux-kernel@vger.kernel.org, Paul Burton , Mike Rapoport , Vineet Gupta , Martin Schwidefsky , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 07, 2019 at 03:06:17PM +0200, Ingo Molnar wrote: > > * Anshuman Khandual wrote: > > > This adds a test module which will validate architecture page table helpers > > and accessors regarding compliance with generic MM semantics expectations. > > This will help various architectures in validating changes to the existing > > page table helpers or addition of new ones. > > > > Test page table and memory pages creating it's entries at various level are > > all allocated from system memory with required alignments. If memory pages > > with required size and alignment could not be allocated, then all depending > > individual tests are skipped. > > > diff --git a/arch/x86/include/asm/pgtable_64_types.h b/arch/x86/include/asm/pgtable_64_types.h > > index 52e5f5f2240d..b882792a3999 100644 > > --- a/arch/x86/include/asm/pgtable_64_types.h > > +++ b/arch/x86/include/asm/pgtable_64_types.h > > @@ -40,6 +40,8 @@ static inline bool pgtable_l5_enabled(void) > > #define pgtable_l5_enabled() 0 > > #endif /* CONFIG_X86_5LEVEL */ > > > > +#define mm_p4d_folded(mm) (!pgtable_l5_enabled()) > > + > > extern unsigned int pgdir_shift; > > extern unsigned int ptrs_per_p4d; > > Any deep reason this has to be a macro instead of proper C? It's a way to override the generic mm_p4d_folded(). It can be rewritten as inline function + define. Something like: #define mm_p4d_folded mm_p4d_folded static inline bool mm_p4d_folded(struct mm_struct *mm) { return !pgtable_l5_enabled(); } But I don't see much reason to be more verbose here than needed. -- Kirill A. Shutemov _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel