* [LTP] [PATCH] Update dynamic_debug grep check
@ 2019-10-04 18:44 rasibley
2019-10-07 14:03 ` Cyril Hrubis
0 siblings, 1 reply; 3+ messages in thread
From: rasibley @ 2019-10-04 18:44 UTC (permalink / raw)
To: ltp
If running on debug kernel this check will fail on EDAC DEBUG messages,
update grep to ignore such cases like this.
---
testcases/kernel/tracing/dynamic_debug/dynamic_debug01.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testcases/kernel/tracing/dynamic_debug/dynamic_debug01.sh b/testcases/kernel/tracing/dynamic_debug/dynamic_debug01.sh
index f39d67d0a..7f06c2488 100755
--- a/testcases/kernel/tracing/dynamic_debug/dynamic_debug01.sh
+++ b/testcases/kernel/tracing/dynamic_debug/dynamic_debug01.sh
@@ -127,7 +127,7 @@ ddebug_test()
sed -i -e 1,`wc -l < ./dmesg.old`d ./dmesg.new
if grep -q -e "Kernel panic" -e "Oops" -e "general protection fault" \
-e "general protection handler: wrong gs" -e "\(XEN\) Panic" \
- -e "fault" -e "warn" -e "BUG" ./dmesg.new ; then
+ -e "fault" -e "warn" -e "\<BUG\>" ./dmesg.new ; then
tst_res TFAIL "Issues found in dmesg!"
else
tst_res TPASS "Dynamic debug OK"
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [LTP] [PATCH] Update dynamic_debug grep check
2019-10-04 18:44 [LTP] [PATCH] Update dynamic_debug grep check rasibley
@ 2019-10-07 14:03 ` Cyril Hrubis
2019-10-07 19:19 ` Jan Stancek
0 siblings, 1 reply; 3+ messages in thread
From: Cyril Hrubis @ 2019-10-07 14:03 UTC (permalink / raw)
To: ltp
Hi!
> If running on debug kernel this check will fail on EDAC DEBUG messages,
> update grep to ignore such cases like this.
You are missing the Signed-off-by: line here, see:
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#developer-s-certificate-of-origin-1-1
Otherwise the patch is Ok.
> ---
> testcases/kernel/tracing/dynamic_debug/dynamic_debug01.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/testcases/kernel/tracing/dynamic_debug/dynamic_debug01.sh b/testcases/kernel/tracing/dynamic_debug/dynamic_debug01.sh
> index f39d67d0a..7f06c2488 100755
> --- a/testcases/kernel/tracing/dynamic_debug/dynamic_debug01.sh
> +++ b/testcases/kernel/tracing/dynamic_debug/dynamic_debug01.sh
> @@ -127,7 +127,7 @@ ddebug_test()
> sed -i -e 1,`wc -l < ./dmesg.old`d ./dmesg.new
> if grep -q -e "Kernel panic" -e "Oops" -e "general protection fault" \
> -e "general protection handler: wrong gs" -e "\(XEN\) Panic" \
> - -e "fault" -e "warn" -e "BUG" ./dmesg.new ; then
> + -e "fault" -e "warn" -e "\<BUG\>" ./dmesg.new ; then
> tst_res TFAIL "Issues found in dmesg!"
> else
> tst_res TPASS "Dynamic debug OK"
> --
> 2.20.1
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 3+ messages in thread
* [LTP] [PATCH] Update dynamic_debug grep check
2019-10-07 14:03 ` Cyril Hrubis
@ 2019-10-07 19:19 ` Jan Stancek
0 siblings, 0 replies; 3+ messages in thread
From: Jan Stancek @ 2019-10-07 19:19 UTC (permalink / raw)
To: ltp
----- Original Message -----
> From: "Cyril Hrubis" <chrubis@suse.cz>
> To: "rasibley" <rasibley@redhat.com>
> Cc: ltp@lists.linux.it
> Sent: Monday, 7 October, 2019 4:03:21 PM
> Subject: Re: [LTP] [PATCH] Update dynamic_debug grep check
>
> Hi!
> > If running on debug kernel this check will fail on EDAC DEBUG messages,
> > update grep to ignore such cases like this.
>
> You are missing the Signed-off-by: line here, see:
>
> https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#developer-s-certificate-of-origin-1-1
You can also use kernel scripts/checkpatch.pl.
>
> Otherwise the patch is Ok.
Pushed with added Signed-off-by and tweaked commit message.
Thanks,
Jan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-07 19:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-04 18:44 [LTP] [PATCH] Update dynamic_debug grep check rasibley
2019-10-07 14:03 ` Cyril Hrubis
2019-10-07 19:19 ` Jan Stancek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.