[MPTCP] Re: [GIT] move TCP-related commits to the beginning

[Florian Westphal <fw at strlen.de>]

[-- Attachment #1: Type: text/plain, Size: 1337 bytes --]

Matthieu Baerts <matthieu.baerts(a)tessares.net> wrote:
> > ... this turns 'tcp: clean ext on tx recycle' into a one-line change.
> 
> Good idea! Just applied this diff and added your signed-off to the patch.

Thanks!

> > If we place this early in the series, then
> > 
> > > 966eb30045b9 mptcp: increment MIB counters in a few places
> > 
> > ... could be folded into the patches that add those code paths.
> > 
> > Perhaps right after 'mptcp: Add MPTCP socket stubs'?
> > 
> > Could also be squashed, I do not mind.  Just a suggestion.
> 
> For me it is clearer to have dedicated patches for the introduction of the
> MIBs: it might help reviewers to easily point out "strategic places" or
> because spending less time on that because it only modifies MPTCP code :)

Right, we can do this as a followup so it doesn't influence the initial
batch sizes in any way.

In light of this I agree its better to keep it as-is.

> It is just that I guess the reviewers will not like having too big patches
> neither. I understand that 40 patches is too big but as a reviewer, I would
> prefer having a very few more patches and split per features / refactoring.

Same here.

> I mean: if we send the same modifications in less patches, I don't know if
> it will help reviewers.

Right.  Lets keep it separate.