From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (193.142.43.55:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 07 Oct 2019 17:53:57 -0000 Received: from mga06.intel.com ([134.134.136.31]) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1iHXCl-0001XX-Ad for speck@linutronix.de; Mon, 07 Oct 2019 19:53:56 +0200 Date: Mon, 7 Oct 2019 10:48:06 -0700 From: Pawan Gupta Subject: [MODERATED] Re: [PATCH v5 02/11] TAAv5 2 Message-ID: <20191007174806.GA5154@guptapadev.amr> References: <20191005105415.GA25756@zn.tnic> MIME-Version: 1.0 In-Reply-To: <20191005105415.GA25756@zn.tnic> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: > > +static void __init cpu_set_bug_bits(struct cpuinfo_x86 *c) > ^^^^^^ > > Please audit your newly added functions whether they can be __init > too. Newly added tsx functions are called after boot as well, either from sysfs or from the cpu hotplug path. I will see if some of them (mostly tsx_init()) can be changed to be __init. One likely call site for tsx_init() is identify_boot_cpu(), and then only do tsx_enable()/disable() from init_intel(). Thanks, Pawan