From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matt Roper <matthew.d.roper@intel.com>
Subject: Re: [PATCH 05/24] drm/i915: Use intel_plane_state in
 prepare and cleanup plane_fb
Date: Mon, 7 Oct 2019 12:37:41 -0700
Message-ID: <20191007193741.GJ6810@mdroper-desk1.amr.corp.intel.com>
References: <20191004113514.17064-1-maarten.lankhorst@linux.intel.com>
 <20191004113514.17064-6-maarten.lankhorst@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 388626E198
 for <intel-gfx@lists.freedesktop.org>; Mon,  7 Oct 2019 19:37:17 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20191004113514.17064-6-maarten.lankhorst@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBPY3QgMDQsIDIwMTkgYXQgMDE6MzQ6NTVQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y
c3Qgd3JvdGU6Cj4gV2UgbmVlZCB0byBsb29rIGF0IHRoZSBodyBmYiBpbiB0aGUgcGxhbmUgc3Bs
aXQsIHNvIHJlcGxhY2UgYWxsIHRoZSBwbGFjZXMKPiB0aGF0IHVzZSBkcm1fcGxhbmVfc3RhdGUg
d2l0aCBpbnRlbF9wbGFuZV9zdGF0ZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmto
b3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJz
L2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rpc3BsYXkuYyB8IDI4ICsrKysrKysrKysrLS0t
LS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMo
LSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9k
aXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rpc3BsYXkuYwo+
IGluZGV4IDllMzRiZTQ4Yzc3MC4uYjVlZDA5N2Q2YTU5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAtMTQzODAsMTIgKzE0MzgwLDE0
IEBAIHN0YXRpYyB2b2lkIGZiX29ial9idW1wX3JlbmRlcl9wcmlvcml0eShzdHJ1Y3QgZHJtX2k5
MTVfZ2VtX29iamVjdCAqb2JqKQo+ICAgKi8KPiAgaW50Cj4gIGludGVsX3ByZXBhcmVfcGxhbmVf
ZmIoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gLQkJICAgICAgIHN0cnVjdCBkcm1fcGxhbmVf
c3RhdGUgKm5ld19zdGF0ZSkKPiArCQkgICAgICAgc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqX25l
d19wbGFuZV9zdGF0ZSkKPiAgewo+ICsJc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpuZXdfcGxh
bmVfc3RhdGUgPQo+ICsJCXRvX2ludGVsX3BsYW5lX3N0YXRlKF9uZXdfcGxhbmVfc3RhdGUpOwo+
ICAJc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqaW50ZWxfc3RhdGUgPQo+IC0JCXRvX2ludGVs
X2F0b21pY19zdGF0ZShuZXdfc3RhdGUtPnN0YXRlKTsKPiArCQl0b19pbnRlbF9hdG9taWNfc3Rh
dGUobmV3X3BsYW5lX3N0YXRlLT5iYXNlLnN0YXRlKTsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2
YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUocGxhbmUtPmRldik7Cj4gLQlzdHJ1Y3QgZHJtX2ZyYW1l
YnVmZmVyICpmYiA9IG5ld19zdGF0ZS0+ZmI7Cj4gKwlzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpm
YiA9IG5ld19wbGFuZV9zdGF0ZS0+YmFzZS5mYjsKPiAgCXN0cnVjdCBkcm1faTkxNV9nZW1fb2Jq
ZWN0ICpvYmogPSBpbnRlbF9mYl9vYmooZmIpOwo+ICAJc3RydWN0IGRybV9pOTE1X2dlbV9vYmpl
Y3QgKm9sZF9vYmogPSBpbnRlbF9mYl9vYmoocGxhbmUtPnN0YXRlLT5mYik7Cj4gIAlpbnQgcmV0
Owo+IEBAIC0xNDQxNiw5ICsxNDQxOCw5IEBAIGludGVsX3ByZXBhcmVfcGxhbmVfZmIoc3RydWN0
IGRybV9wbGFuZSAqcGxhbmUsCj4gIAkJfQo+ICAJfQo+ICAKPiAtCWlmIChuZXdfc3RhdGUtPmZl
bmNlKSB7IC8qIGV4cGxpY2l0IGZlbmNpbmcgKi8KPiArCWlmIChuZXdfcGxhbmVfc3RhdGUtPmJh
c2UuZmVuY2UpIHsgLyogZXhwbGljaXQgZmVuY2luZyAqLwo+ICAJCXJldCA9IGk5MTVfc3dfZmVu
Y2VfYXdhaXRfZG1hX2ZlbmNlKCZpbnRlbF9zdGF0ZS0+Y29tbWl0X3JlYWR5LAo+IC0JCQkJCQkg
ICAgbmV3X3N0YXRlLT5mZW5jZSwKPiArCQkJCQkJICAgIG5ld19wbGFuZV9zdGF0ZS0+YmFzZS5m
ZW5jZSwKPiAgCQkJCQkJICAgIEk5MTVfRkVOQ0VfVElNRU9VVCwKPiAgCQkJCQkJICAgIEdGUF9L
RVJORUwpOwo+ICAJCWlmIChyZXQgPCAwKQo+IEBAIC0xNDQzOCw3ICsxNDQ0MCw3IEBAIGludGVs
X3ByZXBhcmVfcGxhbmVfZmIoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gIAkJcmV0dXJuIHJl
dDsKPiAgCX0KPiAgCj4gLQlyZXQgPSBpbnRlbF9wbGFuZV9waW5fZmIodG9faW50ZWxfcGxhbmVf
c3RhdGUobmV3X3N0YXRlKSk7Cj4gKwlyZXQgPSBpbnRlbF9wbGFuZV9waW5fZmIobmV3X3BsYW5l
X3N0YXRlKTsKPiAgCj4gIAltdXRleF91bmxvY2soJmRldl9wcml2LT5kcm0uc3RydWN0X211dGV4
KTsKPiAgCWk5MTVfZ2VtX29iamVjdF91bnBpbl9wYWdlcyhvYmopOwo+IEBAIC0xNDQ0OCw3ICsx
NDQ1MCw3IEBAIGludGVsX3ByZXBhcmVfcGxhbmVfZmIoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUs
Cj4gIAlmYl9vYmpfYnVtcF9yZW5kZXJfcHJpb3JpdHkob2JqKTsKPiAgCWludGVsX2Zyb250YnVm
ZmVyX2ZsdXNoKG9iai0+ZnJvbnRidWZmZXIsIE9SSUdJTl9ESVJUWUZCKTsKPiAgCj4gLQlpZiAo
IW5ld19zdGF0ZS0+ZmVuY2UpIHsgLyogaW1wbGljaXQgZmVuY2luZyAqLwo+ICsJaWYgKCFuZXdf
cGxhbmVfc3RhdGUtPmJhc2UuZmVuY2UpIHsgLyogaW1wbGljaXQgZmVuY2luZyAqLwo+ICAJCXN0
cnVjdCBkbWFfZmVuY2UgKmZlbmNlOwo+ICAKPiAgCQlyZXQgPSBpOTE1X3N3X2ZlbmNlX2F3YWl0
X3Jlc2VydmF0aW9uKCZpbnRlbF9zdGF0ZS0+Y29tbWl0X3JlYWR5LAo+IEBAIC0xNDQ2MCwxMSAr
MTQ0NjIsMTEgQEAgaW50ZWxfcHJlcGFyZV9wbGFuZV9mYihzdHJ1Y3QgZHJtX3BsYW5lICpwbGFu
ZSwKPiAgCj4gIAkJZmVuY2UgPSBkbWFfcmVzdl9nZXRfZXhjbF9yY3Uob2JqLT5iYXNlLnJlc3Yp
Owo+ICAJCWlmIChmZW5jZSkgewo+IC0JCQlhZGRfcnBzX2Jvb3N0X2FmdGVyX3ZibGFuayhuZXdf
c3RhdGUtPmNydGMsIGZlbmNlKTsKPiArCQkJYWRkX3Jwc19ib29zdF9hZnRlcl92YmxhbmsobmV3
X3BsYW5lX3N0YXRlLT5iYXNlLmNydGMsIGZlbmNlKTsKPiAgCQkJZG1hX2ZlbmNlX3B1dChmZW5j
ZSk7Cj4gIAkJfQo+ICAJfSBlbHNlIHsKPiAtCQlhZGRfcnBzX2Jvb3N0X2FmdGVyX3ZibGFuayhu
ZXdfc3RhdGUtPmNydGMsIG5ld19zdGF0ZS0+ZmVuY2UpOwo+ICsJCWFkZF9ycHNfYm9vc3RfYWZ0
ZXJfdmJsYW5rKG5ld19wbGFuZV9zdGF0ZS0+YmFzZS5jcnRjLCBuZXdfcGxhbmVfc3RhdGUtPmJh
c2UuZmVuY2UpOwoKVGhlIHR3byBjaGFuZ2VzIGluIHRoaXMgaHVuayByZXF1aXJlIGxpbmUgd3Jh
cHMgbm93IHRvIHN0YXkgPDgwIGNoYXJzLgoKT3RoZXJ3aXNlLApSZXZpZXdlZC1ieTogTWF0dCBS
b3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4KCj4gIAl9Cj4gIAo+ICAJLyoKPiBAQCAt
MTQ0OTQsMTAgKzE0NDk2LDEyIEBAIGludGVsX3ByZXBhcmVfcGxhbmVfZmIoc3RydWN0IGRybV9w
bGFuZSAqcGxhbmUsCj4gICAqLwo+ICB2b2lkCj4gIGludGVsX2NsZWFudXBfcGxhbmVfZmIoc3Ry
dWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gLQkJICAgICAgIHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUg
Km9sZF9zdGF0ZSkKPiArCQkgICAgICAgc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqX29sZF9wbGFu
ZV9zdGF0ZSkKPiAgewo+ICsJc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpvbGRfcGxhbmVfc3Rh
dGUgPQo+ICsJCXRvX2ludGVsX3BsYW5lX3N0YXRlKF9vbGRfcGxhbmVfc3RhdGUpOwo+ICAJc3Ry
dWN0IGludGVsX2F0b21pY19zdGF0ZSAqaW50ZWxfc3RhdGUgPQo+IC0JCXRvX2ludGVsX2F0b21p
Y19zdGF0ZShvbGRfc3RhdGUtPnN0YXRlKTsKPiArCQl0b19pbnRlbF9hdG9taWNfc3RhdGUob2xk
X3BsYW5lX3N0YXRlLT5iYXNlLnN0YXRlKTsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk
ZXZfcHJpdiA9IHRvX2k5MTUocGxhbmUtPmRldik7Cj4gIAo+ICAJaWYgKGludGVsX3N0YXRlLT5y
cHNfaW50ZXJhY3RpdmUpIHsKPiBAQCAtMTQ1MDcsNyArMTQ1MTEsNyBAQCBpbnRlbF9jbGVhbnVw
X3BsYW5lX2ZiKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ICAKPiAgCS8qIFNob3VsZCBvbmx5
IGJlIGNhbGxlZCBhZnRlciBhIHN1Y2Nlc3NmdWwgaW50ZWxfcHJlcGFyZV9wbGFuZV9mYigpISAq
Lwo+ICAJbXV0ZXhfbG9jaygmZGV2X3ByaXYtPmRybS5zdHJ1Y3RfbXV0ZXgpOwo+IC0JaW50ZWxf
cGxhbmVfdW5waW5fZmIodG9faW50ZWxfcGxhbmVfc3RhdGUob2xkX3N0YXRlKSk7Cj4gKwlpbnRl
bF9wbGFuZV91bnBpbl9mYihvbGRfcGxhbmVfc3RhdGUpOwo+ICAJbXV0ZXhfdW5sb2NrKCZkZXZf
cHJpdi0+ZHJtLnN0cnVjdF9tdXRleCk7Cj4gIH0KPiAgCj4gLS0gCj4gMi4yMy4wCj4gCj4gX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZngg
bWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8v
bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKTWF0
dCBSb3BlcgpHcmFwaGljcyBTb2Z0d2FyZSBFbmdpbmVlcgpWVFQtT1NHQyBQbGF0Zm9ybSBFbmFi
bGVtZW50CkludGVsIENvcnBvcmF0aW9uCig5MTYpIDM1Ni0yNzk1Cl9fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50
ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y
Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==