All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi@etezian.org>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Andi Shyti <andi@etezian.org>,
	Simon Shields <simon@lineageos.org>,
	linux-input@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] Input: mms114 - add support for mms345l
Date: Tue, 8 Oct 2019 14:35:11 +0300	[thread overview]
Message-ID: <20191008113511.GA4015@jack.zhora.eu> (raw)
In-Reply-To: <20191007205021.104402-1-stephan@gerhold.net>

Hi Stephan,

On Mon, Oct 07, 2019 at 10:50:21PM +0200, Stephan Gerhold wrote:
> MMS345L is another first generation touch screen from Melfas,
> which uses the same registers as MMS152.
> 
> However, using I2C_M_NOSTART for it causes errors when reading:
> 
> 	i2c i2c-0: sendbytes: NAK bailout.
> 	mms114 0-0048: __mms114_read_reg: i2c transfer failed (-5)
> 
> The driver works fine as soon as I2C_M_NOSTART is removed.
> 
> Add a separate melfas,mms345l binding, and make use of I2C_M_NOSTART
> only for MMS114 and MMS152.
> 
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>

Reviewed-by: Andi Shyti <andi@etezian.org>

just a nitpick in case you will resend it (but you don't need
to).

> -	if (!i2c_check_functionality(client->adapter,
> -				I2C_FUNC_PROTOCOL_MANGLING)) {
> +	type = (enum mms_type)device_get_match_data(&client->dev);

you don't need any cast here.

Thanks,
Andi

  reply	other threads:[~2019-10-08 11:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 20:33 [PATCH 0/3] Add support for Melfas MMS345L touchscreen Stephan Gerhold
2019-10-07 20:33 ` [PATCH 1/3] Input: mms114 - use device_get_match_data Stephan Gerhold
2019-10-08 11:44   ` Andi Shyti
2019-10-08 21:54     ` Dmitry Torokhov
2019-10-07 20:33 ` [PATCH 2/3] dt-bindings: mms114: document melfas,mms345l binding Stephan Gerhold
2019-10-08 11:45   ` Andi Shyti
2019-10-15 22:21   ` Rob Herring
2019-10-07 20:50 ` [PATCH 3/3] Input: mms114 - add support for mms345l Stephan Gerhold
2019-10-08 11:35   ` Andi Shyti [this message]
2019-10-08 11:44     ` Andi Shyti
2019-10-08 22:00   ` Dmitry Torokhov
2019-10-09  7:26     ` Andi Shyti
2019-10-09 20:40       ` Dmitry Torokhov
2019-10-13 21:39         ` Andi Shyti
2019-10-09 10:47     ` Stephan Gerhold
2019-10-13 21:04       ` Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191008113511.GA4015@jack.zhora.eu \
    --to=andi@etezian.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=simon@lineageos.org \
    --cc=stephan@gerhold.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.