Re: [PATCH v22 12/24] x86/sgx: Linux Enclave Driver

From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	linux-kernel@vger.kernel.org, x86@kernel.org,
	linux-sgx@vger.kernel.org, akpm@linux-foundation.org,
	dave.hansen@intel.com, nhorman@redhat.com, npmccallum@redhat.com,
	serge.ayoun@intel.com, shay.katz-zamir@intel.com,
	haitao.huang@intel.com, andriy.shevchenko@linux.intel.com,
	tglx@linutronix.de, kai.svahn@intel.com, josh@joshtriplett.org,
	luto@kernel.org, kai.huang@intel.com, rientjes@google.com,
	cedric.xing@intel.com, Suresh Siddha <suresh.b.siddha@intel.com>
Subject: Re: [PATCH v22 12/24] x86/sgx: Linux Enclave Driver
Date: Tue, 8 Oct 2019 11:17:52 -0700	[thread overview]
Message-ID: <20191008181752.GE14020@linux.intel.com> (raw)
In-Reply-To: <20191008175924.GN14765@zn.tnic>

On Tue, Oct 08, 2019 at 07:59:24PM +0200, Borislav Petkov wrote:
> > diff --git a/arch/x86/include/uapi/asm/sgx.h b/arch/x86/include/uapi/asm/sgx.h
> > new file mode 100644
> > index 000000000000..c45eeed68144
> > --- /dev/null
> > +++ b/arch/x86/include/uapi/asm/sgx.h
> > @@ -0,0 +1,55 @@
> > +/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) WITH Linux-syscall-note */
> 
> checkpatch is bitching for some reason, I guess it doesn't like the
> "WITH" thing or so:
> 
> WARNING: 'SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) WITH Linux-syscall-note */' is not supported in LICENSES/...
> #98: FILE: arch/x86/include/uapi/asm/sgx.h:1:
> +/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) WITH Linux-syscall-note */
> 
> WARNING: 'SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause WITH Linux-syscall-note */' is not supported in LICENSES/...
> #159: FILE: arch/x86/include/uapi/asm/sgx_errno.h:1:
> +/* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause WITH Linux-syscall-note */
> 
> And building this fails:
> 
> arch/x86/kernel/cpu/sgx/encl.c: In function ‘sgx_mmu_notifier_release’:
> arch/x86/kernel/cpu/sgx/encl.c:77:3: error: implicit declaration of function ‘mmu_notifier_unregister_no_release’; did you mean ‘mmu_notifier_unregister’? [-Werror=implicit-function-declaration]
>    mmu_notifier_unregister_no_release(mn, mm);
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    mmu_notifier_unregister
> arch/x86/kernel/cpu/sgx/encl.c:78:3: error: implicit declaration of function ‘mmu_notifier_call_srcu’; did you mean ‘mmu_notifier_release’? [-Werror=implicit-function-declaration]
>    mmu_notifier_call_srcu(&encl_mm->rcu,
>    ^~~~~~~~~~~~~~~~~~~~~~
>    mmu_notifier_release
> cc1: some warnings being treated as errors
> make[4]: *** [scripts/Makefile.build:265: arch/x86/kernel/cpu/sgx/encl.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> make[3]: *** [scripts/Makefile.build:509: arch/x86/kernel/cpu/sgx] Error 2
> make[2]: *** [scripts/Makefile.build:509: arch/x86/kernel/cpu] Error 2
> make[1]: *** [scripts/Makefile.build:509: arch/x86/kernel] Error 2
> make: *** [Makefile:1670: arch/x86] Error 2
> make: *** Waiting for unfinished jobs....
> 
> Got a fixed version which I can review instead?

The build error is due to mmu notifier changes that are going into 5.4,
whereas I believe this is based on 5.3.

Jarkko has rebased to 5.4-rc1 and addressed the mmu notifier issue, but I
don't know exact status of his branch.  I'd prefer not to send you a borked
patch.

There are already a handful of driver changes on our todo list for v23, as
well as the vDSO and selftest updates.  What if you stop here for now and
restart when Jarkko sends v23?  In theory that'll happen later this week.