From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: [PATCH 02/10] drm/i915/execlists: Leave tell-tales as to why pending[] is bad Date: Thu, 10 Oct 2019 08:14:26 +0100 Message-ID: <20191010071434.31195-2-chris@chris-wilson.co.uk> References: <20191010071434.31195-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4938B6EAAB for ; Thu, 10 Oct 2019 07:14:49 +0000 (UTC) In-Reply-To: <20191010071434.31195-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org QmVmb3JlIHdlIEJVRyBvdXQgd2l0aCBiYWQgcGVuZGluZyBzdGF0ZSwgbGVhdmUgYSB0ZWxsdGFs ZSBhcyB0byB3aGljaAp0ZXN0IGZhaWxlZC4KClNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8 Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgpDYzogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFs YUBsaW51eC5pbnRlbC5jb20+CkNjOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50 ZWwuY29tPgotLS0KIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX2xyYy5jIHwgMzAgKysr KysrKysrKysrKysrKysrKysrKysrLS0tLS0KIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt LmggICAgIHwgIDggKysrKy0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMjkgaW5zZXJ0aW9ucygrKSwg OSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRl bF9scmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX2xyYy5jCmluZGV4IGEwNzc3 YjNhZDY4YS4uNTA0MGZiZGQ4MWFmIDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9n dC9pbnRlbF9scmMuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9scmMuYwpA QCAtMTEzOCwyNSArMTEzOCw0NSBAQCBhc3NlcnRfcGVuZGluZ192YWxpZChjb25zdCBzdHJ1Y3Qg aW50ZWxfZW5naW5lX2V4ZWNsaXN0cyAqZXhlY2xpc3RzLAogCiAJdHJhY2VfcG9ydHMoZXhlY2xp c3RzLCBtc2csIGV4ZWNsaXN0cy0+cGVuZGluZyk7CiAKLQlpZiAoIWV4ZWNsaXN0cy0+cGVuZGlu Z1swXSkKKwlpZiAoIWV4ZWNsaXN0cy0+cGVuZGluZ1swXSkgeworCQlHRU1fVFJBQ0VfRVJSKCJO b3RoaW5nIHBlbmRpbmcgZm9yIHByb21vdGlvbiFcbiIpOwogCQlyZXR1cm4gZmFsc2U7CisJfQog Ci0JaWYgKGV4ZWNsaXN0cy0+cGVuZGluZ1tleGVjbGlzdHNfbnVtX3BvcnRzKGV4ZWNsaXN0cyld KQorCWlmIChleGVjbGlzdHMtPnBlbmRpbmdbZXhlY2xpc3RzX251bV9wb3J0cyhleGVjbGlzdHMp XSkgeworCQlHRU1fVFJBQ0VfRVJSKCJFeGNlc3MgcGVuZGluZ1slZF0gZm9yIHByb21vdGlvbiFc biIsCisJCQkgICAgICBleGVjbGlzdHNfbnVtX3BvcnRzKGV4ZWNsaXN0cykpOwogCQlyZXR1cm4g ZmFsc2U7CisJfQogCiAJZm9yIChwb3J0ID0gZXhlY2xpc3RzLT5wZW5kaW5nOyAocnEgPSAqcG9y dCk7IHBvcnQrKykgewotCQlpZiAoY2UgPT0gcnEtPmh3X2NvbnRleHQpCisJCWlmIChjZSA9PSBy cS0+aHdfY29udGV4dCkgeworCQkJR0VNX1RSQUNFX0VSUigiRHVwbGljYXRlIGNvbnRleHQgaW4g cGVuZGluZ1slemRdXG4iLAorCQkJCSAgICAgIHBvcnQgLSBleGVjbGlzdHMtPnBlbmRpbmcpOwog CQkJcmV0dXJuIGZhbHNlOworCQl9CiAKIAkJY2UgPSBycS0+aHdfY29udGV4dDsKIAkJaWYgKGk5 MTVfcmVxdWVzdF9jb21wbGV0ZWQocnEpKQogCQkJY29udGludWU7CiAKLQkJaWYgKGk5MTVfYWN0 aXZlX2lzX2lkbGUoJmNlLT5hY3RpdmUpKQorCQlpZiAoaTkxNV9hY3RpdmVfaXNfaWRsZSgmY2Ut PmFjdGl2ZSkpIHsKKwkJCUdFTV9UUkFDRV9FUlIoIkluYWN0aXZlIGNvbnRleHQgaW4gcGVuZGlu Z1slemRdXG4iLAorCQkJCSAgICAgIHBvcnQgLSBleGVjbGlzdHMtPnBlbmRpbmcpOworCQkJcmV0 dXJuIGZhbHNlOworCQl9CisKKwkJaWYgKCFpOTE1X3ZtYV9pc19waW5uZWQoY2UtPnN0YXRlKSkg eworCQkJR0VNX1RSQUNFX0VSUigiVW5waW5uZWQgY29udGV4dCBpbiBwZW5kaW5nWyV6ZF1cbiIs CisJCQkJICAgICAgcG9ydCAtIGV4ZWNsaXN0cy0+cGVuZGluZyk7CiAJCQlyZXR1cm4gZmFsc2U7 CisJCX0KIAotCQlpZiAoIWk5MTVfdm1hX2lzX3Bpbm5lZChjZS0+c3RhdGUpKQorCQlpZiAoIWk5 MTVfdm1hX2lzX3Bpbm5lZChjZS0+cmluZy0+dm1hKSkgeworCQkJR0VNX1RSQUNFX0VSUigiVW5w aW5uZWQgcmluZ2J1ZmZlciBpbiBwZW5kaW5nWyV6ZF1cbiIsCisJCQkJICAgICAgcG9ydCAtIGV4 ZWNsaXN0cy0+cGVuZGluZyk7CiAJCQlyZXR1cm4gZmFsc2U7CisJCX0KIAl9CiAKIAlyZXR1cm4g Y2U7CmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5oIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uaAppbmRleCA2Nzk1ZjFkYWEzZDUuLjYzZGFiMzc2NTEw NiAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uaAorKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5oCkBAIC0zNywxMCArMzcsOCBAQCBzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZTsKICNkZWZpbmUgR0VNX1NIT1dfREVCVUcoKSAoZHJtX2RlYnVnICYgRFJN X1VUX0RSSVZFUikKIAogI2RlZmluZSBHRU1fQlVHX09OKGNvbmRpdGlvbikgZG8geyBpZiAodW5s aWtlbHkoKGNvbmRpdGlvbikpKSB7CVwKLQkJcHJfZXJyKCIlczolZCBHRU1fQlVHX09OKCVzKVxu IiwgXAotCQkgICAgICAgX19mdW5jX18sIF9fTElORV9fLCBfX3N0cmluZ2lmeShjb25kaXRpb24p KTsgXAotCQlHRU1fVFJBQ0UoIiVzOiVkIEdFTV9CVUdfT04oJXMpXG4iLCBcCi0JCQkgIF9fZnVu Y19fLCBfX0xJTkVfXywgX19zdHJpbmdpZnkoY29uZGl0aW9uKSk7IFwKKwkJR0VNX1RSQUNFX0VS UigiJXM6JWQgR0VNX0JVR19PTiglcylcbiIsIFwKKwkJCSAgICAgIF9fZnVuY19fLCBfX0xJTkVf XywgX19zdHJpbmdpZnkoY29uZGl0aW9uKSk7IFwKIAkJQlVHKCk7IFwKIAkJfSBcCiAJfSB3aGls ZSgwKQpAQCAtNjYsMTEgKzY0LDEzIEBAIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlOwogCiAjaWYg SVNfRU5BQkxFRChDT05GSUdfRFJNX0k5MTVfVFJBQ0VfR0VNKQogI2RlZmluZSBHRU1fVFJBQ0Uo Li4uKSB0cmFjZV9wcmludGsoX19WQV9BUkdTX18pCisjZGVmaW5lIEdFTV9UUkFDRV9FUlIoLi4u KSBkbyB7IHByX2VycihfX1ZBX0FSR1NfXyk7IHRyYWNlX3ByaW50ayhfX1ZBX0FSR1NfXyk7IH0g d2hpbGUgKDApCiAjZGVmaW5lIEdFTV9UUkFDRV9EVU1QKCkgZnRyYWNlX2R1bXAoRFVNUF9BTEwp CiAjZGVmaW5lIEdFTV9UUkFDRV9EVU1QX09OKGV4cHIpIFwKIAlkbyB7IGlmIChleHByKSBmdHJh Y2VfZHVtcChEVU1QX0FMTCk7IH0gd2hpbGUgKDApCiAjZWxzZQogI2RlZmluZSBHRU1fVFJBQ0Uo Li4uKSBkbyB7IH0gd2hpbGUgKDApCisjZGVmaW5lIEdFTV9UUkFDRV9FUlIoLi4uKSBkbyB7IH0g d2hpbGUgKDApCiAjZGVmaW5lIEdFTV9UUkFDRV9EVU1QKCkgZG8geyB9IHdoaWxlICgwKQogI2Rl ZmluZSBHRU1fVFJBQ0VfRFVNUF9PTihleHByKSBCVUlMRF9CVUdfT05fSU5WQUxJRChleHByKQog I2VuZGlmCi0tIAoyLjIzLjAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeA==