From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 354EFC4360C for ; Thu, 10 Oct 2019 07:05:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0DCB92190F for ; Thu, 10 Oct 2019 07:05:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733018AbfJJHF3 (ORCPT ); Thu, 10 Oct 2019 03:05:29 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:44174 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727296AbfJJHF2 (ORCPT ); Thu, 10 Oct 2019 03:05:28 -0400 Received: from dhcp-172-31-174-146.wireless.concordia.ca (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 2988E28E582; Thu, 10 Oct 2019 08:05:27 +0100 (BST) Date: Thu, 10 Oct 2019 09:05:24 +0200 From: Boris Brezillon To: Cc: , , , , , linux-aspeed@lists.ozlabs.org, andrew@aj.id.au, richard@nod.at, linux-kernel@vger.kernel.org, vz@mleia.com, linux-mediatek@lists.infradead.org, joel@jms.id.au, miquel.raynal@bootlin.com, matthias.bgg@gmail.com, computersforpeace@gmail.com, dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 04/22] mtd: spi-nor: Rename nor->params to nor->flash Message-ID: <20191010090524.6de7e746@dhcp-172-31-174-146.wireless.concordia.ca> In-Reply-To: <20190924074533.6618-5-tudor.ambarus@microchip.com> References: <20190924074533.6618-1-tudor.ambarus@microchip.com> <20190924074533.6618-5-tudor.ambarus@microchip.com> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Sep 2019 07:46:03 +0000 wrote: > From: Tudor Ambarus > > Rename nor->params to nor->flash for a clearer separation > between the controller and flash operations. Hm, I'm not sure 'flash' is clearer than 'params', and the spi_nor object is supposed to represent the NOR chip anyway, so it was pretty clear to me that nor->params were the NOR flash parameters not the NOR controller ones. If I had anything to change it would be s/params/properties/ (and s/spi_nor_flash_parameter/spi_nor_properties/) since those parameters look like immutable information discovered during the NOR detection, but I'm nitpicking here. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58769C10F14 for ; Thu, 10 Oct 2019 07:05:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBC5D2190F for ; Thu, 10 Oct 2019 07:05:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fYeoPX5X" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBC5D2190F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HcOr0zQ6B2yF4M/NghZUP/pFw+vpnQvgKcsyyiYNRNo=; b=fYeoPX5XSM3WBH x09+9BVRJ1dWuqJP2cyuvaYmw+nIuweb3Ibz3fuk0peCkXuzP+Fy/drZaMfWa7eWacdQJPx8pluLE DUPzAirwqH9TTaVUNbEd5w7fZ5K2Q6KxAR4OqYXM53NVI3cj/EjAY9LRFEK4q97H371v5LQiMNpqO dWlJXUmcgt+pQs0H8rLoryRiNKZIxe01FTHUb7EqXQN3qdX84i8x7EJNYq++sfSKJUd1zyaC45cn8 bcOuPef/I9yJ7RVtzeacVia7lyLV0ZCKLTEdxTUzlTRKWLmAXqRObNBtB1lI9ajpfoMS63F2Hje1z WhtLUE5YycFyzOAD9zEA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iISW3-0007NQ-Sg; Thu, 10 Oct 2019 07:05:39 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iISVt-0007DU-19; Thu, 10 Oct 2019 07:05:32 +0000 Received: from dhcp-172-31-174-146.wireless.concordia.ca (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 2988E28E582; Thu, 10 Oct 2019 08:05:27 +0100 (BST) Date: Thu, 10 Oct 2019 09:05:24 +0200 From: Boris Brezillon To: Subject: Re: [PATCH v2 04/22] mtd: spi-nor: Rename nor->params to nor->flash Message-ID: <20191010090524.6de7e746@dhcp-172-31-174-146.wireless.concordia.ca> In-Reply-To: <20190924074533.6618-5-tudor.ambarus@microchip.com> References: <20190924074533.6618-1-tudor.ambarus@microchip.com> <20190924074533.6618-5-tudor.ambarus@microchip.com> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191010_000530_884935_6AABC741 X-CRM114-Status: GOOD ( 10.75 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, vigneshr@ti.com, geert+renesas@glider.be, andrew@aj.id.au, richard@nod.at, linux-kernel@vger.kernel.org, vz@mleia.com, marek.vasut@gmail.com, jonas@norrbonn.se, linux-mtd@lists.infradead.org, joel@jms.id.au, miquel.raynal@bootlin.com, matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org, computersforpeace@gmail.com, dwmw2@infradead.org, linux-aspeed@lists.ozlabs.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Tue, 24 Sep 2019 07:46:03 +0000 wrote: > From: Tudor Ambarus > > Rename nor->params to nor->flash for a clearer separation > between the controller and flash operations. Hm, I'm not sure 'flash' is clearer than 'params', and the spi_nor object is supposed to represent the NOR chip anyway, so it was pretty clear to me that nor->params were the NOR flash parameters not the NOR controller ones. If I had anything to change it would be s/params/properties/ (and s/spi_nor_flash_parameter/spi_nor_properties/) since those parameters look like immutable information discovered during the NOR detection, but I'm nitpicking here. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v2 04/22] mtd: spi-nor: Rename nor->params to nor->flash Date: Thu, 10 Oct 2019 09:05:24 +0200 Message-ID: <20191010090524.6de7e746@dhcp-172-31-174-146.wireless.concordia.ca> References: <20190924074533.6618-1-tudor.ambarus@microchip.com> <20190924074533.6618-5-tudor.ambarus@microchip.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190924074533.6618-5-tudor.ambarus@microchip.com> Sender: linux-kernel-owner@vger.kernel.org To: Tudor.Ambarus@microchip.com Cc: vigneshr@ti.com, marek.vasut@gmail.com, linux-mtd@lists.infradead.org, geert+renesas@glider.be, jonas@norrbonn.se, linux-aspeed@lists.ozlabs.org, andrew@aj.id.au, richard@nod.at, linux-kernel@vger.kernel.org, vz@mleia.com, linux-mediatek@lists.infradead.org, joel@jms.id.au, miquel.raynal@bootlin.com, matthias.bgg@gmail.com, computersforpeace@gmail.com, dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org On Tue, 24 Sep 2019 07:46:03 +0000 wrote: > From: Tudor Ambarus > > Rename nor->params to nor->flash for a clearer separation > between the controller and flash operations. Hm, I'm not sure 'flash' is clearer than 'params', and the spi_nor object is supposed to represent the NOR chip anyway, so it was pretty clear to me that nor->params were the NOR flash parameters not the NOR controller ones. If I had anything to change it would be s/params/properties/ (and s/spi_nor_flash_parameter/spi_nor_properties/) since those parameters look like immutable information discovered during the NOR detection, but I'm nitpicking here. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDFE0C4360C for ; Thu, 10 Oct 2019 07:05:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85E612190F for ; Thu, 10 Oct 2019 07:05:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="n9puxalT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85E612190F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1qUPKrtM6iaQ5KzxtaZDNv0Hgcs21vroLt6BDKbkpx0=; b=n9puxalTP78V5Z 1OetroPhiBbl47bPlseHIpYpeUUPNptD21BxHu6emQKi0Amux23NJBayUF3LKSP6BRw2c+CxWUIJP 8j7fMj7QBt5jEAEPcV5E+1JSzupfORk3RxzRPHn8AKnRfGfzILSBV/lgsTM+PFlLiWp968PXWhGF+ 0aCJxinV3rPfYnoQBuQP2RSK8ba9O4J4/dpQ2RSjS/pizSDD4kLB7EJ+ZUUZ405+WeL1zrldFKGAD 2sVFUFg6QfQi7p3i2/KGgqYOCtWIM+G3jOydUsd/kH1nTUfJPOnS+P9fws1ZL2QNN6gG8kpSra7TB G8F97IxGPR7d1Gs0S9Ow==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iISVx-0007EX-9c; Thu, 10 Oct 2019 07:05:33 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iISVt-0007DU-19; Thu, 10 Oct 2019 07:05:32 +0000 Received: from dhcp-172-31-174-146.wireless.concordia.ca (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 2988E28E582; Thu, 10 Oct 2019 08:05:27 +0100 (BST) Date: Thu, 10 Oct 2019 09:05:24 +0200 From: Boris Brezillon To: Subject: Re: [PATCH v2 04/22] mtd: spi-nor: Rename nor->params to nor->flash Message-ID: <20191010090524.6de7e746@dhcp-172-31-174-146.wireless.concordia.ca> In-Reply-To: <20190924074533.6618-5-tudor.ambarus@microchip.com> References: <20190924074533.6618-1-tudor.ambarus@microchip.com> <20190924074533.6618-5-tudor.ambarus@microchip.com> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191010_000530_884935_6AABC741 X-CRM114-Status: GOOD ( 10.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, vigneshr@ti.com, geert+renesas@glider.be, andrew@aj.id.au, richard@nod.at, linux-kernel@vger.kernel.org, vz@mleia.com, marek.vasut@gmail.com, jonas@norrbonn.se, linux-mtd@lists.infradead.org, joel@jms.id.au, miquel.raynal@bootlin.com, matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org, computersforpeace@gmail.com, dwmw2@infradead.org, linux-aspeed@lists.ozlabs.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 24 Sep 2019 07:46:03 +0000 wrote: > From: Tudor Ambarus > > Rename nor->params to nor->flash for a clearer separation > between the controller and flash operations. Hm, I'm not sure 'flash' is clearer than 'params', and the spi_nor object is supposed to represent the NOR chip anyway, so it was pretty clear to me that nor->params were the NOR flash parameters not the NOR controller ones. If I had anything to change it would be s/params/properties/ (and s/spi_nor_flash_parameter/spi_nor_properties/) since those parameters look like immutable information discovered during the NOR detection, but I'm nitpicking here. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel