From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 08/24] drm/i915: Prepare to split crtc state in uapi and hw state Date: Thu, 10 Oct 2019 17:47:00 +0300 Message-ID: <20191010144700.GG1208@intel.com> References: <20191004113514.17064-1-maarten.lankhorst@linux.intel.com> <20191004113514.17064-9-maarten.lankhorst@linux.intel.com> <20191008170643.GT1208@intel.com> <2f46b9c3-f354-1ebf-98dc-e9e401dd7420@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id D5DBF6E373 for ; Thu, 10 Oct 2019 14:47:04 +0000 (UTC) Content-Disposition: inline In-Reply-To: <2f46b9c3-f354-1ebf-98dc-e9e401dd7420@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMTAsIDIwMTkgYXQgMDQ6MjE6MDBQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMDgtMTAtMjAxOSBvbSAxOTowNiBzY2hyZWVmIFZpbGxlIFN5cmrDpGzD pDoKPiA+IE9uIEZyaSwgT2N0IDA0LCAyMDE5IGF0IDAxOjM0OjU4UE0gKzAyMDAsIE1hYXJ0ZW4g TGFua2hvcnN0IHdyb3RlOgo+ID4+IFdlIHdhbnQgdG8gc3BsaXQgZHJtX2NydGNfc3RhdGUgaW50 byB0aGUgdXNlciB2aXNpYmxlIHN0YXRlCj4gPj4gYW5kIGFjdHVhbCBoYXJkd2FyZSBzdGF0ZS4g VG8gcHJlcGFyZSBmb3IgdGhpcywgd2UgbmVlZCBzb21lCj4gPj4gZ3JvdW5kIHJ1bGVzIHdoYXQg c2hvdWxkIGJlIGluIGVhY2ggc3RhdGU6Cj4gPj4KPiA+PiBJbiB1YXBpIHdlIHVzZToKPiA+PiAt IGNydGMsICpfY2hhbmdlZCBmbGFncywgZXZlbnQsIGNvbW1pdCwgc3RhdGUsIG1vZGVfYmxvYiwK PiA+PiAgIChwbGFuZS9jb25uZWN0b3IvZW5jb2RlcilfbWFzay4KPiA+Pgo+ID4+IEluIGh3IHN0 YXRlIHdlIHVzZSB3aGF0J3MgZGlzcGxheWVkIGluIGhhcmR3YXJlOgo+ID4+IC0gZW5hYmxlLCBh Y3RpdmUsIChhZGp1c3RlZCkgbW9kZSwgY29sb3IgcHJvcGVydHkgYmxvYnMuCj4gPj4KPiA+PiBj bGVhcl9pbnRlbF9jcnRjX3N0YXRlIGFuZCBodyByZWFkb3V0IG5lZWQgdG8gYmUgdXBkYXRlZCBm b3IgdGhlc2UgcnVsZXMsCj4gPj4gd2hpY2ggd2lsbCBhbGxvdyB1cyB0byBlbmFibGUgMiBqb2lu ZWQgcGlwZXMuCj4gPiBJIHN0aWxsIGhhdmUgaGFyZCB0aW1lIHdpdGggcmVhZGluZyB0aGlzIHBh dGNoLiBJIHN0aWxsIHRoaW5rIGl0Cj4gPiB3b3VsZCBiZSBlYXNpZXIgdG8gcmVhZCBpZiB3ZSBk aWRuJ3QgZG8gYm90aCB0aGUgInVhcGkiIGFuZCAiaHciIGNoYW5nZXMKPiA+IGF0IHRoZSBzYW1l IHRpbWUuCj4gPgo+ID4gc3RlcCAxLgo+ID4gCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSB1YXBpOwo+ ID4gCXN0cnVjdCB7Cj4gPiAJCS8vIGh3IHN0YXRlCj4gPiAJfSBiYXNlOwo+ID4KPiA+IHN0ZXAg Mi4gCj4gPiAJcy9iYXNlL2h3Lwo+ID4KPiA+IEkgdGhpbmsgdGhhdCB3b3VsZCBtYWtlIGl0IG1v cmUgb2J2aW91cyB3aGljaCBwYXJ0cyBvZiB0aGUgY29kZSBhcmUKPiA+IGxvb2tpbmcgYXQgd2hp Y2ggc3RhdGUuCj4gCj4gSXQgd291bGRuJ3QgSSB0aGluaywgYnV0IGhlcmUncwo+IGEgZHVtYiBj aGFuZ2Ugd2l0aCBzcGF0Y2ggb24gdGhpcyBwYXRjaC4KPiAKPiAvLysgICAgICAgc3RydWN0IHsK PiAvLysgICAgICAgICAgICAgICBib29sIGFjdGl2ZSwgZW5hYmxlOwo+IC8vKyAgICAgICAgICAg ICAgIHN0cnVjdCBkcm1fcHJvcGVydHlfYmxvYiAqZGVnYW1tYV9sdXQsICpnYW1tYV9sdXQsICpj dG07Cj4gLy8rICAgICAgICAgICAgICAgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgbW9kZSwgYWRq dXN0ZWRfbW9kZTsKPiAvLysgICAgICAgfSBodzsKPiAKPiBAQAo+IHN0cnVjdCBpbnRlbF9jcnRj X3N0YXRlICpUOwo+IEBACj4gLVQtPnVhcGkuYWN0aXZlCj4gK1QtPmh3LmFjdGl2ZQoKVGhpcyBk b2Vzbid0IHJlYWxseSBoZWxwIG1lLiBUaGVyZSBpcyBubyAudWFwaSBpbiB1cHN0cmVhbQpjb2Rl LiBJIHdvdWxkIGxpa2UgdG8gc2VlIGp1c3QgdGhlIC5iYXNlLT4udWFwaSBjaGFuZ2VzCmFsb25l IGZpcnN0IHNvIEkgY2FuIHJldmlldyB3aGljaCBwYXJ0cyBzdGFydCB0byBsb29rIGF0CnRoZSB1 YXBpIHN0YXRlIHRvIG1ha2Ugc3VyZSB3ZSBhcmVuJ3QgY2hhbmdpbmcgdG9vIG11Y2guClRoZW4g SSdkIGxpa2UgdG8gdG8gc2VlIHRoZSAuYmFzZS0+Lmh3IGNoYW5nZXMgc28gdGhhdCBJCmNvbnZp bmNlIG15c2VsZiB3ZSBkaWRuJ3QgbWlzcyBhbnl0aGluZyBpbiB0aGUgLmJhc2UtPi51YXBpCmNv bnZlcnNpb24uCgpBbmQgYWxsIHRoZSByZW1haW5pbmcgZHJtX2NydGNfc3RhdGUgdXNhZ2UgaXMg Z29pbmcgdG8KbWFrZSB1cyBtaXNzIHNvbWV0aGluZyBmb3Igc3VyZSwgc28gZ2V0dGluZyByaWQg b2YgYWxsIHRoYXQKZmlyc3Qgd291bGQgcHJvYmFibHkgaGVscC4KCj4gCj4gQEAKPiBzdHJ1Y3Qg aW50ZWxfY3J0Y19zdGF0ZSAqVDsKPiBAQAo+IC1ULT51YXBpLmVuYWJsZQo+ICtULT5ody5lbmFi bGUKPiAKPiBAQAo+IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpUOwo+IEBACj4gLVQtPnVhcGku ZGVnYW1tYV9sdXQKPiArVC0+aHcuZGVnYW1tYV9sdXQKPiAKPiAKPiBAQAo+IHN0cnVjdCBpbnRl bF9jcnRjX3N0YXRlICpUOwo+IEBACj4gLVQtPnVhcGkuZ2FtbWFfbHV0Cj4gK1QtPmh3LmdhbW1h X2x1dAo+IAo+IEBACj4gc3RydWN0IGludGVsX2NydGNfc3RhdGUgKlQ7Cj4gQEAKPiAtVC0+dWFw aS5jdG0KPiArVC0+aHcuY3RtCj4gCj4gQEAKPiBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqVDsK PiBAQAo+IC1ULT51YXBpLm1vZGUKPiArVC0+aHcubW9kZQo+IAo+IEBACj4gc3RydWN0IGludGVs X2NydGNfc3RhdGUgKlQ7Cj4gQEAKPiAtVC0+dWFwaS5hZGp1c3RlZF9tb2RlCj4gK1QtPmh3LmFk anVzdGVkX21vZGUKPiAKPiBJIHJlcGxhY2VkIGFsbCB0aGUgaW5zdGFuY2VzIHdoZXJlIHdlIHVz ZSB0aGUgdWFwaSBtZW1iZXJzIGluc3RlYWQgb2YgdGhlIGh3IG1lbWJlcnMgZXhwbGljaXRseSBp biB0aGlzIHBhdGNoLCBhbmQgY2FtZSB1cCB3aXRoIHRoZSBmb2xsb3dpbmcgZGlmZiBiZWxvdy4K PiAKPiBPbmx5IHRoZSBpbnRlbF9jb2xvciByZWFkb3V0IGlzIHBvdGVudGlhbGx5IGluY29ycmVj dCwgdGhlIDIgZXhwbGljaXQgdWFwaSB1c2VzIGluIGludGVsX2Rpc3BsYXkuYyBhcmUgbmVlZGVk Lgo+IERpZG4ndCBmaXggaXQgYmVjYXVzZSBvZiBodyByZWFkb3V0LCBpdCBwb3NzaWJseSBuZWVk cyBzbGlnaHRseSBtb3JlIHRob3VnaHQuCj4gCj4gRG9lcyB0aGlzIHNhdGlzZnkgdGhlIHJlYWRh YmlsaXR5IHJlcXVpcmVtZW50cz8gOikKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvZGlzcGxheS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNw bGF5L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IGFiMTBjMzMyNjZiZi4uY2JmNGM2ZTZlNjYxIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheS5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kaXNwbGF5LmMKPiBA QCAtMTEyMTcsNyArMTEyMTcsNyBAQCBpbnQgaW50ZWxfZ2V0X2xvYWRfZGV0ZWN0X3BpcGUoc3Ry dWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiAgCQlnb3RvIGZhaWw7Cj4gIAl9Cj4gIAo+ IC0JY3J0Y19zdGF0ZS0+dWFwaS5hY3RpdmUgPSBjcnRjX3N0YXRlLT51YXBpLmVuYWJsZSA9IHRy dWU7Cj4gKwljcnRjX3N0YXRlLT5ody5hY3RpdmUgPSBjcnRjX3N0YXRlLT5ody5lbmFibGUgPSB0 cnVlOwo+ICAKPiAgCWlmICghbW9kZSkKPiAgCQltb2RlID0gJmxvYWRfZGV0ZWN0X21vZGU7Cj4g QEAgLTEzNTc4LDcgKzEzNTc4LDcgQEAgc3RhdGljIGludCBpbnRlbF9hdG9taWNfY2hlY2soc3Ry dWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCQlpZiAoIW5lZWRzX21vZGVzZXQobmV3X2NydGNfc3Rh dGUpKQo+ICAJCQljb250aW51ZTsKPiAgCj4gLQkJaWYgKCFuZXdfY3J0Y19zdGF0ZS0+dWFwaS5l bmFibGUpIHsKPiArCQlpZiAoIW5ld19jcnRjX3N0YXRlLT5ody5lbmFibGUpIHsKPiAgCQkJYW55 X21zID0gdHJ1ZTsKPiAgCQkJY29udGludWU7Cj4gIAkJfQo+IAo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2NvbG9yLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9kaXNwbGF5L2ludGVsX2NvbG9yLmMKPiBpbmRleCA1NTg2ODkxNTcyZjguLjUyNzEyYmI5 ZWQxNSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Nv bG9yLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2NvbG9yLmMK PiBAQCAtMTYyMyw3ICsxNjIzLDcgQEAgc3RhdGljIHZvaWQgaTl4eF9yZWFkX2x1dHMoc3RydWN0 IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gIAlpZiAoIWNydGNfc3RhdGUtPmdhbW1h X2VuYWJsZSkKPiAgCQlyZXR1cm47Cj4gIAo+IC0JY3J0Y19zdGF0ZS0+dWFwaS5nYW1tYV9sdXQg PSBpOXh4X3JlYWRfbHV0XzgoY3J0Y19zdGF0ZSk7Cj4gKwljcnRjX3N0YXRlLT5ody5nYW1tYV9s dXQgPSBpOXh4X3JlYWRfbHV0XzgoY3J0Y19zdGF0ZSk7Cj4gIH0KPiAgCj4gIHN0YXRpYyBzdHJ1 Y3QgZHJtX3Byb3BlcnR5X2Jsb2IgKgo+IEBAIC0xNjczLDkgKzE2NzMsOSBAQCBzdGF0aWMgdm9p ZCBpOTY1X3JlYWRfbHV0cyhzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSkKPiAg CQlyZXR1cm47Cj4gIAo+ICAJaWYgKGNydGNfc3RhdGUtPmdhbW1hX21vZGUgPT0gR0FNTUFfTU9E RV9NT0RFXzhCSVQpCj4gLQkJY3J0Y19zdGF0ZS0+dWFwaS5nYW1tYV9sdXQgPSBpOXh4X3JlYWRf bHV0XzgoY3J0Y19zdGF0ZSk7Cj4gKwkJY3J0Y19zdGF0ZS0+aHcuZ2FtbWFfbHV0ID0gaTl4eF9y ZWFkX2x1dF84KGNydGNfc3RhdGUpOwo+ICAJZWxzZQo+IC0JCWNydGNfc3RhdGUtPnVhcGkuZ2Ft bWFfbHV0ID0gaTk2NV9yZWFkX2x1dF8xMHA2KGNydGNfc3RhdGUpOwo+ICsJCWNydGNfc3RhdGUt Pmh3LmdhbW1hX2x1dCA9IGk5NjVfcmVhZF9sdXRfMTBwNihjcnRjX3N0YXRlKTsKPiAgfQo+ICAK PiAgc3RhdGljIHN0cnVjdCBkcm1fcHJvcGVydHlfYmxvYiAqCj4gQEAgLTE3MTUsNyArMTcxNSw3 IEBAIGNodl9yZWFkX2NnbV9sdXQoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNf c3RhdGUpCj4gIHN0YXRpYyB2b2lkIGNodl9yZWFkX2x1dHMoc3RydWN0IGludGVsX2NydGNfc3Rh dGUgKmNydGNfc3RhdGUpCj4gIHsKPiAgCWlmIChjcnRjX3N0YXRlLT5jZ21fbW9kZSAmIENHTV9Q SVBFX01PREVfR0FNTUEpCj4gLQkJY3J0Y19zdGF0ZS0+dWFwaS5nYW1tYV9sdXQgPSBjaHZfcmVh ZF9jZ21fbHV0KGNydGNfc3RhdGUpOwo+ICsJCWNydGNfc3RhdGUtPmh3LmdhbW1hX2x1dCA9IGNo dl9yZWFkX2NnbV9sdXQoY3J0Y19zdGF0ZSk7Cj4gIAllbHNlCj4gIAkJaTk2NV9yZWFkX2x1dHMo Y3J0Y19zdGF0ZSk7Cj4gIH0KPiBAQCAtMTc2Miw5ICsxNzYyLDkgQEAgc3RhdGljIHZvaWQgaWxr X3JlYWRfbHV0cyhzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSkKPiAgCQlyZXR1 cm47Cj4gIAo+ICAJaWYgKGNydGNfc3RhdGUtPmdhbW1hX21vZGUgPT0gR0FNTUFfTU9ERV9NT0RF XzhCSVQpCj4gLQkJY3J0Y19zdGF0ZS0+dWFwaS5nYW1tYV9sdXQgPSBpOXh4X3JlYWRfbHV0Xzgo Y3J0Y19zdGF0ZSk7Cj4gKwkJY3J0Y19zdGF0ZS0+aHcuZ2FtbWFfbHV0ID0gaTl4eF9yZWFkX2x1 dF84KGNydGNfc3RhdGUpOwo+ICAJZWxzZQo+IC0JCWNydGNfc3RhdGUtPnVhcGkuZ2FtbWFfbHV0 ID0gaWxrX3JlYWRfbHV0XzEwKGNydGNfc3RhdGUpOwo+ICsJCWNydGNfc3RhdGUtPmh3LmdhbW1h X2x1dCA9IGlsa19yZWFkX2x1dF8xMChjcnRjX3N0YXRlKTsKPiAgfQo+ICAKPiAgc3RhdGljIHN0 cnVjdCBkcm1fcHJvcGVydHlfYmxvYiAqCj4gQEAgLTE4MTEsOSArMTgxMSw5IEBAIHN0YXRpYyB2 b2lkIGdsa19yZWFkX2x1dHMoc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4g IAkJcmV0dXJuOwo+ICAKPiAgCWlmIChjcnRjX3N0YXRlLT5nYW1tYV9tb2RlID09IEdBTU1BX01P REVfTU9ERV84QklUKQo+IC0JCWNydGNfc3RhdGUtPnVhcGkuZ2FtbWFfbHV0ID0gaTl4eF9yZWFk X2x1dF84KGNydGNfc3RhdGUpOwo+ICsJCWNydGNfc3RhdGUtPmh3LmdhbW1hX2x1dCA9IGk5eHhf cmVhZF9sdXRfOChjcnRjX3N0YXRlKTsKPiAgCWVsc2UKPiAtCQljcnRjX3N0YXRlLT51YXBpLmdh bW1hX2x1dCA9IGdsa19yZWFkX2x1dF8xMChjcnRjX3N0YXRlLCBQQUxfUFJFQ19JTkRFWF9WQUxV RSgwKSk7Cj4gKwkJY3J0Y19zdGF0ZS0+aHcuZ2FtbWFfbHV0ID0gZ2xrX3JlYWRfbHV0XzEwKGNy dGNfc3RhdGUsIFBBTF9QUkVDX0lOREVYX1ZBTFVFKDApKTsKPiAgfQo+ICAKPiAgdm9pZCBpbnRl bF9jb2xvcl9pbml0KHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQoKLS0gClZpbGxlIFN5cmrDpGzD pApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=