From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0783CECE58C for ; Fri, 11 Oct 2019 06:02:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D58AA21D6C for ; Fri, 11 Oct 2019 06:02:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570773755; bh=SBBREUJ7L4LRecn4Q41c/ojYzyaMc2/TOgFSVd6X3/Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=S0O195cj5mlUEFZ9hMmJK0hCZzH8NvvwiVa6BHX8qH1YUC4nsV84s6Q/gy9MGhuEN rlJ7J96EyTv8fiuLDhqjYL3ajY7dbkRr+NxNHuscM+RZYmtQp4zgQfmWytwNajgkzR 6J/UoS+jS1bGXhsj4aSYAhl0rvtdyzkGRD1r12ho= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726635AbfJKGCf (ORCPT ); Fri, 11 Oct 2019 02:02:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:46826 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726287AbfJKGCf (ORCPT ); Fri, 11 Oct 2019 02:02:35 -0400 Received: from sol.localdomain (c-24-5-143-220.hsd1.ca.comcast.net [24.5.143.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3356720659; Fri, 11 Oct 2019 06:02:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570773754; bh=SBBREUJ7L4LRecn4Q41c/ojYzyaMc2/TOgFSVd6X3/Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pRQOnDNSP30Axs6yAHvEH7daP10TLudVuIVeczYBefQVu+1+vv8tvbMePmyxHJpHq TDvfFsWWLgf1Komw/hCSujEbmczfeZeArfb3lLeUs3dW2RRYxsn6SsqY4V7cidlfN8 DPheEEXw1KDFR6xVM7ebGFdBNYNlrWPH3LRTq0Sk= Date: Thu, 10 Oct 2019 23:02:32 -0700 From: Eric Biggers To: Ard Biesheuvel Cc: linux-crypto@vger.kernel.org, Herbert Xu , David Miller , "Jason A . Donenfeld" , Samuel Neves , Arnd Bergmann , Andy Lutomirski , Martin Willi , Rene van Dorst Subject: Re: [PATCH v3 21/29] crypto: BLAKE2s - generic C library implementation and selftest Message-ID: <20191011060232.GB23882@sol.localdomain> Mail-Followup-To: Ard Biesheuvel , linux-crypto@vger.kernel.org, Herbert Xu , David Miller , "Jason A . Donenfeld" , Samuel Neves , Arnd Bergmann , Andy Lutomirski , Martin Willi , Rene van Dorst References: <20191007164610.6881-1-ard.biesheuvel@linaro.org> <20191007164610.6881-22-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191007164610.6881-22-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Oct 07, 2019 at 06:46:02PM +0200, Ard Biesheuvel wrote: > From: "Jason A. Donenfeld" > > The C implementation was originally based on Samuel Neves' public > domain reference implementation but has since been heavily modified > for the kernel. We're able to do compile-time optimizations by moving > some scaffolding around the final function into the header file. > > Information: https://blake2.net/ > > Signed-off-by: Jason A. Donenfeld > Signed-off-by: Samuel Neves > Co-developed-by: Samuel Neves > [ardb: move from lib/zinc to lib/crypto and remove simd handling] > Signed-off-by: Ard Biesheuvel FYI, I had left a few review comments on Jason's last version of this patch (https://lkml.kernel.org/linux-crypto/20190326173759.GA607@zzz.localdomain/), some of which Jason addressed in the Wireguard repository (https://git.zx2c4.com/WireGuard) but they didn't make it into this patch. I'd suggest taking a look at the version there. - Eric