From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14197ECE597 for ; Fri, 11 Oct 2019 08:20:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DFDC221E6F for ; Fri, 11 Oct 2019 08:20:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SmkwSbfv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727453AbfJKIUL (ORCPT ); Fri, 11 Oct 2019 04:20:11 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:37897 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727411AbfJKIUL (ORCPT ); Fri, 11 Oct 2019 04:20:11 -0400 Received: by mail-wr1-f65.google.com with SMTP id y18so1363059wrn.5; Fri, 11 Oct 2019 01:20:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=iY3VbFT46lw+lo2paBwupDTtrpw99cdmsvZfo9TjTQU=; b=SmkwSbfvxqDKQwKKDk5EWy2klDAogSzP3rzKKTLnMiF9wnXzUJgSCUH6AGsYpLNWDL NrVQTzA7aYIwU9/oHM0YuzVdhp+A0xWxAZ4rWMiX8BEljjJNkqBgZRbVUS1n12s3IDeS qDXqQzq0xHDLjUR5wWlgTLQjFg9QHl21UKY+muIzQ97ljNKPnMoqhRGw2CfpOUWAH8b0 ZINz6BwjakkMasDWtmhP0hLvFSfBxaPLBsT5TkeOyYwXx4kKvyL4NIYXhyVdoO2KRs5V 3NO4iNVI7saRskIYnZq1n3ucrUNWYSgf2QvLKTJ+kiLmasrP1TcqzDS+64tzJkrrPI9Z KVcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=iY3VbFT46lw+lo2paBwupDTtrpw99cdmsvZfo9TjTQU=; b=rvCJiEVXYDq7r2CrXgYCKChlkKxJrcQ1Bfebt1lmfl74zZGEZMmUEqjW1ooG46wzg3 7D1P+hJH6cs+Pw2VlRjwNQ9iEmjeA/fHX8vWW/at/q262Zjabg/xREWH36e2kt2qrXO+ WAk1KjfnoPl4I0ArU4+aFlVKK4+QVw/nbbzHfUCIVIiHC2e7yy9Gy5t8K2iWECysBDYr hh4UfNbsI2ZsQHmoUAcGsEzmA0FdKESkCe9Gz5IU86hl4G6C1gIq+CLv6zRRP+KW20d4 dkys7xipRFmZQyt9OtDrOqh8CCORaI86jIv8xF1JZTgUedg8cvLQPM1+xmDUwduwQ6Dx Zd/A== X-Gm-Message-State: APjAAAX6BuTvCBM/5LdXa07Sj29wOYN5TElEN2FAV8nakPB2wFy4ExQF QvFQt3TL178+NVtwbyMnhO4= X-Google-Smtp-Source: APXvYqx4BP+NACn/f0HWVAabhBN703zVanaofrdx1aXskPCoLsynKeocseYiViIe4gyYbkJjTss6aw== X-Received: by 2002:adf:f0c8:: with SMTP id x8mr12614050wro.206.1570782009029; Fri, 11 Oct 2019 01:20:09 -0700 (PDT) Received: from Red ([2a01:cb1d:147:7200:2e56:dcff:fed2:c6d6]) by smtp.googlemail.com with ESMTPSA id f3sm7531556wrq.53.2019.10.11.01.20.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Oct 2019 01:20:08 -0700 (PDT) Date: Fri, 11 Oct 2019 10:20:05 +0200 From: Corentin Labbe To: Maxime Ripard Cc: catalin.marinas@arm.com, davem@davemloft.net, herbert@gondor.apana.org.au, linux@armlinux.org.uk, mark.rutland@arm.com, robh+dt@kernel.org, wens@csie.org, will@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v3 02/11] crypto: Add Allwinner sun8i-ce Crypto Engine Message-ID: <20191011082005.GA4641@Red> References: <20191010182328.15826-1-clabbe.montjoie@gmail.com> <20191010182328.15826-3-clabbe.montjoie@gmail.com> <20191011075705.j5bqw2w6jmcrv5dz@gilmour> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191011075705.j5bqw2w6jmcrv5dz@gilmour> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Oct 11, 2019 at 09:57:05AM +0200, Maxime Ripard wrote: > On Thu, Oct 10, 2019 at 08:23:19PM +0200, Corentin Labbe wrote: > > + ce->reset = devm_reset_control_get_optional(&pdev->dev, "bus"); > > + if (IS_ERR(ce->reset)) { > > + if (PTR_ERR(ce->reset) == -EPROBE_DEFER) > > + return PTR_ERR(ce->reset); > > + dev_err(&pdev->dev, "No reset control found\n"); > > + return PTR_ERR(ce->reset); > > + } > > There's only one reset so you don't need that name. > > And I'm not sure why you're using the optional variant, it's required > by your binding. > Hello It will be fixed Regards From mboxrd@z Thu Jan 1 00:00:00 1970 From: Corentin Labbe Subject: Re: [PATCH v3 02/11] crypto: Add Allwinner sun8i-ce Crypto Engine Date: Fri, 11 Oct 2019 10:20:05 +0200 Message-ID: <20191011082005.GA4641@Red> References: <20191010182328.15826-1-clabbe.montjoie@gmail.com> <20191010182328.15826-3-clabbe.montjoie@gmail.com> <20191011075705.j5bqw2w6jmcrv5dz@gilmour> Reply-To: clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20191011075705.j5bqw2w6jmcrv5dz@gilmour> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Maxime Ripard Cc: catalin.marinas-5wv7dgnIgG8@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, will-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, Oct 11, 2019 at 09:57:05AM +0200, Maxime Ripard wrote: > On Thu, Oct 10, 2019 at 08:23:19PM +0200, Corentin Labbe wrote: > > + ce->reset = devm_reset_control_get_optional(&pdev->dev, "bus"); > > + if (IS_ERR(ce->reset)) { > > + if (PTR_ERR(ce->reset) == -EPROBE_DEFER) > > + return PTR_ERR(ce->reset); > > + dev_err(&pdev->dev, "No reset control found\n"); > > + return PTR_ERR(ce->reset); > > + } > > There's only one reset so you don't need that name. > > And I'm not sure why you're using the optional variant, it's required > by your binding. > Hello It will be fixed Regards From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCC2DECE58C for ; Fri, 11 Oct 2019 08:20:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9225721D71 for ; Fri, 11 Oct 2019 08:20:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="B9KLzFWJ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SmkwSbfv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9225721D71 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hk7/NBjghAGQNExUUxVGN1aKj5lMT6FCN9lNP9YSEbw=; b=B9KLzFWJGHqNEx fmQhA6YM5FuhBTg1vTx64KHNo2hQ8pl1DXD9xpGqdDSUxrkEE3HdU/NOCuUY0H10k0l4xuyvqmwNQ PSDK28gD2khiDkTmGmEo4Oa1FqLJBLO2SUnQYC0jihbGpfCUrj/Jnu63QAf9Zr+rgBBCo1GjVFBTf ZG1OPlgRKubHA7vdQjrGuNki/DdWnIHCQMisJ2lsNvDl2FXTL0FWY9x7bpj2ThD3ih/7t3sqj7v8X KwyL+qrY5u6MjGQo8BwufVXnM+JdB8E7BNjvlSHLZ0vd88fLPcuTGvcLPbmQusrR1prBYnBgSyMT5 QnOPzb9vubyZ7MqvmLyg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIq9l-0003DY-PJ; Fri, 11 Oct 2019 08:20:13 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIq9i-0003Bo-DO for linux-arm-kernel@lists.infradead.org; Fri, 11 Oct 2019 08:20:11 +0000 Received: by mail-wr1-x442.google.com with SMTP id j11so10847065wrp.1 for ; Fri, 11 Oct 2019 01:20:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=iY3VbFT46lw+lo2paBwupDTtrpw99cdmsvZfo9TjTQU=; b=SmkwSbfvxqDKQwKKDk5EWy2klDAogSzP3rzKKTLnMiF9wnXzUJgSCUH6AGsYpLNWDL NrVQTzA7aYIwU9/oHM0YuzVdhp+A0xWxAZ4rWMiX8BEljjJNkqBgZRbVUS1n12s3IDeS qDXqQzq0xHDLjUR5wWlgTLQjFg9QHl21UKY+muIzQ97ljNKPnMoqhRGw2CfpOUWAH8b0 ZINz6BwjakkMasDWtmhP0hLvFSfBxaPLBsT5TkeOyYwXx4kKvyL4NIYXhyVdoO2KRs5V 3NO4iNVI7saRskIYnZq1n3ucrUNWYSgf2QvLKTJ+kiLmasrP1TcqzDS+64tzJkrrPI9Z KVcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=iY3VbFT46lw+lo2paBwupDTtrpw99cdmsvZfo9TjTQU=; b=pUJBYPreXSB540KCI/oHp4f1ZADS+WodzVuV1ULaoI+gS/KDfwHRu98C5dWY4z/hV4 RdoeMuFDzLPduvlwG0R1mVaeBZbGTNorZvZRXK6Gh3qUlOlZkwAdPZoDUQqnNgbVuAmP 2Ewd4tUKkfM4a4Fn3SLwCzhFlxAN0u3iaFuGBIee9QQMRk5MC8lB57CDqWd3NaDwqqkc 6eH6/ESYAWAxGzAKIwNV2jguSCZKQETGiBWJ4WA/HAXHu6j6CHxcBoI4TLAVE7my5OmK zHeN1JtpV6yCAf+oBZus65EwMxpQ7SoqYvWXC0pCHXQwelzf3zXykkqL7wlHZ2INNOjN jMZA== X-Gm-Message-State: APjAAAW8bSrypXvG6eEu6ChT4JMQs+ZmaSCPgGczkXxXdPdPBOcBSYfA atKbrN2tDv1mmJdqDNjoccw= X-Google-Smtp-Source: APXvYqx4BP+NACn/f0HWVAabhBN703zVanaofrdx1aXskPCoLsynKeocseYiViIe4gyYbkJjTss6aw== X-Received: by 2002:adf:f0c8:: with SMTP id x8mr12614050wro.206.1570782009029; Fri, 11 Oct 2019 01:20:09 -0700 (PDT) Received: from Red ([2a01:cb1d:147:7200:2e56:dcff:fed2:c6d6]) by smtp.googlemail.com with ESMTPSA id f3sm7531556wrq.53.2019.10.11.01.20.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Oct 2019 01:20:08 -0700 (PDT) Date: Fri, 11 Oct 2019 10:20:05 +0200 From: Corentin Labbe To: Maxime Ripard Subject: Re: [PATCH v3 02/11] crypto: Add Allwinner sun8i-ce Crypto Engine Message-ID: <20191011082005.GA4641@Red> References: <20191010182328.15826-1-clabbe.montjoie@gmail.com> <20191010182328.15826-3-clabbe.montjoie@gmail.com> <20191011075705.j5bqw2w6jmcrv5dz@gilmour> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191011075705.j5bqw2w6jmcrv5dz@gilmour> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191011_012010_476423_228F91F6 X-CRM114-Status: GOOD ( 11.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, herbert@gondor.apana.org.au, catalin.marinas@arm.com, linux-sunxi@googlegroups.com, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, wens@csie.org, robh+dt@kernel.org, linux-crypto@vger.kernel.org, will@kernel.org, davem@davemloft.net, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 11, 2019 at 09:57:05AM +0200, Maxime Ripard wrote: > On Thu, Oct 10, 2019 at 08:23:19PM +0200, Corentin Labbe wrote: > > + ce->reset = devm_reset_control_get_optional(&pdev->dev, "bus"); > > + if (IS_ERR(ce->reset)) { > > + if (PTR_ERR(ce->reset) == -EPROBE_DEFER) > > + return PTR_ERR(ce->reset); > > + dev_err(&pdev->dev, "No reset control found\n"); > > + return PTR_ERR(ce->reset); > > + } > > There's only one reset so you don't need that name. > > And I'm not sure why you're using the optional variant, it's required > by your binding. > Hello It will be fixed Regards _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel