From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6746422022313607168 X-Received: by 2002:adf:82ad:: with SMTP id 42mr11718051wrc.209.1570784399270; Fri, 11 Oct 2019 01:59:59 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 2002:adf:c408:: with SMTP id v8ls2315097wrf.10.gmail; Fri, 11 Oct 2019 01:59:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqzFDL58XWcwCIb8O1By+VWCjmYiXr529yTwUFpYTVDK58Umh2P8+Ho9JI9JFtgFBkzo60K6 X-Received: by 2002:a5d:6a4e:: with SMTP id t14mr12688327wrw.286.1570784398208; Fri, 11 Oct 2019 01:59:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570784398; cv=none; d=google.com; s=arc-20160816; b=uQ49++zmrCoQr71Cewl45OC13nH+2K7BA3+bL4Cczl3T9pi4dlihdLhlEU4yewTRYp ws48ioK+P3HjZR1ZfT6uLgRGpPJQqIxq/n9s6g98vSAA8zsDVCQJ07RrcN6dde2l2MYN IQ6HgMM36V9BzzGJsF02cBf2gj7cBPqF1FPK2Tw7bSMfUK7WSlEy32ZW9HrqgK0tUZQm v3WOlUXof/Cbn8Qyt9zkZ4ZF/ijKYfhxcVAOACn+x+yHH6iBUvRhIX9Pmmothn2BfkOT /TgS57aLMIIHEUG2miHTnK4dNKS5PtPQvTjLB2+VgML87NvUdch4/U/dawoZSEAn4BnK Jp5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:dkim-signature; bh=VxVxglgeL3qKEjfGtgRUEcui49ts/sXRyc9+Ru8EifA=; b=1JiYXwYJRyKXL5LfdWedr3DgXFOYGcAXB1A5E+A18Er/DCqz1XwIprfbBfdeXrKElC TQ2OefrvNHWWvTVc49J/HLlm8uIHKclMmNR9kTKrftS+ldSitR5vBzUwdX3HCNQjcinl TeO39yoY0X2KggThwUhd3ouqJdXReVLr6uQ7C/26Uu5eLtsDxt9lUbQXq0ThPdxZ6ne1 VMcRLdIJtMKzMpOrvPpwtOvyt5p1VXjPWOyIKbIxl18fYY/JwF9CPNAwLK5iwDSTHqY4 4tNPjmeZ1ZhvsChsYx0EYm/fCjvbngExEPXDLKCbIU0qQbL1dO6pop3zbsSTUHkOxYQ/ X3Sw== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZYC3+Ay0; spf=pass (google.com: domain of wambui.karugax@gmail.com designates 2a00:1450:4864:20::442 as permitted sender) smtp.mailfrom=wambui.karugax@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com. [2a00:1450:4864:20::442]) by gmr-mx.google.com with ESMTPS id p5si384667wmg.0.2019.10.11.01.59.58 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Oct 2019 01:59:58 -0700 (PDT) Received-SPF: pass (google.com: domain of wambui.karugax@gmail.com designates 2a00:1450:4864:20::442 as permitted sender) client-ip=2a00:1450:4864:20::442; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZYC3+Ay0; spf=pass (google.com: domain of wambui.karugax@gmail.com designates 2a00:1450:4864:20::442 as permitted sender) smtp.mailfrom=wambui.karugax@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-wr1-x442.google.com with SMTP id h4so10984416wrv.7 for ; Fri, 11 Oct 2019 01:59:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VxVxglgeL3qKEjfGtgRUEcui49ts/sXRyc9+Ru8EifA=; b=ZYC3+Ay0TTFta5z+ySOxT1yy5LpFRPW45F3DLzdLsSnFcssZD5FOIoGQzZIffj9PRE Xp7tSexxRRmFAfnkZnIO/H9xELp4WVgYngxAfGg8CAkMhxaspm/T7nIm0G2TR3GBanTM HqldEpDOP6i/fQq5iP7PdzKUQ73+2B+htlySlLloN30Ckav9CMDVbj8L/1jq8qHlMuEz YSYFbHAkouAl/MqRdWYzltEq+OMpzt0VkOObZO2U4wKuaPGaxKGOQoWrgL6uV88JNJd/ sUUF0JmM2ZIyFw0Yiq/i0uyoqVA3RTqSFnfGEK+4ptYDsw83NTiLM6z1t2Wu9kKgKTSh Y0CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=VxVxglgeL3qKEjfGtgRUEcui49ts/sXRyc9+Ru8EifA=; b=YBmIpijWfzgfrz55hCdhY/BiAl/+BZUXl0pJ3o4j4rwlc/REqjR1Rv/MpchwlLbfX5 11lQ/Au7rTd3zAIU4tN9dyfOfmBh5CKLuOAR/wP4xLOMAPiyjZgxQId/7IfeFAesh0Pv wmkNHKjNCyQnofyOaJPwpmB+yNpDg4S3X2VKZVyxoAivZasv37kexMf3qLnCuUMQr1dB vvjbgJ53r4c/m0tiLzGnavbogy26GzxQ9Ep2SmidJL4116x7BkJQoDYtwExo7BFDpwjy 3V3CYEwuW6p6cAXw1ZafxDRK8o2Fa/Rx5dxRgfcqLWIedtYdjx4C1e2B8aw7e2xXRATA b4kg== X-Gm-Message-State: APjAAAVop8CyvbGQz6NPQagIE0/KlYBin865lCy/9MjR5f54kAlb7QiZ jnbyQtSrVB1f1iflLbfF2wM= X-Received: by 2002:adf:f48c:: with SMTP id l12mr11609168wro.99.1570784397867; Fri, 11 Oct 2019 01:59:57 -0700 (PDT) Return-Path: Received: from wambui ([197.237.61.225]) by smtp.gmail.com with ESMTPSA id b186sm11494222wmd.16.2019.10.11.01.59.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2019 01:59:57 -0700 (PDT) Date: Fri, 11 Oct 2019 11:59:52 +0300 From: Wambui Karuga To: Julia Lawall Cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [Outreachy kernel] [PATCH 1/5] staging: octeon: remove typedef declaration for cvmx_wqe_t Message-ID: <20191011085952.GA9748@wambui> Reply-To: alpine.DEB.2.21.1910110817340.2662@hadrien References: <1b16bc880fee5711f96ed82741f8268e4dac1ae6.1570773209.git.wambui.karugax@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) On Fri, Oct 11, 2019 at 08:18:25AM +0200, Julia Lawall wrote: > > > On Fri, 11 Oct 2019, Wambui Karuga wrote: > > > Remove typedef declaration from struct cvmx_wqe_t in > > You can remove the _t from the name as well. Should I remove the _t from all the enums/structs? > > > drivers/staging/octeon/octeon-stubs.h. > > It's not really necessary to give the name of the file in the log message, > as it can easily be seen below. > > julia > Okay, thought it would be clearer for the commit messages/git log. Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57EEBC47404 for ; Fri, 11 Oct 2019 09:00:04 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C6B021A4A for ; Fri, 11 Oct 2019 09:00:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZYC3+Ay0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C6B021A4A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id ECEDD86D7F; Fri, 11 Oct 2019 09:00:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IprC30cYXSdt; Fri, 11 Oct 2019 09:00:02 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 7550486D27; Fri, 11 Oct 2019 09:00:02 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 04A331BF255 for ; Fri, 11 Oct 2019 09:00:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id F265E88744 for ; Fri, 11 Oct 2019 09:00:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hjet-0gXd3Wu for ; Fri, 11 Oct 2019 08:59:59 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by hemlock.osuosl.org (Postfix) with ESMTPS id 57D7788714 for ; Fri, 11 Oct 2019 08:59:59 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id j11so10990450wrp.1 for ; Fri, 11 Oct 2019 01:59:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VxVxglgeL3qKEjfGtgRUEcui49ts/sXRyc9+Ru8EifA=; b=ZYC3+Ay0TTFta5z+ySOxT1yy5LpFRPW45F3DLzdLsSnFcssZD5FOIoGQzZIffj9PRE Xp7tSexxRRmFAfnkZnIO/H9xELp4WVgYngxAfGg8CAkMhxaspm/T7nIm0G2TR3GBanTM HqldEpDOP6i/fQq5iP7PdzKUQ73+2B+htlySlLloN30Ckav9CMDVbj8L/1jq8qHlMuEz YSYFbHAkouAl/MqRdWYzltEq+OMpzt0VkOObZO2U4wKuaPGaxKGOQoWrgL6uV88JNJd/ sUUF0JmM2ZIyFw0Yiq/i0uyoqVA3RTqSFnfGEK+4ptYDsw83NTiLM6z1t2Wu9kKgKTSh Y0CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=VxVxglgeL3qKEjfGtgRUEcui49ts/sXRyc9+Ru8EifA=; b=nigsTb4O4olIVc9Bm5Xo5OKRdRqGCojTaZQMaZWNd7HHVLnfXVSIE+6c6icH56I7Pz xdcp2GbpIdtk8CtvMzHYYDdz2BxXl+0/FniRSxO2HNh2e7DDI4kh3io1I8HxscLbxEbB hq4lU6yv8PdBs7uCdEYX5oA65RczGEsaTG/E/Grcs3X4yhx8/Bwe7f+Dgi//DqjVI8vx 7eL6emcvibvyVFav9IWcz+jGdJU+V/2p2nd0Cr4ZEfn0IZnwbHj7exr0Bi3ED2kXWfhW qxMnos8QOY/1lLFlb+QtHAJcq9OUrfnY81Ils9bWqVI5JGgWB7KJIUxZc+cX9aMOxuqJ 1Aug== X-Gm-Message-State: APjAAAXUUVWAOTL4niy7N11FdM7rg1lxBquahATkPMXOH7opUFXUClTG QAUcjScOTTkKPJ1hPyTrw9s= X-Google-Smtp-Source: APXvYqyR+DoSJgDCtUsig3sb1fDtuGA9PsnsC+D7kvTxXfD4QRaZRJeDBKJ/39231CiBye99kWAcyA== X-Received: by 2002:adf:f48c:: with SMTP id l12mr11609168wro.99.1570784397867; Fri, 11 Oct 2019 01:59:57 -0700 (PDT) Received: from wambui ([197.237.61.225]) by smtp.gmail.com with ESMTPSA id b186sm11494222wmd.16.2019.10.11.01.59.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2019 01:59:57 -0700 (PDT) Date: Fri, 11 Oct 2019 11:59:52 +0300 From: Wambui Karuga To: Julia Lawall Subject: Re: [Outreachy kernel] [PATCH 1/5] staging: octeon: remove typedef declaration for cvmx_wqe_t Message-ID: <20191011085952.GA9748@wambui> References: <1b16bc880fee5711f96ed82741f8268e4dac1ae6.1570773209.git.wambui.karugax@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: alpine.DEB.2.21.1910110817340.2662@hadrien.osuosl.org Cc: devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Fri, Oct 11, 2019 at 08:18:25AM +0200, Julia Lawall wrote: > > > On Fri, 11 Oct 2019, Wambui Karuga wrote: > > > Remove typedef declaration from struct cvmx_wqe_t in > > You can remove the _t from the name as well. Should I remove the _t from all the enums/structs? > > > drivers/staging/octeon/octeon-stubs.h. > > It's not really necessary to give the name of the file in the log message, > as it can easily be seen below. > > julia > Okay, thought it would be clearer for the commit messages/git log. Thanks _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel