All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Tianjia Zhang <77389867@qq.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] tests: fix counting typo error
Date: Fri, 11 Oct 2019 11:18:10 +0100	[thread overview]
Message-ID: <20191011101810.GA6896@stefanha-x1.localdomain> (raw)
In-Reply-To: <20191010121702.90142-1-77389867@qq.com>

[-- Attachment #1: Type: text/plain, Size: 941 bytes --]

On Thu, Oct 10, 2019 at 08:17:02PM +0800, Tianjia Zhang wrote:
> Instead of global variables, local variables should be incrementing,
> This is a typo fix.
> 
> Signed-off-by: Tianjia Zhang <77389867@qq.com>
> ---
>  tests/test-rcu-list.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

CCing Paolo Bonzini, author of the RCU code.

> 
> diff --git a/tests/test-rcu-list.c b/tests/test-rcu-list.c
> index 6f076473e0..c0fc47ded4 100644
> --- a/tests/test-rcu-list.c
> +++ b/tests/test-rcu-list.c
> @@ -219,7 +219,7 @@ static void *rcu_q_updater(void *arg)
>              j++;
>              if (target_el == j) {
>                  struct list_element *new_el = g_new(struct list_element, 1);
> -                n_nodes += n_nodes_local;
> +                n_nodes_local++;
>                  TEST_LIST_INSERT_AFTER_RCU(el, new_el, entry);
>                  break;
>              }
> -- 
> 2.17.1
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2019-10-11 10:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-10 12:17 [PATCH] tests: fix counting typo error Tianjia Zhang
2019-10-11 10:18 ` Stefan Hajnoczi [this message]
2019-10-11 11:13 ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191011101810.GA6896@stefanha-x1.localdomain \
    --to=stefanha@gmail.com \
    --cc=77389867@qq.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.