From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81F6EECE58C for ; Fri, 11 Oct 2019 10:45:05 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 0CBCB2190F for ; Fri, 11 Oct 2019 10:45:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="xPSZgAGo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0CBCB2190F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 94E4E4A8B0; Fri, 11 Oct 2019 06:45:04 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 954qJSFbMgcl; Fri, 11 Oct 2019 06:45:03 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 79EBF4A8A1; Fri, 11 Oct 2019 06:45:03 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 17B614A8B0 for ; Fri, 11 Oct 2019 06:45:02 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xBow-Dt9BmnY for ; Fri, 11 Oct 2019 06:45:01 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 084204A863 for ; Fri, 11 Oct 2019 06:45:01 -0400 (EDT) Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2D63B2084C; Fri, 11 Oct 2019 10:44:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570790700; bh=bbQgNFwnmbeP7cYb09L5PBaPKxGPa4z3Rigbwq5f1WM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xPSZgAGoy5tmVAYpsur6voRj8yry0H/Txb8PXUOgcBTc+MPrY2ZWSWQAD2CE2VLFI TsUI6e/xIKiJUv3ExQmO+OCDNdPaLNJV3dTrHmYTHvSHqPN49vaO0qiGIHjX+IzKye jZX3lZ6Z6Xgi4wGUBkqGq8W9UeqRck46gRVha2IE= Date: Fri, 11 Oct 2019 11:44:55 +0100 From: Will Deacon To: Jayachandran Chandrasekharan Nair Subject: Re: [PATCH 0/2] Workaround for Cavium ThunderX2 erratum 219 Message-ID: <20191011104454.d7dplgyjcnpfi5p3@willie-the-truck> References: <1570790105-31829-1-git-send-email-jnair@marvell.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1570790105-31829-1-git-send-email-jnair@marvell.com> User-Agent: NeoMutt/20170113 (1.7.2) Cc: Tomasz Nowicki , Catalin Marinas , Robert Richter , Marc Zyngier , "kvmarm@lists.cs.columbia.edu" , "linux-arm-kernel@lists.infradead.org" X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi JC, Thanks for posting this. On Fri, Oct 11, 2019 at 10:35:21AM +0000, Jayachandran Chandrasekharan Nair wrote: > These two patches are based on the work by Marc Zyngier and addresses > Cavium ThunderX2 erratum 219. > > This erratum (originally reported by ARM folks) is from an interesting > use of the prefetch instruction in the KPTI patchset. The prefetch > was done between a TTBR change and the corresponding ISB, and this > occasionally caused a crash on ThunderX2. > > The first patch removes the troublesome prefetch for ThunderX2. > The second patch addresses the case where the issue can be triggered > from a guest kernel. The workaround in this case is to trap TTBR > accesses by setting HCR_EL2.TVM for guests and doing the system > register update from EL2 in a fast path. FWIW, I was already planning to send the following to Linus: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/log/?h=errata/tx2-219 so please base any changes on top of that branch. > Due to the nature of the erratum, the trap-and-emulate is only > needed when SMT is enabled. > > The overhead of trap-and-emulate is expected to be negligible on most > workloads. A command line option kvm-arm.vm_msr_trap has been > provided to override trapping on guest TTBR updates. This is to > address a very limited case where a user wants to run SMT enabled, > with a trustworthy guest kernel, and wants to avoid the performance > overhead associated with emulating the address translation register > changes. Do you have any performance data to show the impact of the workaround on non-kpti guests? I don't think we can justify the inclusion of a cmdline option for this without figures showing that it's really necessary. Otherwise, the "very limited case" really is a niche scenario where the CONFIG option can simply be disabled. Cheers, Will _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B4FAC47404 for ; Fri, 11 Oct 2019 10:45:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBB372084C for ; Fri, 11 Oct 2019 10:45:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HSudc6GW"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="xPSZgAGo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBB372084C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IwoP6tksxOkkRPKSpxHJcj55exjLbrw7x5Lfmpt8yx0=; b=HSudc6GWJdhqkx +b88VW1irP83/85KsKxgfcDPXs8Hy0tFEytTZHbNxUWZTlCSU7aM87zogQtTvBIqeInAvz9axpfmf 5Ka6auiKmFQAF+KU2qqgqq2BhjVbDTZ0jBO0pAlsdxmYFiExaZsuDZ/Ak8SjN3VS0TG/4um+Jyz+k +VOC+KMUoHfMeYiMyWoRPIVU8a0RswHpM7h6os/bvSfS+ju2AzMPU8gKoJOTN1l6hgDG/V4qsxSIv yCMcffTEYP2EwFbcXs6KbTGzpmcCNHjg97YZyLPcMTN7+vlNe5CZyBkCyQrJskOyXCUOCAL8a6uOg z3EnS1iNeq02DixA7kUA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIsPw-0007MN-6E; Fri, 11 Oct 2019 10:45:04 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIsPs-0007As-C7 for linux-arm-kernel@lists.infradead.org; Fri, 11 Oct 2019 10:45:01 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2D63B2084C; Fri, 11 Oct 2019 10:44:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570790700; bh=bbQgNFwnmbeP7cYb09L5PBaPKxGPa4z3Rigbwq5f1WM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xPSZgAGoy5tmVAYpsur6voRj8yry0H/Txb8PXUOgcBTc+MPrY2ZWSWQAD2CE2VLFI TsUI6e/xIKiJUv3ExQmO+OCDNdPaLNJV3dTrHmYTHvSHqPN49vaO0qiGIHjX+IzKye jZX3lZ6Z6Xgi4wGUBkqGq8W9UeqRck46gRVha2IE= Date: Fri, 11 Oct 2019 11:44:55 +0100 From: Will Deacon To: Jayachandran Chandrasekharan Nair Subject: Re: [PATCH 0/2] Workaround for Cavium ThunderX2 erratum 219 Message-ID: <20191011104454.d7dplgyjcnpfi5p3@willie-the-truck> References: <1570790105-31829-1-git-send-email-jnair@marvell.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1570790105-31829-1-git-send-email-jnair@marvell.com> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191011_034500_432550_416CFD3A X-CRM114-Status: GOOD ( 17.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomasz Nowicki , Suzuki K Poulose , Catalin Marinas , Robert Richter , James Morse , Julien Thierry , Marc Zyngier , "kvmarm@lists.cs.columbia.edu" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi JC, Thanks for posting this. On Fri, Oct 11, 2019 at 10:35:21AM +0000, Jayachandran Chandrasekharan Nair wrote: > These two patches are based on the work by Marc Zyngier and addresses > Cavium ThunderX2 erratum 219. > > This erratum (originally reported by ARM folks) is from an interesting > use of the prefetch instruction in the KPTI patchset. The prefetch > was done between a TTBR change and the corresponding ISB, and this > occasionally caused a crash on ThunderX2. > > The first patch removes the troublesome prefetch for ThunderX2. > The second patch addresses the case where the issue can be triggered > from a guest kernel. The workaround in this case is to trap TTBR > accesses by setting HCR_EL2.TVM for guests and doing the system > register update from EL2 in a fast path. FWIW, I was already planning to send the following to Linus: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/log/?h=errata/tx2-219 so please base any changes on top of that branch. > Due to the nature of the erratum, the trap-and-emulate is only > needed when SMT is enabled. > > The overhead of trap-and-emulate is expected to be negligible on most > workloads. A command line option kvm-arm.vm_msr_trap has been > provided to override trapping on guest TTBR updates. This is to > address a very limited case where a user wants to run SMT enabled, > with a trustworthy guest kernel, and wants to avoid the performance > overhead associated with emulating the address translation register > changes. Do you have any performance data to show the impact of the workaround on non-kpti guests? I don't think we can justify the inclusion of a cmdline option for this without figures showing that it's really necessary. Otherwise, the "very limited case" really is a niche scenario where the CONFIG option can simply be disabled. Cheers, Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel