From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Joe Perches <joe@perches.com>
Cc: Corey Minyard <minyard@acm.org>,
openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipmi: Convert ipmi_debug_msg to pr_debug and use %*ph
Date: Fri, 11 Oct 2019 19:05:41 +0300 [thread overview]
Message-ID: <20191011160541.GG32742@smile.fi.intel.com> (raw)
In-Reply-To: <7831759661d9f3d47bd304b2e98e65e5d6c5d167.camel@perches.com>
On Fri, Oct 11, 2019 at 08:46:41AM -0700, Joe Perches wrote:
> Using %*ph format to print small buffers as hex string reduces
> overall object size and allows the removal of the two variants
> of ipmi_debug_msg.
>
> This also removes unnecessary duplicate colons from output when
> enabled by #DEBUG or newly possible CONFIG_DYNAMIC_DEBUG.
I have sent v2 with slightly better approach (no need to have %s).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-10-11 16:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 14:52 [PATCH v1] ipmi: use %*ph to print small buffer Andy Shevchenko
2019-10-11 14:58 ` Joe Perches
2019-10-11 15:12 ` Andy Shevchenko
2019-10-11 15:18 ` Joe Perches
2019-10-11 15:36 ` Andy Shevchenko
2019-10-11 15:46 ` [PATCH] ipmi: Convert ipmi_debug_msg to pr_debug and use %*ph Joe Perches
2019-10-11 16:05 ` Andy Shevchenko [this message]
2019-10-11 16:15 ` Joe Perches
2019-10-14 0:55 ` kbuild test robot
2019-10-14 0:55 ` kbuild test robot
2019-10-14 1:21 ` kbuild test robot
2019-10-14 1:21 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011160541.GG32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.