From: David Miller <davem@davemloft.net>
To: ioana.ciornei@nxp.com
Cc: netdev@vger.kernel.org, ruxandra.radulescu@nxp.com
Subject: Re: [PATCH net 2/2] dpaa2-eth: Fix TX FQID values
Date: Sat, 12 Oct 2019 15:32:24 -0700 (PDT) [thread overview]
Message-ID: <20191012.153224.2132803535359154086.davem@davemloft.net> (raw)
In-Reply-To: <1570724387-5370-3-git-send-email-ioana.ciornei@nxp.com>
From: Ioana Ciornei <ioana.ciornei@nxp.com>
Date: Thu, 10 Oct 2019 19:19:47 +0300
> @@ -2533,6 +2536,45 @@ static int set_pause(struct dpaa2_eth_priv *priv)
> return 0;
> }
>
> +static void update_tx_fqids(struct dpaa2_eth_priv *priv)
> +{
> + struct dpaa2_eth_fq *fq;
> + struct dpni_queue queue;
> + struct dpni_queue_id qid = {0};
> + int i, j, err;
Reverse christmas tree local variable ordering here please.
prev parent reply other threads:[~2019-10-12 22:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 16:19 [PATCH net 0/2] dpaa2-eth: misc fixes Ioana Ciornei
2019-10-10 16:19 ` [PATCH net 1/2] dpaa2-eth: add irq for the dpmac connect/disconnect event Ioana Ciornei
2019-10-10 16:19 ` [PATCH net 2/2] dpaa2-eth: Fix TX FQID values Ioana Ciornei
2019-10-12 22:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191012.153224.2132803535359154086.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ioana.ciornei@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=ruxandra.radulescu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.