tree: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git keys-acl head: 9f9385fc35f5528b197970130e39e23ba82b3689 commit: addfb78802c0a5353c5f81a2bf10985302bc186e [1/2] keys: Replace uid/gid/perm permissions checking with an ACL reproduce: # apt-get install sparse # sparse version: v0.6.1-rc1-42-g38eda53-dirty git checkout addfb78802c0a5353c5f81a2bf10985302bc186e make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) >> fs/crypto/keyring.c:207:65: sparse: sparse: incorrect type in argument 5 (different base types) @@ expected struct key_acl *acl @@ got l *acl @@ >> fs/crypto/keyring.c:207:65: sparse: expected struct key_acl *acl >> fs/crypto/keyring.c:207:65: sparse: got int fs/crypto/keyring.c:251:65: sparse: sparse: incorrect type in argument 5 (different base types) @@ expected struct key_acl *acl @@ got l *acl @@ fs/crypto/keyring.c:251:65: sparse: expected struct key_acl *acl fs/crypto/keyring.c:251:65: sparse: got int fs/crypto/keyring.c:288:44: sparse: sparse: incorrect type in argument 6 (different base types) @@ expected struct key_acl *acl @@ got l *acl @@ fs/crypto/keyring.c:288:44: sparse: expected struct key_acl *acl fs/crypto/keyring.c:288:44: sparse: got int fs/crypto/keyring.c:360:57: sparse: sparse: incorrect type in argument 6 (different base types) @@ expected struct key_acl *acl @@ got l *acl @@ fs/crypto/keyring.c:360:57: sparse: expected struct key_acl *acl fs/crypto/keyring.c:360:57: sparse: got int -- >> fs/crypto/keysetup_v1.c:107:26: sparse: sparse: not enough arguments for function request_key fs/crypto/keysetup_v1.c:166:17: sparse: sparse: context imbalance in 'fscrypt_put_direct_key' - unexpected unlock -- >> fs/verity/signature.c:142:48: sparse: sparse: incorrect type in argument 5 (different base types) @@ expected struct key_acl *acl @@ got l *acl @@ >> fs/verity/signature.c:142:48: sparse: expected struct key_acl *acl >> fs/verity/signature.c:142:48: sparse: got int -- >> drivers/md/dm-verity-verify-sig.c:38:26: sparse: sparse: not enough arguments for function request_key vim +207 fs/crypto/keyring.c 23c688b54016ee Eric Biggers 2019-08-04 194 22d94f493bfb40 Eric Biggers 2019-08-04 195 /* Create ->s_master_keys if needed. Synchronized by fscrypt_add_key_mutex. */ 22d94f493bfb40 Eric Biggers 2019-08-04 196 static int allocate_filesystem_keyring(struct super_block *sb) 22d94f493bfb40 Eric Biggers 2019-08-04 197 { 22d94f493bfb40 Eric Biggers 2019-08-04 198 char description[FSCRYPT_FS_KEYRING_DESCRIPTION_SIZE]; 22d94f493bfb40 Eric Biggers 2019-08-04 199 struct key *keyring; 22d94f493bfb40 Eric Biggers 2019-08-04 200 22d94f493bfb40 Eric Biggers 2019-08-04 201 if (sb->s_master_keys) 22d94f493bfb40 Eric Biggers 2019-08-04 202 return 0; 22d94f493bfb40 Eric Biggers 2019-08-04 203 22d94f493bfb40 Eric Biggers 2019-08-04 204 format_fs_keyring_description(description, sb); 22d94f493bfb40 Eric Biggers 2019-08-04 205 keyring = keyring_alloc(description, GLOBAL_ROOT_UID, GLOBAL_ROOT_GID, 22d94f493bfb40 Eric Biggers 2019-08-04 206 current_cred(), KEY_POS_SEARCH | 22d94f493bfb40 Eric Biggers 2019-08-04 @207 KEY_USR_SEARCH | KEY_USR_READ | KEY_USR_VIEW, 22d94f493bfb40 Eric Biggers 2019-08-04 208 KEY_ALLOC_NOT_IN_QUOTA, NULL, NULL); 22d94f493bfb40 Eric Biggers 2019-08-04 209 if (IS_ERR(keyring)) 22d94f493bfb40 Eric Biggers 2019-08-04 210 return PTR_ERR(keyring); 22d94f493bfb40 Eric Biggers 2019-08-04 211 22d94f493bfb40 Eric Biggers 2019-08-04 212 /* Pairs with READ_ONCE() in fscrypt_find_master_key() */ 22d94f493bfb40 Eric Biggers 2019-08-04 213 smp_store_release(&sb->s_master_keys, keyring); 22d94f493bfb40 Eric Biggers 2019-08-04 214 return 0; 22d94f493bfb40 Eric Biggers 2019-08-04 215 } 22d94f493bfb40 Eric Biggers 2019-08-04 216 :::::: The code at line 207 was first introduced by commit :::::: 22d94f493bfb408fdd764f7b1d0363af2122fba5 fscrypt: add FS_IOC_ADD_ENCRYPTION_KEY ioctl :::::: TO: Eric Biggers :::::: CC: Eric Biggers --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation