From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD498C4CECE for ; Mon, 14 Oct 2019 07:27:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A18352064A for ; Mon, 14 Oct 2019 07:27:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xfMY0SiR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730419AbfJNH1O (ORCPT ); Mon, 14 Oct 2019 03:27:14 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:44971 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730143AbfJNH1O (ORCPT ); Mon, 14 Oct 2019 03:27:14 -0400 Received: by mail-wr1-f66.google.com with SMTP id z9so18343061wrl.11 for ; Mon, 14 Oct 2019 00:27:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=U6/vqqI+KFne/Y1dUe/Jfr2lNHLnywOUOorz0nDROSE=; b=xfMY0SiR5P3VvexTUHqw+8OwvkSFp1LclUgomGX8ksXD9q+KX3colpmtmOQTdGsSr1 mLiKIi4t6EbNMkHrkaw6c9HN0uFFJPrEveqy1XNvtv8xxA4a3rmzkcgsc9ArmbsDqi+q BVBGVv4Bz102IqKVDtJRIvf445rKWFHWpSvGTw590ibcF0ATNRW1OqFNBbueDBB0fKNW WmL9j6X+gmvrsvEh5CzILouSfDc8LlVezqWssmsW32To36UlqbkrTmMdHv3oamJyMUnp VJl9ivKm4uvwcw4URs8Tp0jzVZbp8nDo6aTXnyBSyPiY3pl1viQ5mYhAzoaBsKx6fifV 6peg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=U6/vqqI+KFne/Y1dUe/Jfr2lNHLnywOUOorz0nDROSE=; b=R9MDhJ2QBEZ9FUMmB2f5xBvziuNIq1tKLup2c2eVDpDLi+CutTfzKLSjyTogbYuTDg PpXfxpKKWI6YuIzr/JI3yTcB2pwffhGIoEHdZiPstRcCutJLrwP80/p+AaaqID8VRnWI f5eTo37vspfstBiNQI44w/sMzlHfv5bWk1mfrJSz7JUwtayQJtbWaRiyvXdVroAcO3gO Y6KZc899Z61IBJNsPLNA6EU6dRK3oWEPDqIhn8E6pHhTSbr6fNfhhazkEQpeJbr40lh0 hHBFhijP51bgB3L2BKCA9elvvtd044hZbuM4Jz5ab/s9mb4gNE1gqhEyofcVqaJFngU3 YJ8w== X-Gm-Message-State: APjAAAU1aMjrMQKWNAjnw2A35u25JX8MNGyybIYOqduWCQnLfM0rC6lb 4EpErwNWoaIhJggz0BHz68/2sg== X-Google-Smtp-Source: APXvYqwNx4BWT3sUTOLgHRxO1bczBBeKgEVPdgkFIDoixi5Si9gU2rsgGmIYce/VDvFK7gDzI8aLMw== X-Received: by 2002:adf:82ab:: with SMTP id 40mr23551615wrc.251.1571038032239; Mon, 14 Oct 2019 00:27:12 -0700 (PDT) Received: from dell ([2.27.167.11]) by smtp.gmail.com with ESMTPSA id x2sm21172669wrn.81.2019.10.14.00.27.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Oct 2019 00:27:11 -0700 (PDT) Date: Mon, 14 Oct 2019 08:27:10 +0100 From: Lee Jones To: Rasmus Villemoes Cc: Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Daniel Thompson , Jingoo Han , Bartlomiej Zolnierkiewicz , linux-pwm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/4] backlight: pwm_bl: fix cie1913 comments and constant Message-ID: <20191014072710.GE4545@dell> References: <20191008120327.24208-1-linux@rasmusvillemoes.dk> <20191008120327.24208-2-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191008120327.24208-2-linux@rasmusvillemoes.dk> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 08 Oct 2019, Rasmus Villemoes wrote: > The "break-even" point for the two formulas is L==8, which is also > what the code actually implements. [Incidentally, at that point one > has Y=0.008856, not 0.08856]. > > Moreover, all the sources I can find say the linear factor is 903.3 > rather than 902.3, which makes sense since then the formulas agree at > L==8, both yielding the 0.008856 figure to four significant digits. > > Reviewed-by: Daniel Thompson > Signed-off-by: Rasmus Villemoes > --- > drivers/video/backlight/pwm_bl.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Mon, 14 Oct 2019 07:27:10 +0000 Subject: Re: [PATCH v2 1/4] backlight: pwm_bl: fix cie1913 comments and constant Message-Id: <20191014072710.GE4545@dell> List-Id: References: <20191008120327.24208-1-linux@rasmusvillemoes.dk> <20191008120327.24208-2-linux@rasmusvillemoes.dk> In-Reply-To: <20191008120327.24208-2-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Rasmus Villemoes Cc: Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Daniel Thompson , Jingoo Han , Bartlomiej Zolnierkiewicz , linux-pwm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, 08 Oct 2019, Rasmus Villemoes wrote: > The "break-even" point for the two formulas is L=8, which is also > what the code actually implements. [Incidentally, at that point one > has Y=0.008856, not 0.08856]. > > Moreover, all the sources I can find say the linear factor is 903.3 > rather than 902.3, which makes sense since then the formulas agree at > L=8, both yielding the 0.008856 figure to four significant digits. > > Reviewed-by: Daniel Thompson > Signed-off-by: Rasmus Villemoes > --- > drivers/video/backlight/pwm_bl.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog