From: Daniel Vetter <daniel@ffwll.ch>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Rohan Garg <rohan.garg@collabora.com>,
kernel@collabora.com, dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v4] drm/ioctl: Add a ioctl to label GEM objects
Date: Mon, 14 Oct 2019 10:58:11 +0200 [thread overview]
Message-ID: <20191014085810.GG11828@phenom.ffwll.local> (raw)
In-Reply-To: <41425496-d121-8d51-991e-b3025b787c49@suse.de>
On Fri, Oct 11, 2019 at 07:55:36PM +0200, Thomas Zimmermann wrote:
> Hi
>
> Am 11.10.19 um 19:09 schrieb Daniel Stone:
> > Hi Rohan,
> >
> > On Fri, 11 Oct 2019 at 15:30, Rohan Garg <rohan.garg@collabora.com> wrote:
> > > DRM_IOCTL_DUMB_SET_LABEL lets you label GEM objects, making it
> > > easier to debug issues in userspace applications.
> >
> > I'm not sure if this was pointed out already, but dumb buffers != GEM
> > buffers. GEM buffers _can_ be dumb, but might not be.
> >
> > Could you please rename to GEM_SET_LABEL?
>
> This change to build upon dumb buffers was suggested by me, as dumb buffers
> is the closes thing there is to a buffer management interface. Drivers with
> 'smart buffers' would have to add their own ioctl interfaces.
We already have some IOCTLs that apply to gem buffers, not just dumb
buffers, so GEM_SET_LABEL seems a lot more reasonable to me, too.
> What I really miss here is a userspace application that uses this
> functionality. It would be much easier to discuss if there was an actual
> example.
+1.
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-10-14 8:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 14:30 [PATCH v4] drm/ioctl: Add a ioctl to label GEM objects Rohan Garg
2019-10-11 17:09 ` Daniel Stone
2019-10-11 17:55 ` Thomas Zimmermann
2019-10-14 8:58 ` Daniel Vetter [this message]
2019-10-22 8:58 ` Rohan Garg
2019-10-22 8:58 ` Rohan Garg
2019-10-11 17:31 ` Boris Brezillon
2019-10-12 13:35 ` Dan Carpenter
2019-10-12 13:35 ` Dan Carpenter
2019-10-12 13:35 ` Dan Carpenter
2019-10-14 8:59 ` Daniel Vetter
2019-10-22 8:58 ` Rohan Garg
2019-10-22 9:30 ` Daniel Vetter
2019-10-22 13:14 ` Daniel Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014085810.GG11828@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@collabora.com \
--cc=rohan.garg@collabora.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.