From: Anthony PERARD <anthony.perard@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org,
Andrew Cooper <Andrew.Cooper3@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
Paul Durrant <pdurrant@gmail.com>
Subject: Re: [Xen-devel] [XEN PATCH for-4.13 v3 09/10] libxl: Move domain_create_info_setdefault earlier
Date: Mon, 14 Oct 2019 13:53:58 +0100 [thread overview]
Message-ID: <20191014125358.GB5743@perard.uk.xensource.com> (raw)
In-Reply-To: <20191011165549.21639-6-ian.jackson@eu.citrix.com>
On Fri, Oct 11, 2019 at 05:55:48PM +0100, Ian Jackson wrote:
> We need this before we start to figure out the passthrough mode.
>
> I have checked that nothing in libxl__domain_create_info_setdefault
> nor the two implementations of ..._arch_... accesses anything else,
> other than (i) the domain type (which this function is responsible for
> setting and nothing before it looks at) (ii) c_info->ssidref (which is
> defaulted by flask code near the top of
> libxl__domain_config_setdefault and not accessed afterwards).
>
> So no functional change.
>
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
--
Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-10-14 12:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 16:55 [Xen-devel] [XEN PATCH for-4.13 v3 00/10] libxl memkb & pt defaulting Ian Jackson
2019-10-11 16:55 ` [Xen-devel] [XEN PATCH for-4.13 v3 05/10] libxl: Move shadow_memkb and iommu_memkb defaulting into libxl Ian Jackson
2019-10-14 12:45 ` Anthony PERARD
2019-10-14 16:50 ` Anthony PERARD
2019-10-14 16:53 ` Ian Jackson
2019-10-14 17:00 ` Ian Jackson
2019-10-15 10:37 ` Anthony PERARD
2019-10-11 16:55 ` [Xen-devel] [XEN PATCH for-4.13 v3 06/10] libxl: Remove/deprecate libxl_get_required_*_memory from the API Ian Jackson
2019-10-11 16:55 ` [Xen-devel] [XEN PATCH for-4.13 v3 07/10] libxl: create: setdefault: Make libxl_physinfo info[1] Ian Jackson
2019-10-11 16:55 ` [Xen-devel] [XEN PATCH for-4.13 v3 08/10] libxl: create: setdefault: Move physinfo into config_setdefault Ian Jackson
2019-10-11 16:55 ` [Xen-devel] [XEN PATCH for-4.13 v3 09/10] libxl: Move domain_create_info_setdefault earlier Ian Jackson
2019-10-14 12:53 ` Anthony PERARD [this message]
2019-10-11 16:55 ` [Xen-devel] [XEN PATCH for-4.13 v3 10/10] libxl/xl: Overhaul passthrough setting logic Ian Jackson
2019-10-14 16:05 ` Anthony PERARD
2019-10-14 16:10 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014125358.GB5743@perard.uk.xensource.com \
--to=anthony.perard@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=pdurrant@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.