From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@fb.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
tglx@linutronix.de, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2] nvme-tcp: Initialize sk->sk_ll_usec only with NET_RX_BUSY_POLL
Date: Tue, 15 Oct 2019 00:06:16 +0900 [thread overview]
Message-ID: <20191014150616.GB6142@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <20191014071651.GC10081@lst.de>
On Mon, Oct 14, 2019 at 09:16:51AM +0200, Christoph Hellwig wrote:
> On Thu, Oct 10, 2019 at 05:34:12PM +0200, Sebastian Andrzej Siewior wrote:
> > The access to sk->sk_ll_usec should be hidden behind
> > CONFIG_NET_RX_BUSY_POLL like the definition of sk_ll_usec.
> >
> > Put access to ->sk_ll_usec behind CONFIG_NET_RX_BUSY_POLL.
> >
> > Fixes: 1a9460cef5711 ("nvme-tcp: support simple polling")
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>
> Looks good,
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks, applied to nvme-5.4.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2019-10-14 15:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 15:06 [PATCH] nvme-tcp: Remove access to sk->sk_ll_usec Sebastian Andrzej Siewior
2019-10-10 15:07 ` Christoph Hellwig
2019-10-10 15:10 ` Sebastian Andrzej Siewior
2019-10-10 15:14 ` Christoph Hellwig
2019-10-10 15:29 ` Sebastian Andrzej Siewior
2019-10-10 15:29 ` Christoph Hellwig
2019-10-10 15:34 ` [PATCH v2] nvme-tcp: Initialize sk->sk_ll_usec only with NET_RX_BUSY_POLL Sebastian Andrzej Siewior
2019-10-10 17:08 ` Wunderlich, Mark
2019-10-10 17:19 ` Christoph Hellwig
2019-10-14 7:16 ` Christoph Hellwig
2019-10-14 15:06 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014150616.GB6142@redsun51.ssa.fujisawa.hgst.com \
--to=kbusch@kernel.org \
--cc=axboe@fb.com \
--cc=bigeasy@linutronix.de \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.