Hi "Thomas,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.4-rc3 next-20191014]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Thomas-Hellstr-m-VMware/Emulated-coherent-graphics-memory-take-2/20191014-213955
config: x86_64-rhel (attached as .config)
compiler: gcc-7 (Debian 7.4.0-13) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c: In function 'vmw_mmap':
>> drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c:36:11: error: 'ttm_bo_vm_open' undeclared (first use in this function); did you mean 'ttm_bo_mem_put'?
      .open = ttm_bo_vm_open,
              ^~~~~~~~~~~~~~
              ttm_bo_mem_put
   drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c:36:11: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c:37:12: error: 'ttm_bo_vm_close' undeclared (first use in this function); did you mean 'ttm_bo_vm_open'?
      .close = ttm_bo_vm_close
               ^~~~~~~~~~~~~~~
               ttm_bo_vm_open
--
   drivers/gpu/drm/vmwgfx/vmwgfx_page_dirty.c: In function 'vmw_bo_vm_mkwrite':
>> drivers/gpu/drm/vmwgfx/vmwgfx_page_dirty.c:364:8: error: implicit declaration of function 'ttm_bo_vm_reserve'; did you mean 'ttm_bo_unreserve'? [-Werror=implicit-function-declaration]
     ret = ttm_bo_vm_reserve(bo, vmf);
           ^~~~~~~~~~~~~~~~~
           ttm_bo_unreserve
   drivers/gpu/drm/vmwgfx/vmwgfx_page_dirty.c: In function 'vmw_bo_vm_fault':
>> drivers/gpu/drm/vmwgfx/vmwgfx_page_dirty.c:414:3: error: 'TTM_BO_VM_NUM_PREFAULT' undeclared (first use in this function)
      TTM_BO_VM_NUM_PREFAULT;
      ^~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/vmwgfx/vmwgfx_page_dirty.c:414:3: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/gpu/drm/vmwgfx/vmwgfx_page_dirty.c:415:8: error: implicit declaration of function 'ttm_bo_vm_fault_reserved'; did you mean 'ttm_bo_init_reserved'? [-Werror=implicit-function-declaration]
     ret = ttm_bo_vm_fault_reserved(vmf, prot, num_prefault);
           ^~~~~~~~~~~~~~~~~~~~~~~~
           ttm_bo_init_reserved
   cc1: some warnings being treated as errors

vim +36 drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c

    29	
    30	int vmw_mmap(struct file *filp, struct vm_area_struct *vma)
    31	{
    32		static const struct vm_operations_struct vmw_vm_ops = {
    33			.pfn_mkwrite = vmw_bo_vm_mkwrite,
    34			.page_mkwrite = vmw_bo_vm_mkwrite,
    35			.fault = vmw_bo_vm_fault,
  > 36			.open = ttm_bo_vm_open,
  > 37			.close = ttm_bo_vm_close
    38		};
    39		struct drm_file *file_priv = filp->private_data;
    40		struct vmw_private *dev_priv = vmw_priv(file_priv->minor->dev);
    41		int ret = ttm_bo_mmap(filp, vma, &dev_priv->bdev);
    42	
    43		if (ret)
    44			return ret;
    45	
    46		vma->vm_ops = &vmw_vm_ops;
    47	
    48		return 0;
    49	}
    50	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation