From mboxrd@z Thu Jan 1 00:00:00 1970 From: AKASHI Takahiro Date: Tue, 15 Oct 2019 12:18:21 +0900 Subject: [U-Boot] [PATCH v1 00/11] import x509/pkcs7 parsers from linux In-Reply-To: <2cee5152-3dea-5592-b7e5-590c95ece109@gmx.de> References: <20191011074200.30269-1-takahiro.akashi@linaro.org> <20191011075507.GF18778@linaro.org> <2cee5152-3dea-5592-b7e5-590c95ece109@gmx.de> Message-ID: <20191015031819.GH18778@linaro.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sat, Oct 12, 2019 at 03:02:09PM +0200, Heinrich Schuchardt wrote: > On 10/11/19 9:55 AM, AKASHI Takahiro wrote: > >I hope this patch set will be reviewed promptly as I'm aiming to > >push my "UEFI secure boot" patch for v2020.01. > > > > How can I make all of these new files being built to check for build > warnings? As always in my case of UEFI secure boot, they have gone through build and run/tests as part of UEFI secure boot. This is also true for RSA extension as UEFI secure boot is the only user of those features. Please note that almost of all the code here come from the latest linux code without any changes. A few changes that I made are quite U-Boot/UEFI-secure-boot specific and is *best* tested through UEFI secure boot test. That said, you can at least build the code by enabling Library routines Security support Asymmetric Key Support CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE CONFIG_X509_CERTIFICATE_PARSER CONFIG_PKCS7_MESSAGE_PARSER > Please, provide unit tests for the patch series. As I said above, it will be exercised and tested under UEFI secure boot test. > Please, provide a documentation how these different tools and files work > together. What do you mean by different tools? Asn1 compiler and what? Do you want to have doc/README.asn1compiler? Thanks, -Takahiro Akashi > Best regards > > Heinrich