All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sasha Levin <sashal@kernel.org>
Cc: m.felsch@pengutronix.de, Jonathan.Cameron@huawei.com,
	Stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] iio: light: fix vcnl4000 devicetree hooks" failed to apply to 5.3-stable tree
Date: Tue, 15 Oct 2019 08:18:09 +0200	[thread overview]
Message-ID: <20191015061809.GA926806@kroah.com> (raw)
In-Reply-To: <20191015030419.GJ31224@sasha-vm>

On Mon, Oct 14, 2019 at 11:04:19PM -0400, Sasha Levin wrote:
> On Mon, Oct 14, 2019 at 06:11:42PM +0200, gregkh@linuxfoundation.org wrote:
> > 
> > The patch below does not apply to the 5.3-stable tree.
> > If someone wants it applied there, or to any other stable or longterm
> > tree, then please email the backport, including the original git commit
> > id to <stable@vger.kernel.org>.
> > 
> > thanks,
> > 
> > greg k-h
> > 
> > ------------------ original commit in Linus's tree ------------------
> > 
> > > From 1436a78c63495dd94c8d4f84a76d78d5317d481b Mon Sep 17 00:00:00 2001
> > From: Marco Felsch <m.felsch@pengutronix.de>
> > Date: Tue, 17 Sep 2019 16:56:36 +0200
> > Subject: [PATCH] iio: light: fix vcnl4000 devicetree hooks
> > 
> > Since commit ebd457d55911 ("iio: light: vcnl4000 add devicetree hooks")
> > the of_match_table is supported but the data shouldn't be a string.
> > Instead it shall be one of 'enum vcnl4000_device_ids'. Also the matching
> > logic for the vcnl4020 was wrong. Since the data retrieve mechanism is
> > still based on the i2c_device_id no failures did appeared till now.
> > 
> > Fixes: ebd457d55911 ("iio: light: vcnl4000 add devicetree hooks")
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > Reviewed-by: Angus Ainslie (Purism) angus@akkea.ca
> > Cc: <Stable@vger.kernel.org>
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Greg, I'm not sure why you dropped this one?
> 
> I've queued it up for 5.3.

It doesn't apply to my 5.3 tree, and now that you added it, it still
doesn't apply :(

So I'm going to drop it now.  How did this apply on your side?

thanks,

greg k-h

  reply	other threads:[~2019-10-15  6:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-14 16:11 FAILED: patch "[PATCH] iio: light: fix vcnl4000 devicetree hooks" failed to apply to 5.3-stable tree gregkh
2019-10-15  3:04 ` Sasha Levin
2019-10-15  6:18   ` Greg KH [this message]
2019-10-15 14:19     ` Sasha Levin
2019-10-15 15:33       ` Greg KH
2019-10-15 16:35         ` Sasha Levin
2019-10-15 17:39           ` Greg KH
2019-10-15 22:06             ` Sasha Levin
2019-10-16 12:52               ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191015061809.GA926806@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=Stable@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=sashal@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.