From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BFF1C10F14 for ; Tue, 15 Oct 2019 11:01:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F39BE2086A for ; Tue, 15 Oct 2019 11:01:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F39BE2086A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKKZt-0006q0-6D for qemu-devel@archiver.kernel.org; Tue, 15 Oct 2019 07:01:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52202) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKKVO-0001zC-3z for qemu-devel@nongnu.org; Tue, 15 Oct 2019 06:56:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKKVN-0008LQ-26 for qemu-devel@nongnu.org; Tue, 15 Oct 2019 06:56:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60530) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iKKVK-0008Hl-VA; Tue, 15 Oct 2019 06:56:39 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E1795307BCC5; Tue, 15 Oct 2019 10:56:34 +0000 (UTC) Received: from kamzik.brq.redhat.com (unknown [10.43.2.160]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B5FE6194B6; Tue, 15 Oct 2019 10:56:30 +0000 (UTC) Date: Tue, 15 Oct 2019 12:56:28 +0200 From: Andrew Jones To: Beata Michalska Subject: Re: [PATCH v5 1/9] target/arm/monitor: Introduce qmp_query_cpu_model_expansion Message-ID: <20191015105628.7ln6ph5s3vpsyfuw@kamzik.brq.redhat.com> References: <20191001125845.8793-1-drjones@redhat.com> <20191001125845.8793-2-drjones@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Tue, 15 Oct 2019 10:56:35 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Richard Henderson , qemu-devel@nongnu.org, armbru@redhat.com, eric.auger@redhat.com, qemu-arm@nongnu.org, imammedo@redhat.com, Dave.Martin@arm.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Oct 15, 2019 at 10:59:16AM +0100, Beata Michalska wrote: > On Tue, 1 Oct 2019 at 14:04, Andrew Jones wrote: > > + > > + obj = object_new(object_class_get_name(oc)); > > + > > + if (qdict_in) { > > + Visitor *visitor; > > + Error *err = NULL; > > + > > + visitor = qobject_input_visitor_new(model->props); > > + visit_start_struct(visitor, NULL, NULL, 0, &err); > > + if (err) { > > + object_unref(obj); > > Shouldn't we free the 'visitor' here as well ? Yes. Good catch. So we also need to fix target/s390x/cpu_models.c:cpu_model_from_info(), which has the same construction (the construction from which I derived this) > > > + error_propagate(errp, err); > > + return NULL; > > + } > > + What about the rest of the patch? With that fixed for v6 can I add your r-b? Thanks, drew