From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Date: Tue, 15 Oct 2019 17:28:50 +0000 Subject: Re: [PATCH v2 08/15] drm/fbconv: Add plane-state check and update Message-Id: <201910160147.NR8eNv8Z%lkp@intel.com> List-Id: References: <20191014140416.28517-9-tzimmermann@suse.de> In-Reply-To: <20191014140416.28517-9-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-fbdev@vger.kernel.org, kbuild-all@lists.01.org, Thomas Zimmermann , b.zolnierkie@samsung.com, airlied@linux.ie, gregkh@linuxfoundation.org, michel@daenzer.net, corbet@lwn.net, malat@debian.org, dri-devel@lists.freedesktop.org, sean@poorly.run Hi Thomas, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [cannot apply to v5.4-rc3 next-20191014] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/DRM-fbconv-helpers-for-converting-fbdev-drivers/20191015-152231 reproduce: # apt-get install sparse # sparse version: v0.6.1-dirty make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) >> drivers/gpu/drm/drm_fbconv_helper.c:981:39: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] *dst @@ got n:2> *dst @@ >> drivers/gpu/drm/drm_fbconv_helper.c:981:39: sparse: expected void [noderef] *dst >> drivers/gpu/drm/drm_fbconv_helper.c:981:39: sparse: got void *dst drivers/gpu/drm/drm_fbconv_helper.c:985:51: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] *dst @@ got n:2> *dst @@ drivers/gpu/drm/drm_fbconv_helper.c:985:51: sparse: expected void [noderef] *dst drivers/gpu/drm/drm_fbconv_helper.c:985:51: sparse: got void *dst drivers/gpu/drm/drm_fbconv_helper.c:990:51: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] *dst @@ got n:2> *dst @@ drivers/gpu/drm/drm_fbconv_helper.c:990:51: sparse: expected void [noderef] *dst drivers/gpu/drm/drm_fbconv_helper.c:990:51: sparse: got void *dst >> drivers/gpu/drm/drm_fbconv_helper.c:1291:21: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void *screen_base @@ got char [noderef] > drivers/gpu/drm/drm_fbconv_helper.c:1291:21: sparse: expected void *screen_base >> drivers/gpu/drm/drm_fbconv_helper.c:1291:21: sparse: got char [noderef] *screen_base >> drivers/gpu/drm/drm_fbconv_helper.c:1294:29: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void *screen_base @@ got void [noderef] > drivers/gpu/drm/drm_fbconv_helper.c:1294:29: sparse: got void [noderef] * >> drivers/gpu/drm/drm_fbconv_helper.c:1318:25: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void volatile [noderef] *addr @@ got n:2> *addr @@ >> drivers/gpu/drm/drm_fbconv_helper.c:1318:25: sparse: expected void volatile [noderef] *addr >> drivers/gpu/drm/drm_fbconv_helper.c:1318:25: sparse: got void *screen_base drivers/gpu/drm/drm_fbconv_helper.c:1346:38: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void volatile [noderef] *addr @@ got n:2> *addr @@ drivers/gpu/drm/drm_fbconv_helper.c:1346:38: sparse: expected void volatile [noderef] *addr drivers/gpu/drm/drm_fbconv_helper.c:1346:38: sparse: got void *screen_base vim +981 drivers/gpu/drm/drm_fbconv_helper.c 956 957 /** 958 * drm_fbconv_blit_rect - copy an area of pixel data from a framebuffer 959 * to the hardware buffer 960 * @dst: the on-screen hardware buffer 961 * @vaddr: the source buffer in kernel address space 962 * @fb: the framebuffer of the source buffer 963 * @rect: the area to copy 964 * Returns: 965 * 0 on success, or 966 * a negative error code otherwise. 967 * 968 * This function copies the pixel data from a DRM framebuffer to a hardware 969 * buffer; doing necessary format conversion in the process. Not all 970 * combinations of source and destination formats are currently supported. 971 */ 972 int drm_fbconv_blit_rect(void *dst, void *vaddr, struct drm_framebuffer *fb, 973 struct drm_rect *rect) 974 { 975 struct drm_device *dev = fb->dev; 976 977 if (!vaddr) 978 return 0; /* no framebuffer set for plane; no error */ 979 980 if (dev->mode_config.preferred_depth = (fb->format->cpp[0] * 8)) > 981 drm_fb_memcpy_dstclip(dst, vaddr, fb, rect); 982 983 else if (fb->format->cpp[0] = 4 && 984 dev->mode_config.preferred_depth = 16) > 985 drm_fb_xrgb8888_to_rgb565_dstclip(dst, fb->pitches[0], 986 vaddr, fb, rect, false); 987 988 else if (fb->format->cpp[0] = 4 && 989 dev->mode_config.preferred_depth = 24) > 990 drm_fb_xrgb8888_to_rgb888_dstclip(dst, fb->pitches[0], 991 vaddr, fb, rect); 992 993 else { 994 /* TODO: add the missing conversion */ 995 DRM_ERROR("fbconv: mismatching pixel formats\n"); 996 return -EINVAL; 997 } 998 999 return 0; 1000 } 1001 EXPORT_SYMBOL(drm_fbconv_blit_rect); 1002 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: Re: [PATCH v2 08/15] drm/fbconv: Add plane-state check and update Date: Wed, 16 Oct 2019 01:28:50 +0800 Message-ID: <201910160147.NR8eNv8Z%lkp@intel.com> References: <20191014140416.28517-9-tzimmermann@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id D67116E874 for ; Tue, 15 Oct 2019 17:29:27 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20191014140416.28517-9-tzimmermann@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Cc: linux-fbdev@vger.kernel.org, kbuild-all@lists.01.org, Thomas Zimmermann , b.zolnierkie@samsung.com, airlied@linux.ie, gregkh@linuxfoundation.org, michel@daenzer.net, corbet@lwn.net, malat@debian.org, dri-devel@lists.freedesktop.org, sean@poorly.run List-Id: dri-devel@lists.freedesktop.org SGkgVGhvbWFzLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2ghIFBlcmhhcHMgc29tZXRoaW5nIHRv IGltcHJvdmU6CgpbYXV0byBidWlsZCB0ZXN0IFdBUk5JTkcgb24gbGludXMvbWFzdGVyXQpbY2Fu bm90IGFwcGx5IHRvIHY1LjQtcmMzIG5leHQtMjAxOTEwMTRdCltpZiB5b3VyIHBhdGNoIGlzIGFw cGxpZWQgdG8gdGhlIHdyb25nIGdpdCB0cmVlLCBwbGVhc2UgZHJvcCB1cyBhIG5vdGUgdG8gaGVs cAppbXByb3ZlIHRoZSBzeXN0ZW0uIEJUVywgd2UgYWxzbyBzdWdnZXN0IHRvIHVzZSAnLS1iYXNl JyBvcHRpb24gdG8gc3BlY2lmeSB0aGUKYmFzZSB0cmVlIGluIGdpdCBmb3JtYXQtcGF0Y2gsIHBs ZWFzZSBzZWUgaHR0cHM6Ly9zdGFja292ZXJmbG93LmNvbS9hLzM3NDA2OTgyXQoKdXJsOiAgICBo dHRwczovL2dpdGh1Yi5jb20vMGRheS1jaS9saW51eC9jb21taXRzL1Rob21hcy1aaW1tZXJtYW5u L0RSTS1mYmNvbnYtaGVscGVycy1mb3ItY29udmVydGluZy1mYmRldi1kcml2ZXJzLzIwMTkxMDE1 LTE1MjIzMQpyZXByb2R1Y2U6CiAgICAgICAgIyBhcHQtZ2V0IGluc3RhbGwgc3BhcnNlCiAgICAg ICAgIyBzcGFyc2UgdmVyc2lvbjogdjAuNi4xLWRpcnR5CiAgICAgICAgbWFrZSBBUkNIPXg4Nl82 NCBhbGxtb2Rjb25maWcKICAgICAgICBtYWtlIEM9MSBDRj0nLWZkaWFnbm9zdGljLXByZWZpeCAt RF9fQ0hFQ0tfRU5ESUFOX18nCgpJZiB5b3UgZml4IHRoZSBpc3N1ZSwga2luZGx5IGFkZCBmb2xs b3dpbmcgdGFnClJlcG9ydGVkLWJ5OiBrYnVpbGQgdGVzdCByb2JvdCA8bGtwQGludGVsLmNvbT4K CgpzcGFyc2Ugd2FybmluZ3M6IChuZXcgb25lcyBwcmVmaXhlZCBieSA+PikKCj4+IGRyaXZlcnMv Z3B1L2RybS9kcm1fZmJjb252X2hlbHBlci5jOjk4MTozOTogc3BhcnNlOiBzcGFyc2U6IGluY29y cmVjdCB0eXBlIGluIGFyZ3VtZW50IDEgKGRpZmZlcmVudCBhZGRyZXNzIHNwYWNlcykgQEAgICAg ZXhwZWN0ZWQgdm9pZCBbbm9kZXJlZl0gPGFzbjoyPiAqZHN0IEBAICAgIGdvdCBuOjI+ICpkc3Qg QEAKPj4gZHJpdmVycy9ncHUvZHJtL2RybV9mYmNvbnZfaGVscGVyLmM6OTgxOjM5OiBzcGFyc2U6 ICAgIGV4cGVjdGVkIHZvaWQgW25vZGVyZWZdIDxhc246Mj4gKmRzdAo+PiBkcml2ZXJzL2dwdS9k cm0vZHJtX2ZiY29udl9oZWxwZXIuYzo5ODE6Mzk6IHNwYXJzZTogICAgZ290IHZvaWQgKmRzdAog ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2ZiY29udl9oZWxwZXIuYzo5ODU6NTE6IHNwYXJzZTogc3Bh cnNlOiBpbmNvcnJlY3QgdHlwZSBpbiBhcmd1bWVudCAxIChkaWZmZXJlbnQgYWRkcmVzcyBzcGFj ZXMpIEBAICAgIGV4cGVjdGVkIHZvaWQgW25vZGVyZWZdIDxhc246Mj4gKmRzdCBAQCAgICBnb3Qg bjoyPiAqZHN0IEBACiAgIGRyaXZlcnMvZ3B1L2RybS9kcm1fZmJjb252X2hlbHBlci5jOjk4NTo1 MTogc3BhcnNlOiAgICBleHBlY3RlZCB2b2lkIFtub2RlcmVmXSA8YXNuOjI+ICpkc3QKICAgZHJp dmVycy9ncHUvZHJtL2RybV9mYmNvbnZfaGVscGVyLmM6OTg1OjUxOiBzcGFyc2U6ICAgIGdvdCB2 b2lkICpkc3QKICAgZHJpdmVycy9ncHUvZHJtL2RybV9mYmNvbnZfaGVscGVyLmM6OTkwOjUxOiBz cGFyc2U6IHNwYXJzZTogaW5jb3JyZWN0IHR5cGUgaW4gYXJndW1lbnQgMSAoZGlmZmVyZW50IGFk ZHJlc3Mgc3BhY2VzKSBAQCAgICBleHBlY3RlZCB2b2lkIFtub2RlcmVmXSA8YXNuOjI+ICpkc3Qg QEAgICAgZ290IG46Mj4gKmRzdCBAQAogICBkcml2ZXJzL2dwdS9kcm0vZHJtX2ZiY29udl9oZWxw ZXIuYzo5OTA6NTE6IHNwYXJzZTogICAgZXhwZWN0ZWQgdm9pZCBbbm9kZXJlZl0gPGFzbjoyPiAq ZHN0CiAgIGRyaXZlcnMvZ3B1L2RybS9kcm1fZmJjb252X2hlbHBlci5jOjk5MDo1MTogc3BhcnNl OiAgICBnb3Qgdm9pZCAqZHN0Cj4+IGRyaXZlcnMvZ3B1L2RybS9kcm1fZmJjb252X2hlbHBlci5j OjEyOTE6MjE6IHNwYXJzZTogc3BhcnNlOiBpbmNvcnJlY3QgdHlwZSBpbiBhc3NpZ25tZW50IChk aWZmZXJlbnQgYWRkcmVzcyBzcGFjZXMpIEBAICAgIGV4cGVjdGVkIHZvaWQgKnNjcmVlbl9iYXNl IEBAICAgIGdvdCBjaGFyIFtub2RlcmVmXSA8YXN2b2lkICpzY3JlZW5fYmFzZSBAQAo+PiBkcml2 ZXJzL2dwdS9kcm0vZHJtX2ZiY29udl9oZWxwZXIuYzoxMjkxOjIxOiBzcGFyc2U6ICAgIGV4cGVj dGVkIHZvaWQgKnNjcmVlbl9iYXNlCj4+IGRyaXZlcnMvZ3B1L2RybS9kcm1fZmJjb252X2hlbHBl ci5jOjEyOTE6MjE6IHNwYXJzZTogICAgZ290IGNoYXIgW25vZGVyZWZdIDxhc246Mj4gKnNjcmVl bl9iYXNlCj4+IGRyaXZlcnMvZ3B1L2RybS9kcm1fZmJjb252X2hlbHBlci5jOjEyOTQ6Mjk6IHNw YXJzZTogc3BhcnNlOiBpbmNvcnJlY3QgdHlwZSBpbiBhc3NpZ25tZW50IChkaWZmZXJlbnQgYWRk cmVzcyBzcGFjZXMpIEBAICAgIGV4cGVjdGVkIHZvaWQgKnNjcmVlbl9iYXNlIEBAICAgIGdvdCB2 b2lkIFtub2RlcmVmXSA8YXN2b2lkICpzY3JlZW5fYmFzZSBAQAogICBkcml2ZXJzL2dwdS9kcm0v ZHJtX2ZiY29udl9oZWxwZXIuYzoxMjk0OjI5OiBzcGFyc2U6ICAgIGV4cGVjdGVkIHZvaWQgKnNj cmVlbl9iYXNlCj4+IGRyaXZlcnMvZ3B1L2RybS9kcm1fZmJjb252X2hlbHBlci5jOjEyOTQ6Mjk6 IHNwYXJzZTogICAgZ290IHZvaWQgW25vZGVyZWZdIDxhc246Mj4gKgo+PiBkcml2ZXJzL2dwdS9k cm0vZHJtX2ZiY29udl9oZWxwZXIuYzoxMzE4OjI1OiBzcGFyc2U6IHNwYXJzZTogaW5jb3JyZWN0 IHR5cGUgaW4gYXJndW1lbnQgMSAoZGlmZmVyZW50IGFkZHJlc3Mgc3BhY2VzKSBAQCAgICBleHBl Y3RlZCB2b2lkIHZvbGF0aWxlIFtub2RlcmVmXSA8YXNuOjI+ICphZGRyIEBAICAgIGdvdCBuOjI+ ICphZGRyIEBACj4+IGRyaXZlcnMvZ3B1L2RybS9kcm1fZmJjb252X2hlbHBlci5jOjEzMTg6MjU6 IHNwYXJzZTogICAgZXhwZWN0ZWQgdm9pZCB2b2xhdGlsZSBbbm9kZXJlZl0gPGFzbjoyPiAqYWRk cgo+PiBkcml2ZXJzL2dwdS9kcm0vZHJtX2ZiY29udl9oZWxwZXIuYzoxMzE4OjI1OiBzcGFyc2U6 ICAgIGdvdCB2b2lkICpzY3JlZW5fYmFzZQogICBkcml2ZXJzL2dwdS9kcm0vZHJtX2ZiY29udl9o ZWxwZXIuYzoxMzQ2OjM4OiBzcGFyc2U6IHNwYXJzZTogaW5jb3JyZWN0IHR5cGUgaW4gYXJndW1l bnQgMSAoZGlmZmVyZW50IGFkZHJlc3Mgc3BhY2VzKSBAQCAgICBleHBlY3RlZCB2b2lkIHZvbGF0 aWxlIFtub2RlcmVmXSA8YXNuOjI+ICphZGRyIEBAICAgIGdvdCBuOjI+ICphZGRyIEBACiAgIGRy aXZlcnMvZ3B1L2RybS9kcm1fZmJjb252X2hlbHBlci5jOjEzNDY6Mzg6IHNwYXJzZTogICAgZXhw ZWN0ZWQgdm9pZCB2b2xhdGlsZSBbbm9kZXJlZl0gPGFzbjoyPiAqYWRkcgogICBkcml2ZXJzL2dw dS9kcm0vZHJtX2ZiY29udl9oZWxwZXIuYzoxMzQ2OjM4OiBzcGFyc2U6ICAgIGdvdCB2b2lkICpz Y3JlZW5fYmFzZQoKdmltICs5ODEgZHJpdmVycy9ncHUvZHJtL2RybV9mYmNvbnZfaGVscGVyLmMK CiAgIDk1NgkKICAgOTU3CS8qKgogICA5NTgJICogZHJtX2ZiY29udl9ibGl0X3JlY3QgLSBjb3B5 IGFuIGFyZWEgb2YgcGl4ZWwgZGF0YSBmcm9tIGEgZnJhbWVidWZmZXIKICAgOTU5CSAqCXRvIHRo ZSBoYXJkd2FyZSBidWZmZXIKICAgOTYwCSAqIEBkc3Q6CXRoZSBvbi1zY3JlZW4gaGFyZHdhcmUg YnVmZmVyCiAgIDk2MQkgKiBAdmFkZHI6CXRoZSBzb3VyY2UgYnVmZmVyIGluIGtlcm5lbCBhZGRy ZXNzIHNwYWNlCiAgIDk2MgkgKiBAZmI6CQl0aGUgZnJhbWVidWZmZXIgb2YgdGhlIHNvdXJjZSBi dWZmZXIKICAgOTYzCSAqIEByZWN0Ogl0aGUgYXJlYSB0byBjb3B5CiAgIDk2NAkgKiBSZXR1cm5z OgogICA5NjUJICoJMCBvbiBzdWNjZXNzLCBvcgogICA5NjYJICoJYSBuZWdhdGl2ZSBlcnJvciBj b2RlIG90aGVyd2lzZS4KICAgOTY3CSAqCiAgIDk2OAkgKiBUaGlzIGZ1bmN0aW9uIGNvcGllcyB0 aGUgcGl4ZWwgZGF0YSBmcm9tIGEgRFJNIGZyYW1lYnVmZmVyIHRvIGEgaGFyZHdhcmUKICAgOTY5 CSAqIGJ1ZmZlcjsgZG9pbmcgbmVjZXNzYXJ5IGZvcm1hdCBjb252ZXJzaW9uIGluIHRoZSBwcm9j ZXNzLiBOb3QgYWxsCiAgIDk3MAkgKiBjb21iaW5hdGlvbnMgb2Ygc291cmNlIGFuZCBkZXN0aW5h dGlvbiBmb3JtYXRzIGFyZSBjdXJyZW50bHkgc3VwcG9ydGVkLgogICA5NzEJICovCiAgIDk3Mglp bnQgZHJtX2ZiY29udl9ibGl0X3JlY3Qodm9pZCAqZHN0LCB2b2lkICp2YWRkciwgc3RydWN0IGRy bV9mcmFtZWJ1ZmZlciAqZmIsCiAgIDk3MwkJCQkgc3RydWN0IGRybV9yZWN0ICpyZWN0KQogICA5 NzQJewogICA5NzUJCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBmYi0+ZGV2OwogICA5NzYJCiAg IDk3NwkJaWYgKCF2YWRkcikKICAgOTc4CQkJcmV0dXJuIDA7IC8qIG5vIGZyYW1lYnVmZmVyIHNl dCBmb3IgcGxhbmU7IG5vIGVycm9yICovCiAgIDk3OQkKICAgOTgwCQlpZiAoZGV2LT5tb2RlX2Nv bmZpZy5wcmVmZXJyZWRfZGVwdGggPT0gKGZiLT5mb3JtYXQtPmNwcFswXSAqIDgpKQogPiA5ODEJ CQlkcm1fZmJfbWVtY3B5X2RzdGNsaXAoZHN0LCB2YWRkciwgZmIsIHJlY3QpOwogICA5ODIJCiAg IDk4MwkJZWxzZSBpZiAoZmItPmZvcm1hdC0+Y3BwWzBdID09IDQgJiYKICAgOTg0CQkJIGRldi0+ bW9kZV9jb25maWcucHJlZmVycmVkX2RlcHRoID09IDE2KQogPiA5ODUJCQlkcm1fZmJfeHJnYjg4 ODhfdG9fcmdiNTY1X2RzdGNsaXAoZHN0LCBmYi0+cGl0Y2hlc1swXSwKICAgOTg2CQkJCQkJCSAg dmFkZHIsIGZiLCByZWN0LCBmYWxzZSk7CiAgIDk4NwkKICAgOTg4CQllbHNlIGlmIChmYi0+Zm9y bWF0LT5jcHBbMF0gPT0gNCAmJgogICA5ODkJCQkgZGV2LT5tb2RlX2NvbmZpZy5wcmVmZXJyZWRf ZGVwdGggPT0gMjQpCiA+IDk5MAkJCWRybV9mYl94cmdiODg4OF90b19yZ2I4ODhfZHN0Y2xpcChk c3QsIGZiLT5waXRjaGVzWzBdLAogICA5OTEJCQkJCQkJICB2YWRkciwgZmIsIHJlY3QpOwogICA5 OTIJCiAgIDk5MwkJZWxzZSB7CiAgIDk5NAkJCS8qIFRPRE86IGFkZCB0aGUgbWlzc2luZyBjb252 ZXJzaW9uICovCiAgIDk5NQkJCURSTV9FUlJPUigiZmJjb252OiBtaXNtYXRjaGluZyBwaXhlbCBm b3JtYXRzXG4iKTsKICAgOTk2CQkJcmV0dXJuIC1FSU5WQUw7CiAgIDk5NwkJfQogICA5OTgJCiAg IDk5OQkJcmV0dXJuIDA7CiAgMTAwMAl9CiAgMTAwMQlFWFBPUlRfU1lNQk9MKGRybV9mYmNvbnZf YmxpdF9yZWN0KTsKICAxMDAyCQoKLS0tCjAtREFZIGtlcm5lbCB0ZXN0IGluZnJhc3RydWN0dXJl ICAgICAgICAgICAgICAgIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCmh0dHBzOi8vbGlz dHMuMDEub3JnL3BpcGVybWFpbC9rYnVpbGQtYWxsICAgICAgICAgICAgICAgICAgIEludGVsIENv cnBvcmF0aW9uCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1432393784206214671==" MIME-Version: 1.0 From: kbuild test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH v2 08/15] drm/fbconv: Add plane-state check and update Date: Wed, 16 Oct 2019 01:28:50 +0800 Message-ID: <201910160147.NR8eNv8Z%lkp@intel.com> In-Reply-To: <20191014140416.28517-9-tzimmermann@suse.de> List-Id: --===============1432393784206214671== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Thomas, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [cannot apply to v5.4-rc3 next-20191014] [if your patch is applied to the wrong git tree, please drop us a note to h= elp improve the system. BTW, we also suggest to use '--base' option to specify = the base tree in git format-patch, please see https://stackoverflow.com/a/37406= 982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/DRM-fbco= nv-helpers-for-converting-fbdev-drivers/20191015-152231 reproduce: # apt-get install sparse # sparse version: v0.6.1-dirty make ARCH=3Dx86_64 allmodconfig make C=3D1 CF=3D'-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) >> drivers/gpu/drm/drm_fbconv_helper.c:981:39: sparse: sparse: incorrect ty= pe in argument 1 (different address spaces) @@ expected void [noderef] <= asn:2> *dst @@ got n:2> *dst @@ >> drivers/gpu/drm/drm_fbconv_helper.c:981:39: sparse: expected void [no= deref] *dst >> drivers/gpu/drm/drm_fbconv_helper.c:981:39: sparse: got void *dst drivers/gpu/drm/drm_fbconv_helper.c:985:51: sparse: sparse: incorrect ty= pe in argument 1 (different address spaces) @@ expected void [noderef] <= asn:2> *dst @@ got n:2> *dst @@ drivers/gpu/drm/drm_fbconv_helper.c:985:51: sparse: expected void [no= deref] *dst drivers/gpu/drm/drm_fbconv_helper.c:985:51: sparse: got void *dst drivers/gpu/drm/drm_fbconv_helper.c:990:51: sparse: sparse: incorrect ty= pe in argument 1 (different address spaces) @@ expected void [noderef] <= asn:2> *dst @@ got n:2> *dst @@ drivers/gpu/drm/drm_fbconv_helper.c:990:51: sparse: expected void [no= deref] *dst drivers/gpu/drm/drm_fbconv_helper.c:990:51: sparse: got void *dst >> drivers/gpu/drm/drm_fbconv_helper.c:1291:21: sparse: sparse: incorrect t= ype in assignment (different address spaces) @@ expected void *screen_ba= se @@ got char [noderef] > drivers/gpu/drm/drm_fbconv_helper.c:1291:21: sparse: expected void *s= creen_base >> drivers/gpu/drm/drm_fbconv_helper.c:1291:21: sparse: got char [nodere= f] *screen_base >> drivers/gpu/drm/drm_fbconv_helper.c:1294:29: sparse: sparse: incorrect t= ype in assignment (different address spaces) @@ expected void *screen_ba= se @@ got void [noderef] > drivers/gpu/drm/drm_fbconv_helper.c:1294:29: sparse: got void [nodere= f] * >> drivers/gpu/drm/drm_fbconv_helper.c:1318:25: sparse: sparse: incorrect t= ype in argument 1 (different address spaces) @@ expected void volatile [= noderef] *addr @@ got n:2> *addr @@ >> drivers/gpu/drm/drm_fbconv_helper.c:1318:25: sparse: expected void vo= latile [noderef] *addr >> drivers/gpu/drm/drm_fbconv_helper.c:1318:25: sparse: got void *screen= _base drivers/gpu/drm/drm_fbconv_helper.c:1346:38: sparse: sparse: incorrect t= ype in argument 1 (different address spaces) @@ expected void volatile [= noderef] *addr @@ got n:2> *addr @@ drivers/gpu/drm/drm_fbconv_helper.c:1346:38: sparse: expected void vo= latile [noderef] *addr drivers/gpu/drm/drm_fbconv_helper.c:1346:38: sparse: got void *screen= _base vim +981 drivers/gpu/drm/drm_fbconv_helper.c 956 = 957 /** 958 * drm_fbconv_blit_rect - copy an area of pixel data from a framebuf= fer 959 * to the hardware buffer 960 * @dst: the on-screen hardware buffer 961 * @vaddr: the source buffer in kernel address space 962 * @fb: the framebuffer of the source buffer 963 * @rect: the area to copy 964 * Returns: 965 * 0 on success, or 966 * a negative error code otherwise. 967 * 968 * This function copies the pixel data from a DRM framebuffer to a h= ardware 969 * buffer; doing necessary format conversion in the process. Not all 970 * combinations of source and destination formats are currently supp= orted. 971 */ 972 int drm_fbconv_blit_rect(void *dst, void *vaddr, struct drm_framebuf= fer *fb, 973 struct drm_rect *rect) 974 { 975 struct drm_device *dev =3D fb->dev; 976 = 977 if (!vaddr) 978 return 0; /* no framebuffer set for plane; no error */ 979 = 980 if (dev->mode_config.preferred_depth =3D=3D (fb->format->cpp[0] * 8= )) > 981 drm_fb_memcpy_dstclip(dst, vaddr, fb, rect); 982 = 983 else if (fb->format->cpp[0] =3D=3D 4 && 984 dev->mode_config.preferred_depth =3D=3D 16) > 985 drm_fb_xrgb8888_to_rgb565_dstclip(dst, fb->pitches[0], 986 vaddr, fb, rect, false); 987 = 988 else if (fb->format->cpp[0] =3D=3D 4 && 989 dev->mode_config.preferred_depth =3D=3D 24) > 990 drm_fb_xrgb8888_to_rgb888_dstclip(dst, fb->pitches[0], 991 vaddr, fb, rect); 992 = 993 else { 994 /* TODO: add the missing conversion */ 995 DRM_ERROR("fbconv: mismatching pixel formats\n"); 996 return -EINVAL; 997 } 998 = 999 return 0; 1000 } 1001 EXPORT_SYMBOL(drm_fbconv_blit_rect); 1002 = --- 0-DAY kernel test infrastructure Open Source Technology Cent= er https://lists.01.org/pipermail/kbuild-all Intel Corporati= on --===============1432393784206214671==--