All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Fabrice Gasnier" <fabrice.gasnier@st.com>,
	linux-pwm@vger.kernel.org
Subject: [PATCH 0/3] pwm: stm32: Minor cleanups
Date: Wed, 16 Oct 2019 09:38:39 +0200	[thread overview]
Message-ID: <20191016073842.1300297-1-thierry.reding@gmail.com> (raw)

Hi,

Looking at Fabrice's STM32 patches I noticed that we're now passing the
breakinput values (u32) into a function via int parameters. The easiest
way to fix this inconsistency is by just passing a pointer to the break
input structure. There's some preparatory work here that makes the code
slightly more readable, in my opinion, but it's really marginal, so I'm
not terribly thrilled by this series in retrospect.

If nobody else thinks this is a big improvement I'll just scrap it.

Thierry

Thierry Reding (3):
  pwm: stm32: Remove clutter from ternary operator
  pwm: stm32: Remove confusing bitmask
  pwm: stm32: Pass breakinput instead of its values

 drivers/pwm/pwm-stm32.c | 37 ++++++++++++++++++++-----------------
 1 file changed, 20 insertions(+), 17 deletions(-)

-- 
2.23.0

             reply	other threads:[~2019-10-16  7:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16  7:38 Thierry Reding [this message]
2019-10-16  7:38 ` [PATCH 1/3] pwm: stm32: Remove clutter from ternary operator Thierry Reding
2019-10-16  8:26   ` Uwe Kleine-König
2019-10-16  9:30     ` Thierry Reding
2019-10-16  7:38 ` [PATCH 2/3] pwm: stm32: Remove confusing bitmask Thierry Reding
2019-10-16  8:31   ` Uwe Kleine-König
2019-10-16  9:50     ` Thierry Reding
2019-10-16 10:20       ` Fabrice Gasnier
2019-10-16 10:52         ` Uwe Kleine-König
2019-10-16  7:38 ` [PATCH 3/3] pwm: stm32: Pass breakinput instead of its values Thierry Reding
2019-10-16  8:33 ` [PATCH 0/3] pwm: stm32: Minor cleanups Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191016073842.1300297-1-thierry.reding@gmail.com \
    --to=thierry.reding@gmail.com \
    --cc=fabrice.gasnier@st.com \
    --cc=linux-pwm@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.