All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH] iio: light: adux1020: Drop an unwanted semicolon.
Date: Wed, 16 Oct 2019 14:17:56 +0530	[thread overview]
Message-ID: <20191016084756.GC2288@Mani-XPS-13-9360> (raw)
In-Reply-To: <20191015211215.1c78c8a5@archlinux>

Hi Jonathan,

On Tue, Oct 15, 2019 at 09:12:15PM +0100, Jonathan Cameron wrote:
> On Sun, 13 Oct 2019 18:38:52 +0100
> jic23@kernel.org wrote:
> 
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > Suggested by coccinelle
> > 
> > CHECK   drivers/iio/light/adux1020.c
> > drivers/iio/light/adux1020.c:747:2-3: Unneeded semicolon
> > 
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> 0-day sent me the same patch as well.
> 
> I've rolled it into the original code as that was still on 
> testing only which was getting rebased anyway.
>

Makes sense!

Thanks,
Mani
 
> Thanks,
> 
> Jonathan
> 
> > ---
> >  drivers/iio/light/adux1020.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/light/adux1020.c b/drivers/iio/light/adux1020.c
> > index 830e5e95d58f..b07797ac10d7 100644
> > --- a/drivers/iio/light/adux1020.c
> > +++ b/drivers/iio/light/adux1020.c
> > @@ -744,7 +744,7 @@ static int adux1020_chip_init(struct adux1020_data *data)
> >  	if ((val & ADUX1020_CHIP_ID_MASK) != ADUX1020_CHIP_ID) {
> >  		dev_err(&client->dev, "invalid chip id 0x%04x\n", val);
> >  		return -ENODEV;
> > -	};
> > +	}
> >  
> >  	dev_dbg(&client->dev, "Detected ADUX1020 with chip id: 0x%04x\n", val);
> >  
> 

      reply	other threads:[~2019-10-16  8:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-13 17:38 [PATCH] iio: light: adux1020: Drop an unwanted semicolon jic23
2019-10-15 20:12 ` Jonathan Cameron
2019-10-16  8:47   ` Manivannan Sadhasivam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191016084756.GC2288@Mani-XPS-13-9360 \
    --to=manivannan.sadhasivam@linaro.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.