All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] testcases/kernel: Add linux git and CVE tags
Date: Wed, 16 Oct 2019 15:21:39 +0200	[thread overview]
Message-ID: <20191016132139.GA4526@dell5510> (raw)
In-Reply-To: <20191015095225.GA14021@rei>

Hi,

> > > +       .tags = (const struct tst_tag[]) {
> > > +               {"linux-git", "4291086b1f08"},
> > > +               {"CVE", "2014-0196"},
> > > +               {}

> > Some of the tests use {NULL, NULL} to terminate tag array but some not,
> > maybe we need to keep consistent in usage.

> I guess I missed some when I was converting {NULL, NULL} to just {}. I
> will fix that in v2.
+1

Nice work, thanks :).
Reviewed-by: Petr Vorel <pvorel@suse.cz>

nit: I don't that much blank lines, I'd prefer more compact output:

OPTIONS
-h       Prints this help
-i n     Execute test n times
-I x     Execute test for n seconds
-C ARG   Run child process with ARG arguments (used internally)

TAGS
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0c461cb727d1
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-2618

Kind regards,
Petr

  reply	other threads:[~2019-10-16 13:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-14 11:25 [LTP] [PATCH 0/2] Add support for a test tags Cyril Hrubis
2019-10-14 11:25 ` [LTP] [PATCH 1/2] lib: Add support for " Cyril Hrubis
2019-10-15  5:12   ` Li Wang
2019-10-15  7:42     ` Richard Palethorpe
2019-10-15  9:57       ` Cyril Hrubis
2019-10-15  9:54     ` Cyril Hrubis
2019-10-16 13:30   ` Petr Vorel
2019-10-16 14:46     ` Cyril Hrubis
2019-10-16 19:43       ` Petr Vorel
2019-10-14 11:25 ` [LTP] [PATCH 2/2] testcases/kernel: Add linux git and CVE tags Cyril Hrubis
2019-10-15  4:54   ` Li Wang
2019-10-15  9:52     ` Cyril Hrubis
2019-10-16 13:21       ` Petr Vorel [this message]
2019-10-17  3:22         ` Li Wang
2019-10-17  8:38         ` Jan Stancek
  -- strict thread matches above, loose matches on Subject: below --
2019-10-14 11:23 [LTP] [PATCH 0/2] Add support for a test tags Cyril Hrubis
2019-10-14 11:23 ` [LTP] [PATCH 2/2] testcases/kernel: Add linux git and CVE tags Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191016132139.GA4526@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.